5 years agoeditTests: Use the correct list of parser test files
Kunal Mehta [Fri, 9 Feb 2018 20:08:05 +0000 (12:08 -0800)]
editTests: Use the correct list of parser test files

$wgParserTestFiles is deprecated, so this wasn't running the core parser
tests. Using ParserTestRunner::getParserTestFiles() includes everything,
including autodiscovered extension parser tests.

Change-Id: Ie3b02565c184e8e06931ab52a39ca8ae0877aab9

5 years agoAdd a few more @covers to ParserIntegrationTest
Kunal Mehta [Fri, 9 Feb 2018 19:18:30 +0000 (11:18 -0800)]
Add a few more @covers to ParserIntegrationTest

Change-Id: I638077683d9d3cb40f81b4f4d594f16c349f1519

5 years agoFix CommentStore->createComment() call in LocalFile.php
Brad Jorsch [Fri, 9 Feb 2018 17:43:30 +0000 (12:43 -0500)]
Fix CommentStore->createComment() call in LocalFile.php

This was incorrectly changed in I3abb62a5, createComment() is not one of
the methods that was adjusted in that patch.

Change-Id: I9c26e0ad69ffc6fa5349a6975a4134efb3cf0eff

5 years agoMerge "rdbms: make DOMAIN_ANY ignore bogus MySQL DB names in config"
jenkins-bot [Fri, 9 Feb 2018 13:47:40 +0000 (13:47 +0000)]
Merge "rdbms: make DOMAIN_ANY ignore bogus MySQL DB names in config"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 9 Feb 2018 07:33:06 +0000 (08:33 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I79bd58ffc0181305a64d1a8c379b58547e3a745c

5 years agordbms: make DOMAIN_ANY ignore bogus MySQL DB names in config
Aaron Schulz [Fri, 9 Feb 2018 02:48:38 +0000 (18:48 -0800)]
rdbms: make DOMAIN_ANY ignore bogus MySQL DB names in config

This regressed in 14ee3f2, trying to select the server config
"dbname" value as the database on connect. If that config is
bogus, then the connection attempt would fail. Instead, always
pass null to the driver's connection function if the DB domain
doesn't matter.

This affected WMF sites during lag checks, on account of the
"serverTemplate" value in $wgLBFactoryConf always using the local
wiki domain (whether the cluster had such a database or not).

Use strlen() as mysqli sees null and "" as the same for $dbname.

Bug: T186764
Change-Id: I6699d17c0125a08415046211fee7906bbaf2c366

5 years agojquery.textSelection: Add 'replaceSelection' method
Bartosz Dziewoński [Thu, 8 Feb 2018 18:30:42 +0000 (19:30 +0100)]
jquery.textSelection: Add 'replaceSelection' method

replaceSelection is a little brother of encapsulateSelection.
It can't do as much, but tries really hard to do it well.

Alternative textSelection APIs can implement it in an optimized
way if they can more efficiently replace small fragments of the
textfield's contents than the entire thing.

* encapsulateSelection uses replaceSelection internally.
* setContents now also preserves the scroll position.
* setContents is now chainable.

Bug: T185917
Change-Id: I05086ddce2ddd857ff88eba75cfdb6bf877bd924

5 years agoMerge "Make it possible to not propagate errors to PHP"
jenkins-bot [Thu, 8 Feb 2018 23:02:55 +0000 (23:02 +0000)]
Merge "Make it possible to not propagate errors to PHP"

5 years agoMerge "Fix sessionfailure i18n message during authentication"
jenkins-bot [Thu, 8 Feb 2018 22:47:40 +0000 (22:47 +0000)]
Merge "Fix sessionfailure i18n message during authentication"

5 years agoMerge "jquery.textSelection: Implement 'encapsulateSelection' in terms of the other...
jenkins-bot [Thu, 8 Feb 2018 22:20:04 +0000 (22:20 +0000)]
Merge "jquery.textSelection: Implement 'encapsulateSelection' in terms of the other commands"

5 years agoMake it possible to not propagate errors to PHP
Gergő Tisza [Tue, 21 Feb 2017 00:47:07 +0000 (16:47 -0800)]
Make it possible to not propagate errors to PHP

Add a $wgPropagateErrors configuration variable which can be used
to prevent passing handled errors to PHP (and thus logging them twice).

Bug: T45086
Change-Id: I64ab09762a04de2007b7d7864e3c504a1d6f8aee

5 years agoMerge "Update mediawiki/at-ease"
jenkins-bot [Thu, 8 Feb 2018 21:17:49 +0000 (21:17 +0000)]
Merge "Update mediawiki/at-ease"

5 years agoMerge "ApiFormatBase: Encode filenames in Content-Disposition"
jenkins-bot [Thu, 8 Feb 2018 21:16:26 +0000 (21:16 +0000)]
Merge "ApiFormatBase: Encode filenames in Content-Disposition"

5 years agoMerge "Add @covers tags for parser tests"
jenkins-bot [Thu, 8 Feb 2018 21:01:24 +0000 (21:01 +0000)]
Merge "Add @covers tags for parser tests"

5 years agoMerge "Fix phpdoc description of RevisionStore::insertRevisionOn"
jenkins-bot [Thu, 8 Feb 2018 20:48:00 +0000 (20:48 +0000)]
Merge "Fix phpdoc description of RevisionStore::insertRevisionOn"

5 years agoMerge "DI for CommentStore in RevisionStore"
jenkins-bot [Thu, 8 Feb 2018 20:44:30 +0000 (20:44 +0000)]
Merge "DI for CommentStore in RevisionStore"

5 years agoMerge "Remove unused code from LegacyHookPreAuthenticationProvider"
jenkins-bot [Thu, 8 Feb 2018 20:44:28 +0000 (20:44 +0000)]
Merge "Remove unused code from LegacyHookPreAuthenticationProvider"

5 years agoFix some broken @var comments and add missing uses
Thiemo Mättig [Thu, 8 Feb 2018 14:10:23 +0000 (15:10 +0100)]
Fix some broken @var comments and add missing uses

Change-Id: I2091f4107b6c23d9c3b698999147ce3a2ec38b66

5 years agoFix phpdoc description of RevisionStore::insertRevisionOn
addshore [Mon, 29 Jan 2018 14:34:05 +0000 (14:34 +0000)]
Fix phpdoc description of RevisionStore::insertRevisionOn

Change-Id: Iae0ac4cf98b1cc93eb5a9f8bb97e64b5ea1d9f0f

5 years agoDI for CommentStore in RevisionStore
addshore [Mon, 29 Jan 2018 14:25:49 +0000 (14:25 +0000)]
DI for CommentStore in RevisionStore

Change-Id: I527388514489e79c53b6016a8bd3119ee1750c83

5 years agoRemove unused code from LegacyHookPreAuthenticationProvider
Thiemo Mättig [Wed, 10 Jan 2018 13:34:35 +0000 (14:34 +0100)]
Remove unused code from LegacyHookPreAuthenticationProvider

Change-Id: I699947fe02f649e24c957eb9790fcff91cb2c14a

5 years agoMerge "rdbms: apply minimum sanity timeout for all cases of LoadBalancer::doWait()"
jenkins-bot [Thu, 8 Feb 2018 07:03:31 +0000 (07:03 +0000)]
Merge "rdbms: apply minimum sanity timeout for all cases of LoadBalancer::doWait()"

5 years agoMerge "objectcache: remove unused constant and expand on a comment"
jenkins-bot [Thu, 8 Feb 2018 06:46:38 +0000 (06:46 +0000)]
Merge "objectcache: remove unused constant and expand on a comment"

5 years agoAdd @covers tags for parser tests
Kunal Mehta [Thu, 8 Feb 2018 06:00:29 +0000 (22:00 -0800)]
Add @covers tags for parser tests

Change-Id: I24d3550a07be7a5699475047eb78806f36caec2e

5 years agoMerge "Revert legend when results are grouped"
jenkins-bot [Thu, 8 Feb 2018 00:35:40 +0000 (00:35 +0000)]
Merge "Revert legend when results are grouped"

5 years agoobjectcache: remove unused constant and expand on a comment
Aaron Schulz [Thu, 8 Feb 2018 00:15:32 +0000 (16:15 -0800)]
objectcache: remove unused constant and expand on a comment

Change-Id: I3342497d657291d20325a3d87cc634f53d7776c4

5 years agoMerge "Drop XCache support"
jenkins-bot [Wed, 7 Feb 2018 22:24:46 +0000 (22:24 +0000)]
Merge "Drop XCache support"

5 years agoMerge "Fix for warning in ForeignAPIFile when no thumbnails"
jenkins-bot [Wed, 7 Feb 2018 21:50:44 +0000 (21:50 +0000)]
Merge "Fix for warning in ForeignAPIFile when no thumbnails"

5 years agoDrop XCache support
Chad Horohoe [Tue, 6 Feb 2018 02:11:27 +0000 (18:11 -0800)]
Drop XCache support

It was never super popular anyway, APC was always the best option.
The project has no plans to move to PHP7, so it's quickly reaching
its end of life. Oh, and Fedora dropped it from their repos 2 years

Change-Id: Ia3257e86a6323d8943f04a5c05c72c0bd4c4b0a9

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 7 Feb 2018 20:54:49 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I7fa8feca5bdc1394bc24f3d93aaee1f7be2c2f9e

5 years agoApiFormatBase: Encode filenames in Content-Disposition
Brad Jorsch [Wed, 7 Feb 2018 20:12:33 +0000 (15:12 -0500)]
ApiFormatBase: Encode filenames in Content-Disposition

The return value for ApiFormatBase::getFilename() was formerly
documented as "must be encoded for inclusion in a Content-Disposition
header's filename parameter." While this is ok for the common use case
where the module is returning a constant string or can assume whatever
it gets back from getExtensionsForType() is ok, it's not in general a
good idea to make all callers handle that.

Further, it's not possible to represent characters outside of the
ISO-8859-1 character set in a 'filename' parameter. You have to use
'filename*' to do that (see RFC 5987 and RFC 6266).

So, this patch changes the definition of getFilename() to remove the
encoding requirement, and adds code to properly convert and escape the
value for the 'filename' and (if necessary) 'filename*' parameters.

Note this may give unexpected results (double encoding) if any module
actually is returning an encoded filename. I don't see any such cases in
core or in extensions in Gerrit.

Change-Id: I0c2749a847b639f228efff4e1917a61612a1f7d1

5 years agojquery.textSelection: Implement 'encapsulateSelection' in terms of the other commands
Bartosz Dziewoński [Mon, 5 Feb 2018 22:44:05 +0000 (23:44 +0100)]
jquery.textSelection: Implement 'encapsulateSelection' in terms of the other commands

Any users of jquery.textSelection that add an alternative API using
'register' no longer have to override 'encapsulateSelection' (which is
a big beast), as long as the other commands are implemented.

Bug: T185917
Change-Id: I39bbbce20336a1286a07bf8032acdfb8a7e0cdb6

5 years agojquery.textSelection: Remove incorrect browser hack for old Opera
Bartosz Dziewoński [Mon, 5 Feb 2018 22:13:50 +0000 (23:13 +0100)]
jquery.textSelection: Remove incorrect browser hack for old Opera

This code appears to be incorrect, at least on Opera 12.18 on Windows 10,
where I just tested it. It causes the selection to be misaligned, rather
than correct it.

For example, the following code:

    $textbox.textSelection( 'encapsulateSelection', { peri: 'foo\nfoo' } );

Causes the selection to extend one character past the inserted text with
the hack, and to be shown correctly without the hack.

It is theoretically possible that this hack was necessary for some other
operating system, but then it should have also been applied to 'insertText'.
Also, Opera 12 only has a usage share (barely) large enough to show up on
<https://analytics.wikimedia.org/dashboards/browsers/> on Windows (XP).

Change-Id: Ifee877c6202bcfc0fecb65220e34b4b39659dbeb

5 years agojquery.textSelection: Remove unnecessary checks
Bartosz Dziewoński [Mon, 5 Feb 2018 21:52:05 +0000 (22:52 +0100)]
jquery.textSelection: Remove unnecessary checks

Some of the commands were wrapped in unnecessary checks (which were
also inconsistent between the different commands):

* Checking if this element is hidden. I'm guessing this was a
  workaround for some IE 6 bugs where doing things to the selection
  of hidden elements would break horribly. In any case, this should
  not be this code's responsibility.

* Checking for undefined this.selectionStart. I probably should have
  removed these in 1430ca85dcf9cb3f77a92bee6a915473e465f649. The only
  remaining case for them would be if .textSelection() is called on
  something that is not a text input element, which should not happen.

Change-Id: Ib09e64399921fe3861efd4877c6ecb2f900aef09

5 years agoMerge "rdbms: remove obsolete getReplicaPos() code"
jenkins-bot [Wed, 7 Feb 2018 18:45:39 +0000 (18:45 +0000)]
Merge "rdbms: remove obsolete getReplicaPos() code"

5 years agoFix for warning in ForeignAPIFile when no thumbnails
Brion Vibber [Wed, 7 Feb 2018 18:39:03 +0000 (10:39 -0800)]
Fix for warning in ForeignAPIFile when no thumbnails

Remote audio files have no thumbnails, so this check in
ForeignAPIFile for thumbnails by iterating over the result
from FileBackend::getFileList() could throw a warning about
invalid input to foreach, as it may return null.

Change-Id: I07f37ed5a299e1a3c9a1e6bddcbc5582f99e5274

5 years agoMerge "Add @covers for BlockLevelPass"
jenkins-bot [Wed, 7 Feb 2018 15:54:37 +0000 (15:54 +0000)]
Merge "Add @covers for BlockLevelPass"

5 years agoMerge "jquery.textSelection: Rewrite 'scrollToCaretPosition'"
jenkins-bot [Wed, 7 Feb 2018 14:51:12 +0000 (14:51 +0000)]
Merge "jquery.textSelection: Rewrite 'scrollToCaretPosition'"

5 years agoUpdate mediawiki/at-ease
Reedy [Wed, 7 Feb 2018 11:03:36 +0000 (11:03 +0000)]
Update mediawiki/at-ease

* mediawiki/at-ease v1.1.0 -> v1.2.0


Bug: T182273
Change-Id: Idd686bf84a44f2106ae13a31516872545946aa03
Depends-On: I1966eaec7e4105f876206ab4cd606cefdaeb0add

5 years agoAdd support for Kumyk (kum)
MarcoAurelio [Tue, 6 Feb 2018 21:52:11 +0000 (22:52 +0100)]
Add support for Kumyk (kum)

Bug: T186647
Change-Id: I704e493d743d54071fc6f5341ea04e8a48ebaad7

5 years agoMerge "Add support from Guianan Creole (gcr)"
jenkins-bot [Wed, 7 Feb 2018 10:25:00 +0000 (10:25 +0000)]
Merge "Add support from Guianan Creole (gcr)"

5 years agoUse new TagMultiselectWidget in ApiSandbox
Brad Jorsch [Wed, 20 Dec 2017 15:49:49 +0000 (10:49 -0500)]
Use new TagMultiselectWidget in ApiSandbox

It seems to be generally a 1:1 replacement.

Bug: T183299
Change-Id: I191a99bd373b0fb320770e9089278a16964d80d2

5 years agordbms: remove obsolete getReplicaPos() code
Aaron Schulz [Wed, 7 Feb 2018 01:18:00 +0000 (17:18 -0800)]
rdbms: remove obsolete getReplicaPos() code

Also fixed incorrect comment for getGtidCoordinates()

Change-Id: Ie2ce8a8bba230ceb6d068957e5ffeb360c3fe473

5 years agoUpdate OOUI to v0.25.2
Volker E [Wed, 7 Feb 2018 01:17:20 +0000 (17:17 -0800)]
Update OOUI to v0.25.2

Release notes:

Depends-on: Ib00f16ef5e74732068822dc10d43314098b8fa59
Change-Id: Ie327a10622b64b7f969283497822c494c513585b

5 years agordbms: apply minimum sanity timeout for all cases of LoadBalancer::doWait()
Aaron Schulz [Wed, 7 Feb 2018 00:47:00 +0000 (16:47 -0800)]
rdbms: apply minimum sanity timeout for all cases of LoadBalancer::doWait()

Change-Id: I61b4da6429b390e5aae65d1a30adc6df59687d8c

5 years agoMerge "MWHttpRequest: Restore ability to pass null for $options"
jenkins-bot [Tue, 6 Feb 2018 23:48:23 +0000 (23:48 +0000)]
Merge "MWHttpRequest: Restore ability to pass null for $options"

5 years agojquery.textSelection: Rewrite 'scrollToCaretPosition'
Bartosz Dziewoński [Mon, 5 Feb 2018 14:08:52 +0000 (15:08 +0100)]
jquery.textSelection: Rewrite 'scrollToCaretPosition'

The previous version tried to assume some platform-dependent
things about text rendering and guess the position based on
that. It did not work very well.

Change-Id: I9f4c465692cf128b7758de4ca75f977e8f8be83e

5 years agoMerge "Hard deprecate UtfNormalUtil"
jenkins-bot [Tue, 6 Feb 2018 22:59:45 +0000 (22:59 +0000)]
Merge "Hard deprecate UtfNormalUtil"

5 years agoHard deprecate UtfNormalUtil
Max Semenik [Tue, 15 Aug 2017 01:44:40 +0000 (18:44 -0700)]
Hard deprecate UtfNormalUtil

Deprecated in 1.25, last vestiges have been removed.

Inline one last function that's not supposed to be public anyway.

Change-Id: If44c6a9cce7d2d95dc63e6f135b73b8c969f1c07

5 years agoMerge "jquery.textSelection: Document methods and parameters"
jenkins-bot [Tue, 6 Feb 2018 22:35:01 +0000 (22:35 +0000)]
Merge "jquery.textSelection: Document methods and parameters"

5 years agoRevert legend when results are grouped
petarpetkovic [Tue, 6 Feb 2018 22:33:02 +0000 (23:33 +0100)]
Revert legend when results are grouped

Since Ifecaaff572, legend was using position: absolute when results are
grouped by page. Most users found such behavior annoying and unexpected,
so positioning is being reverted to previous state.

Only change besides reverting is preventing collapsed legend to push
away the surrounding results. Without that, we would have scenarios
where legend is expanded and collapsed, but results are pushed away as
if legend is still expanded.

Bug: T182156
Bug: T184165
Change-Id: I5adb7e1cb793ec30fba9d5d9674a7fa294d9a3a5

5 years agoMerge "jquery.textSelection: Move copyright comments to the top of the file"
jenkins-bot [Tue, 6 Feb 2018 22:15:30 +0000 (22:15 +0000)]
Merge "jquery.textSelection: Move copyright comments to the top of the file"

5 years agoMerge "Fix localization of time in Turkish"
jenkins-bot [Tue, 6 Feb 2018 22:04:54 +0000 (22:04 +0000)]
Merge "Fix localization of time in Turkish"

5 years agoAdd support from Guianan Creole (gcr)
MarcoAurelio [Tue, 6 Feb 2018 21:35:04 +0000 (22:35 +0100)]
Add support from Guianan Creole (gcr)

Bug: T186635
Change-Id: I13334bb83562fc943fd69ef1f0fc3cd85aceffe1

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 6 Feb 2018 21:09:24 +0000 (22:09 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I70882c277fb173e316e0ed90712fbe93628ab4d6

5 years agoMWHttpRequest: Restore ability to pass null for $options
Kunal Mehta [Tue, 6 Feb 2018 21:05:02 +0000 (13:05 -0800)]
MWHttpRequest: Restore ability to pass null for $options

Prior to 3de744597e34, it was possible to pass `null` for $options.
Restore that by setting the default type to be null, and explicitly
document that null is a supported value in the doc block.

Also update the signature of MWHttpRequestTester to match.

Change-Id: I74d586afa5527e0a30ea99f3989f4dd12fa9fea1

5 years agoFix sessionfailure i18n message during authentication
Alangi Derick [Thu, 1 Feb 2018 09:11:34 +0000 (10:11 +0100)]
Fix sessionfailure i18n message during authentication

Confusing message about session failure, telling the user to
resubmit the form is a better feedback message as most of the
time, it could be a session timeout causing the failure.

Bug: T181960
Change-Id: I8a644ac8adb89ec83a8e3b5a5ad4a2d8dc5c1d8c

5 years agojquery.textSelection: Document methods and parameters
Bartosz Dziewoński [Mon, 5 Feb 2018 15:54:28 +0000 (16:54 +0100)]
jquery.textSelection: Document methods and parameters

Change-Id: I9e4112a75ae7abc8c479efc39a438c3b59933418

5 years agojquery.textSelection: Move copyright comments to the top of the file
Bartosz Dziewoński [Mon, 5 Feb 2018 13:21:36 +0000 (14:21 +0100)]
jquery.textSelection: Move copyright comments to the top of the file

Functions' doc comments should only document the function.

Change-Id: I56f21b49a35bf191a930d39af2f2020cdeb6ca30

5 years agoDI for CommentStore in WatchedItemQueryService
addshore [Fri, 26 Jan 2018 19:17:27 +0000 (11:17 -0800)]
DI for CommentStore in WatchedItemQueryService

Change-Id: I93d9ed5f66297da7009d5b99aa9ed48e1b10582f

5 years agoMerge "Mock CommentStore in some RevisionTest tests"
jenkins-bot [Tue, 6 Feb 2018 15:32:03 +0000 (15:32 +0000)]
Merge "Mock CommentStore in some RevisionTest tests"

5 years agoMerge "Pass $key into CommentStore methods and use MediawikiServices"
jenkins-bot [Tue, 6 Feb 2018 15:31:59 +0000 (15:31 +0000)]
Merge "Pass $key into CommentStore methods and use MediawikiServices"

5 years agoMerge "Add @covers for RemexStripTagHandler"
jenkins-bot [Tue, 6 Feb 2018 14:52:59 +0000 (14:52 +0000)]
Merge "Add @covers for RemexStripTagHandler"

5 years agoMock CommentStore in some RevisionTest tests
addshore [Thu, 25 Jan 2018 02:07:33 +0000 (18:07 -0800)]
Mock CommentStore in some RevisionTest tests

Change-Id: I16b00a5514547d93a2308393098e3b363505374e

5 years agoMerge "[MCR] RevisionStore::getTitle final logged fallback to master"
jenkins-bot [Tue, 6 Feb 2018 11:42:52 +0000 (11:42 +0000)]
Merge "[MCR] RevisionStore::getTitle final logged fallback to master"

5 years agoAdd @covers for BlockLevelPass
Kunal Mehta [Tue, 6 Feb 2018 05:21:37 +0000 (21:21 -0800)]
Add @covers for BlockLevelPass

This class was split out of Parser, so it now needs separate covers tags.

Change-Id: I06c4a6a4fac3d6ff13924e3ca45ee134f7eeab20

5 years agoAdd @covers for RemexStripTagHandler
Kunal Mehta [Tue, 6 Feb 2018 05:15:52 +0000 (21:15 -0800)]
Add @covers for RemexStripTagHandler

This internal class is only used by Sanitizer::stripAllTags().

Change-Id: Ib913ee14524539216305da7e3183c07ab7d72cb5

5 years agoMerge "Use HTTPS instead of HTTP for interwiki"
jenkins-bot [Mon, 5 Feb 2018 23:39:35 +0000 (23:39 +0000)]
Merge "Use HTTPS instead of HTTP for interwiki"

5 years agoMerge "installer messages: Move to https: links when available"
jenkins-bot [Mon, 5 Feb 2018 23:25:39 +0000 (23:25 +0000)]
Merge "installer messages: Move to https: links when available"

5 years agoMerge "Follow-up ed76b6736: Also remove the now-unused $mExtStyles"
jenkins-bot [Mon, 5 Feb 2018 23:17:59 +0000 (23:17 +0000)]
Merge "Follow-up ed76b6736: Also remove the now-unused $mExtStyles"

5 years agoinstaller messages: Move to https: links when available
Platonides [Mon, 8 Jan 2018 00:01:26 +0000 (01:01 +0100)]
installer messages: Move to https: links when available

Change links used in the installer from http:// to https://
when the linked content is available at the same hostname
using HTTPS.

Change-Id: Ib5afcf5ba4aa6da360c926794e6a021e85008d6c

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 5 Feb 2018 20:59:39 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia4e5683f7d850983a5fd76097f2cd3c82daca667

5 years agoRemove superfluous spaces and semicolons in comments
Fomafix [Mon, 5 Feb 2018 18:21:09 +0000 (19:21 +0100)]
Remove superfluous spaces and semicolons in comments

Change-Id: Ib4b452f1843ec250c8c1fcc2a738d80726b6135d

5 years agoFollow-up ed76b6736: Also remove the now-unused $mExtStyles
James D. Forrester [Mon, 5 Feb 2018 17:37:41 +0000 (09:37 -0800)]
Follow-up ed76b6736: Also remove the now-unused $mExtStyles

Change-Id: I7622ba15b03df97213acd82e4a3fa78267a30d55

5 years agoMerge "jquery.textSelection: Fix typo"
jenkins-bot [Mon, 5 Feb 2018 16:53:47 +0000 (16:53 +0000)]
Merge "jquery.textSelection: Fix typo"

5 years agoMerge "jquery.localize: Fix rendering of generated documentation"
jenkins-bot [Mon, 5 Feb 2018 16:53:44 +0000 (16:53 +0000)]
Merge "jquery.localize: Fix rendering of generated documentation"

5 years agojquery.textSelection: Fix typo
Bartosz Dziewoński [Mon, 5 Feb 2018 15:51:53 +0000 (16:51 +0100)]
jquery.textSelection: Fix typo

Probably nothing is using this event.

Change-Id: I5e4a8a741b46868f8a1d55257a980aa0853fbb6c

5 years agoMerge "Force CommentMigration MIGRATION_OLD in 2 RevisionTest tests"
jenkins-bot [Mon, 5 Feb 2018 15:44:18 +0000 (15:44 +0000)]
Merge "Force CommentMigration MIGRATION_OLD in 2 RevisionTest tests"

5 years agoPass $key into CommentStore methods and use MediawikiServices
addshore [Wed, 24 Jan 2018 23:41:01 +0000 (15:41 -0800)]
Pass $key into CommentStore methods and use MediawikiServices

This allows CommentStore to be added to MediaWikiServices
without the need of an aditional Factory.

This change includes a compatability layer to allow the behaviour
from 1.30 to continue to be used while deprecated.

CommentStore::newKey has been deprecated.
Keys are now passed into the public methods of CommentStore
where needed.
The following CommentStore methods have had their signatures changed
to introduced a $key parameter, but when used in conjunction with
CommentStore::newKey behaviour will remain unchanged:
  * CommentStore::getFields
  * CommentStore::getJoin
  * CommentStore::getComment
  * CommentStore::getCommentLegacy
  * CommentStore::insert
  * CommentStore::insertWithTemplate

Change-Id: I3abb62a5cfb0dcd456da9f4eb35583476ae41cfb

5 years agoUse HTTPS instead of HTTP for interwiki
Fomafix [Mon, 5 Feb 2018 13:45:53 +0000 (14:45 +0100)]
Use HTTPS instead of HTTP for interwiki

Switch from HTTP to HTTPS where the HTTP URL redirects to the HTTPS URL
or where the HTTP URL and the HTTPS URL deliveres the same content.

Change-Id: I51947ae93cc9e6a30bb31eee7ff13561fc94ece4

5 years agojquery.localize: Fix rendering of generated documentation
Bartosz Dziewoński [Mon, 5 Feb 2018 14:50:24 +0000 (15:50 +0100)]
jquery.localize: Fix rendering of generated documentation

JSDuck expects an empty line before and after code samples.

Change-Id: I45cf3a8e7c88476e61a681cfc44fc497e8f1c67e

5 years agoMerge "Preload module 'mediawiki.notification'"
jenkins-bot [Mon, 5 Feb 2018 12:51:44 +0000 (12:51 +0000)]
Merge "Preload module 'mediawiki.notification'"

5 years agoMerge "Fixing typos for ucfirst magic word translation into Ukrainian: ПЕША_ДІТЕРА...
jenkins-bot [Mon, 5 Feb 2018 08:16:36 +0000 (08:16 +0000)]
Merge "Fixing typos for ucfirst magic word translation into Ukrainian: ПЕША_ДІТЕРА → ПЕРША_ЛІТЕРА."

5 years agoconvertExtensionToRegistration: Set requires key in extension.json
Umherirrender [Fri, 2 Feb 2018 22:19:43 +0000 (23:19 +0100)]
convertExtensionToRegistration: Set requires key in extension.json

The highest manifest version is not supported from the start of
For extensions converted to this highest version the mininum core
version must be specified to avoid load problems in the extension.

Using 1.29.0 for manifest version 2 due to T149757 /

Change-Id: Iea5ba589c70958db7500cf3587b5ebd738532026

5 years agoFix back-compat method Article::updateRedirectOn
Umherirrender [Sun, 4 Feb 2018 21:22:52 +0000 (22:22 +0100)]
Fix back-compat method Article::updateRedirectOn

No reason to set $lastRevIsRedirect to null before pass it as argument

Change-Id: I5e3c54d828a381c682725a43e322e660186b38cb

5 years agoMerge "Use wikimedia/object-factory 1.0.0"
jenkins-bot [Sun, 4 Feb 2018 21:05:19 +0000 (21:05 +0000)]
Merge "Use wikimedia/object-factory 1.0.0"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 4 Feb 2018 20:55:12 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie15458314b698c74878d2582acfde34b8e066b68

5 years agoUse wikimedia/object-factory 1.0.0
Kunal Mehta [Fri, 2 Feb 2018 10:27:27 +0000 (02:27 -0800)]
Use wikimedia/object-factory 1.0.0

Deprecate the unnamespaced version and move it to includes/compat.

Bug: T147167
Depends-On: I39c805bfb98b32f32f3d0dc1eee9e823afe1c21a
Change-Id: I3780c7adf51683f3f7adb35a88f9a25a0a2e2530

5 years agoFixing typos for ucfirst magic word translation into Ukrainian: ПЕША_ДІТЕРА → ПЕРША_Л...
Base [Sun, 4 Feb 2018 18:54:31 +0000 (18:54 +0000)]
Fixing typos for ucfirst magic word translation into Ukrainian: ПЕША_ДІТЕРА → ПЕРША_ЛІТЕРА.

Change-Id: I921945fd6a4121465844deece2a964e7d79f8117

5 years agoMerge "rdbms: turn LoadBalancer waitTimeout default into a class constant"
jenkins-bot [Sun, 4 Feb 2018 18:22:20 +0000 (18:22 +0000)]
Merge "rdbms: turn LoadBalancer waitTimeout default into a class constant"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 3 Feb 2018 20:54:11 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib0da9c11a473475633c26e418a3fb3a1eb901653

5 years agoMerge "mediawiki.api.edit: Remove dependency on 'mediawiki.Title'"
jenkins-bot [Sat, 3 Feb 2018 06:20:23 +0000 (06:20 +0000)]
Merge "mediawiki.api.edit: Remove dependency on 'mediawiki.Title'"

5 years agoMerge "EmailNotification: Hard deprecate updateWatchlistTimestamp()"
jenkins-bot [Sat, 3 Feb 2018 05:54:07 +0000 (05:54 +0000)]
Merge "EmailNotification: Hard deprecate updateWatchlistTimestamp()"

5 years agordbms: clean up and improve LoadBalancer logging calls
Aaron Schulz [Fri, 2 Feb 2018 18:00:42 +0000 (10:00 -0800)]
rdbms: clean up and improve LoadBalancer logging calls

Change-Id: I8a17ad36ccc770fbd101c4b280e8ad1b32837125

5 years agoEmailNotification: Hard deprecate updateWatchlistTimestamp()
James D. Forrester [Wed, 31 Jan 2018 22:33:18 +0000 (14:33 -0800)]
EmailNotification: Hard deprecate updateWatchlistTimestamp()

Soft-deprecated in 1.27.

Depends-On: Ie7073f2048ba2b79a8b36ad913453008ec3555ce
Change-Id: If1dd2f8211c808ab0e284d7a3fb0b24610a0b32d

5 years agordbms: turn LoadBalancer waitTimeout default into a class constant
Aaron Schulz [Sat, 3 Feb 2018 03:30:48 +0000 (19:30 -0800)]
rdbms: turn LoadBalancer waitTimeout default into a class constant

Change-Id: Icd1e1aba1c45cb79a8249a9e16dce16f1c8183d2

5 years agoMerge "Add Siberian Tatar (sty) language"
jenkins-bot [Sat, 3 Feb 2018 01:01:21 +0000 (01:01 +0000)]
Merge "Add Siberian Tatar (sty) language"

5 years agoMerge "skins: Deprecate MediaWikiI18N::translate()"
jenkins-bot [Sat, 3 Feb 2018 01:01:17 +0000 (01:01 +0000)]
Merge "skins: Deprecate MediaWikiI18N::translate()"

5 years agoAdd Siberian Tatar (sty) language
MarcoAurelio [Fri, 2 Feb 2018 22:34:17 +0000 (23:34 +0100)]
Add Siberian Tatar (sty) language

Bug: T186359
Change-Id: Iecfdda0bcfbcc491565b6de36046791a3e5c540a

5 years agoMerge "JavaScriptMinifier: Fix "Uninitialized offset" in regexp char class parsing"
jenkins-bot [Fri, 2 Feb 2018 23:54:27 +0000 (23:54 +0000)]
Merge "JavaScriptMinifier: Fix "Uninitialized offset" in regexp char class parsing"