lhc/web/wiklou.git
11 years agojquery.byteLimit: Partial rewrite to fix logic errors
Timo Tijhof [Sat, 23 Jun 2012 02:16:06 +0000 (04:16 +0200)]
jquery.byteLimit: Partial rewrite to fix logic errors

* Previously it was hooking into the keypress event, this meant
  that it had to do all sorts of calculation to figure out what
  the string length would be *after* the to-be-pressed key
  is allowed to be pressed. This sounds trivial, but is quite the
  contrary. First of all are control, alt, shift etc. those were
  covered.

  What wasn't covered and imho can't be realistically covered
  without bugs is: copy/paste, drag/drop, text selection and
  replacing or removing more at once. Or even a combination of the
  above. And then there is custom insert methods such as Narayam,
  where the character will not be literally inserted at all.

  Therefore I've changed it to instead listen to *after* the insert.
  and if necessary undo the last (one or more) characters until the
  byteLimit is satisfied. This works much more stable. Still very
  fast and not noticeable to the user.

  This also fixes the bug where when the limit is reached, you
  select all and type something else, you couldn't because it would
  prevent the keypress since the limit is reached.

* Updated documentation comments.

* Updated unit tests to simulate onkeyup instead of onkeypress.
 - hasLimit option in byteLimitTest() was redundant, using limit
   directly, instead of duplicating it twice.
 - Added more comments and better test names. Tests themselves
   have not changed.
 - Removed redundant tests at the bottom that no longer make sense
   in the new version (and were broken) since the property is
   now always unset instead of just if there is a callback.
   The native limit must not interfere.

Change-Id: I9ace3ab79f488d24ad13baace32118c151c06347

11 years ago(bug 36310) jquery.byteLimit should skip < 0 due to Firefox bug.
Timo Tijhof [Fri, 22 Jun 2012 20:16:18 +0000 (22:16 +0200)]
(bug 36310) jquery.byteLimit should skip < 0 due to Firefox bug.

* Firefox returns -1 if an element has no maxLength property set.
  (instead of undefined). This is especially problematic because
  roundtripping that value (e.g. setting elem.maxLength = -1;)
  causes a DOMException to be thrown.
  That exception is expected (and happens also in Chrome), but Chrome
  and other standard browsers don't return -1 for the getter, so it
  would never end up in the setter.

* Moved the check to before the property set/removal. Otherwise
  the exception would still be thrown. This should've been before
  anyway.

* This fixes:
  - (bug 36310) Can't enter a log summary on Special:MovePage
  in Firefox.

  Even though we do set maxLength for that field from PHP. Recently
  the input field was changed from <input> to <textarea>. And since
  English Wikipedia has wgHtml5 disabled and maxLength on <textarea>
  is new in HTML5, that property was stripped by the Html class, and
  the javascript incorrectly assumed  that the property would be there
  and thus caused the DOMException in Firefox.

* Added unit test for this (which fails in Firefox without this fix).

Change-Id: I28490b61bd5a20dd1d84c4730615514d3822aa77

11 years agoFix undefined property domain in AuthPlugin
Reedy [Thu, 21 Jun 2012 21:56:12 +0000 (22:56 +0100)]
Fix undefined property domain in AuthPlugin

[21-Jun-2012 20:35:17] PHP Notice:  Undefined property: AuthPlugin::$domain in /www/w/includes/AuthPlugin.php on line 92

Change-Id: I0c470b41881e0fd12d9615f7ac258feeff1a52e4

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Thu, 21 Jun 2012 20:22:17 +0000 (20:22 +0000)]
Localisation updates from translatewiki.net.

Change-Id: If2ab7747d22cfc38a065c16697eaf5ace09ad400

11 years ago[LockManager] Added a memcached lock manager class.
Aaron [Wed, 20 Jun 2012 21:09:22 +0000 (14:09 -0700)]
[LockManager] Added a memcached lock manager class.

Change-Id: Ie99a7f1335bb5cceb0cb1c33a40094b3a22101ea

11 years agoAlias mw.action.watch.ajax to mw.page.watch.ajax
Catrope [Thu, 21 Jun 2012 18:23:50 +0000 (11:23 -0700)]
Alias mw.action.watch.ajax to mw.page.watch.ajax

This module was recently renamed, and we'll need the alias for caching
reasons

Change-Id: Ic0df459dfc1cca58f4e01325375c20c46091c89b

11 years agoFollowup to 2e089a4e5: rename watch to watchpage
Catrope [Thu, 21 Jun 2012 17:45:15 +0000 (10:45 -0700)]
Followup to 2e089a4e5: rename watch to watchpage

There is a jQuery bug causing events named 'watch' to break in Firefox

Change-Id: Ie44066bcb6fd84ee77551efa1ca40f5543126d2c

11 years agoSimplifying domain getting/setting
Ryan Lane [Thu, 21 Jun 2012 12:59:01 +0000 (14:59 +0200)]
Simplifying domain getting/setting

Adding a function to AuthPlugin for getting the user's domain. This allows the extension to determine how the user's domain is get and set, rather than core.

Change-Id: Ib2414bd55dfde67f7caf6439680fa88d9266e991

11 years agoMerge "Bug 37705 - ucfirst for sidebar interlanguage links"
Siebrand [Thu, 21 Jun 2012 12:22:20 +0000 (12:22 +0000)]
Merge "Bug 37705 - ucfirst for sidebar interlanguage links"

11 years agoBug 37705 - ucfirst for sidebar interlanguage links
robin [Mon, 18 Jun 2012 21:23:59 +0000 (23:23 +0200)]
Bug 37705 - ucfirst for sidebar interlanguage links

Change-Id: I623cf070fdc62c9394a06d4830dc4faccfebcfbe

11 years agoMerge "[LockManager] Factored QuorumLockManager class out of LSLockManager."
Hashar [Wed, 20 Jun 2012 20:38:37 +0000 (20:38 +0000)]
Merge "[LockManager] Factored QuorumLockManager class out of LSLockManager."

11 years agoMerge "qLocalisation updates from http://translatewiki.net."
Translation updater bot [Wed, 20 Jun 2012 20:18:38 +0000 (20:18 +0000)]
Merge "qLocalisation updates from translatewiki.net."

11 years agoqLocalisation updates from http://translatewiki.net.
Translation updater bot [Wed, 20 Jun 2012 20:16:43 +0000 (20:16 +0000)]
qLocalisation updates from translatewiki.net.

Change-Id: Icffbf1ead617dee16b8a720427c8f0cd65168ab3

11 years agoMerge "Move action.watch to a more suitable place and expose updateWatchLink method...
Trevor Parscal [Wed, 20 Jun 2012 20:06:12 +0000 (20:06 +0000)]
Merge "Move action.watch to a more suitable place and expose updateWatchLink method in mw.page.watch.  Update method to toggle watch, unwatch list item id attribute. Patchset 2- Expose method with less code duplication, restore comments, cleanup whitespace. Patchset 3-5 Whitespace cleanup Patchset 6 - Trigger a watch event on the updated li Patchset 7 - Only trigger watch event if not updating state, announce opposite of icon action, to properly indicate action taken. Patchset 8 - Cleanup spacing and comments issues, change event namespace. Patchset 9 - actually add the change Change-Id: I591f9f847db391c5d1477dc2ed41de54ec266261"

11 years agoMove action.watch to a more suitable place and expose updateWatchLink
Rob Moen [Tue, 19 Jun 2012 23:00:57 +0000 (16:00 -0700)]
Move action.watch to a more suitable place and expose updateWatchLink
method in mw.page.watch.  Update method to toggle watch, unwatch
list item id attribute.
Patchset 2- Expose method with less code duplication, restore
comments, cleanup whitespace.
Patchset 3-5 Whitespace cleanup
Patchset 6 - Trigger a watch event on the updated li
Patchset 7 - Only trigger watch event if not updating
state, announce opposite of icon action, to properly
indicate action taken.
Patchset 8 - Cleanup spacing and comments issues,
change event namespace.
Patchset 9 - actually add the change
Change-Id: I591f9f847db391c5d1477dc2ed41de54ec266261

11 years agoMerge "Removed half-assed $wgDBtransactions global."
Hashar [Wed, 20 Jun 2012 18:12:13 +0000 (18:12 +0000)]
Merge "Removed half-assed $wgDBtransactions global."

11 years agoRemoved half-assed $wgDBtransactions global.
Aaron [Tue, 19 Jun 2012 22:01:38 +0000 (15:01 -0700)]
Removed half-assed $wgDBtransactions global.

Change-Id: I5211ec50622b0a40bf4756b7fe735dc669f928e7

11 years agoMerge "PHP test suite for CSSMin"
Hashar [Wed, 20 Jun 2012 12:28:59 +0000 (12:28 +0000)]
Merge "PHP test suite for CSSMin"

11 years agoPHP test suite for CSSMin
Timo Tijhof [Wed, 20 Jun 2012 03:13:52 +0000 (05:13 +0200)]
PHP test suite for CSSMin

Change-Id: Ic9195614acfd616ccdff57cfc666aa4dfa71fb96

11 years agoMerge "(bug 37458) permission errors running BaseDumpTest on Windows"
Hashar [Wed, 20 Jun 2012 09:16:16 +0000 (09:16 +0000)]
Merge "(bug 37458) permission errors running BaseDumpTest on Windows"

11 years ago(bug 37458) permission errors running BaseDumpTest on Windows
Tobias Gritschacher [Mon, 18 Jun 2012 13:11:04 +0000 (15:11 +0200)]
(bug 37458) permission errors running BaseDumpTest on Windows

Change-Id: I58264c5f516f8dcb124d753b43a80b0875b0e974

11 years agoMerge "(bug 35727) mw.Api ajax() should put token parameter last."
Krinkle [Tue, 19 Jun 2012 22:47:53 +0000 (22:47 +0000)]
Merge "(bug 35727) mw.Api ajax() should put token parameter last."

11 years agoMerge "(bug 37301) add sizediff to list=usercontribs"
Aaron Schulz [Tue, 19 Jun 2012 21:31:19 +0000 (21:31 +0000)]
Merge "(bug 37301) add sizediff to list=usercontribs"

11 years agoMerge "Can't use return value of void functions"
Aaron Schulz [Tue, 19 Jun 2012 21:10:12 +0000 (21:10 +0000)]
Merge "Can't use return value of void functions"

11 years agoMerge "Bump release notes to say jQuery UI 1.8.21 (seems I forgot to do this in the...
Aaron Schulz [Tue, 19 Jun 2012 21:09:04 +0000 (21:09 +0000)]
Merge "Bump release notes to say jQuery UI 1.8.21 (seems I forgot to do this in the commits...)"

11 years agoMerge "Kill RELEASE-NOTES-1.19 from core. Not needed anymore"
Aaron Schulz [Tue, 19 Jun 2012 21:06:27 +0000 (21:06 +0000)]
Merge "Kill RELEASE-NOTES-1.19 from core. Not needed anymore"

11 years ago(bug 35727) mw.Api ajax() should put token parameter last.
Brad Jorsch [Sun, 17 Jun 2012 04:11:32 +0000 (00:11 -0400)]
(bug 35727) mw.Api ajax() should put token parameter last.

Patch from Russell Blau.

As recommended in [[mw:API:Edit#Token]], the "token" parameter in
a request should always be passed at the end of the query string.
This is a safety measure in case transmission of the HTML request to
the server is interrupted; then the server will not process the
incomplete request because there will be no (complete) token.
(Conversely, if the "text=" parameter were last, the server would have
no way of knowing whether the complete text had been received.)
Presumably the same thing is necessary for action=email, since the
request may include text of arbitrary length.

Change-Id: Id267dd628eb93eb06191c55eb386b1893f499554

11 years ago[LockManager] Factored QuorumLockManager class out of LSLockManager.
Aaron [Tue, 19 Jun 2012 18:39:53 +0000 (11:39 -0700)]
[LockManager] Factored QuorumLockManager class out of LSLockManager.

Change-Id: I4031085faef4a1a7ce49dbeeb0b3ddf94d41132c

11 years agoMerge "Localisation updates from http://translatewiki.net."
Translation updater bot [Tue, 19 Jun 2012 19:38:03 +0000 (19:38 +0000)]
Merge "Localisation updates from translatewiki.net."

11 years agoMerge "Put skin classes in the Autoloader"
Aaron Schulz [Tue, 19 Jun 2012 19:33:53 +0000 (19:33 +0000)]
Merge "Put skin classes in the Autoloader"

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Tue, 19 Jun 2012 19:05:12 +0000 (19:05 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ic387b6f35cf3fb1931bb3d8c52efee17b91cf1be

11 years agoFix comments added in change 10088
Liangent [Tue, 5 Jun 2012 23:30:49 +0000 (07:30 +0800)]
Fix comments added in change 10088

I found my comments in change 10088 is inadequate because we don't
have any known squid URLs in Title::getSquidURLs() and we may never
want to have... There's no hook there so extensions are unable to
add any squid URLs for them (maybe we want one someday? but new
extensions shouldn't be using the UnknownAction hook).

Change-Id: I44ba376f92776ec6bb32f91beb06f11ebd086fb4

11 years agoMerge "For consistency of the interface, don't do expensive checks on page view."
Aaron Schulz [Tue, 19 Jun 2012 06:53:07 +0000 (06:53 +0000)]
Merge "For consistency of the interface, don't do expensive checks on page view."

11 years agoSkinTemplate: Minor clean up
Timo Tijhof [Mon, 18 Jun 2012 23:26:40 +0000 (01:26 +0200)]
SkinTemplate: Minor clean up

* Better variable names ($wgContLang is object, $userLang was a string
  and $lang the object. Made $userLang the object and $userLangCode
  the string.

* Removed trailing whitespace.

* Spacing (not all just where it fit better in the context, some
  isset($) to isset( $ ). and a few `if()` to `if ()` since most
  in this file are like that.

* Some redundant magic quote usage to single quotes.

* Weird structure in getPersonalTools():
  Instead of accessing the same deep array property over and over
  again to add something to the newly create array (e.g.
  $foo[] = array(); and then $foo[0] = $bar;) simply creating it
  as a literal at once.

Change-Id: I861ae1d558f324f61c79089dcd3bff52dd27e0aa

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Mon, 18 Jun 2012 19:06:51 +0000 (19:06 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ica921689fbb2051272010d77198e5932421fa9e9

11 years agoMerge "ensure unique revision id in backupTextPassTest"
Aaron Schulz [Mon, 18 Jun 2012 17:05:21 +0000 (17:05 +0000)]
Merge "ensure unique revision id in backupTextPassTest"

11 years agoKill RELEASE-NOTES-1.19 from core. Not needed anymore
Reedy [Mon, 18 Jun 2012 00:36:51 +0000 (01:36 +0100)]
Kill RELEASE-NOTES-1.19 from core. Not needed anymore

Change-Id: I41df1c6201a3ad22e2d1824102eecc02be719657

11 years agoBump release notes to say jQuery UI 1.8.21 (seems I forgot to do this in the commits...)
Reedy [Mon, 18 Jun 2012 00:35:19 +0000 (01:35 +0100)]
Bump release notes to say jQuery UI 1.8.21 (seems I forgot to do this in the commits...)

Change-Id: Ic1c285582b9c92a8510ac67cf26f5787ec3bb59b

11 years agoMerge "Update and minor clean up of release-notes"
Timo Tijhof [Sun, 17 Jun 2012 23:45:04 +0000 (23:45 +0000)]
Merge "Update and minor clean up of release-notes"

11 years agoMerge "Remove duplication of Langauge digitTransformTable in javascript."
Krinkle [Sun, 17 Jun 2012 22:09:55 +0000 (22:09 +0000)]
Merge "Remove duplication of Langauge digitTransformTable in javascript."

11 years agoRemove duplication of Langauge digitTransformTable in javascript.
Santhosh Thottingal [Wed, 6 Jun 2012 06:12:12 +0000 (11:42 +0530)]
Remove duplication of Langauge digitTransformTable in javascript.

Use the new ResourceLoaderLanguageDataModule for passing the digit
transform table and digit separators (comma or dot) from the PHP
classes. And remove the duplicative javascript files so we no longer
have to maintain changes to MessagesXYZ.php and languages/xyz.js.

Change-Id: Icf63ebf927f993fe04518c4afe3a0b6959f5b1bd

11 years agoUpdate and minor clean up of release-notes
Timo Tijhof [Sun, 17 Jun 2012 21:47:24 +0000 (23:47 +0200)]
Update and minor clean up of release-notes

* also for 5b5cdec7e56dd12a45f915766cdc9eaf62174cd6.
  (QUnit update to v1.8.0).

  We've updated QUnit about 5 times to upstream release
  during 1.20 development, when is our release coming :)

Change-Id: Iac101f29669f13b0d8a6865f7f1849062eae7537

11 years agoMerge "Update jquery.qunit from upstream v1.7.0 to v1.8.0"
Timo Tijhof [Sun, 17 Jun 2012 21:43:42 +0000 (21:43 +0000)]
Merge "Update jquery.qunit from upstream v1.7.0 to v1.8.0"

11 years agoUpdate jquery.qunit from upstream v1.7.0 to v1.8.0
Timo Tijhof [Sun, 17 Jun 2012 20:44:57 +0000 (22:44 +0200)]
Update jquery.qunit from upstream v1.7.0 to v1.8.0

* Upstream https://github.com/jquery/qunit.git
 - tag: v1.8.0
 - tree: https://github.com/jquery/qunit/tree/v1.8.0
 - commit: https://github.com/jquery/qunit/commit/8a7fc96381b14792ff1c380ffa6682396658a4c2

* Misc:
 - Updated existing release-note entry for QUnit update
 - This release introduces the query parameter "module=", which,
   contrary to "filter=" reduces the tests to be run to only tests
   within the module by that exact name ("filter" does a string search
   so filter=foo also matched "module: bar, test: does bafoola quux?".

   We should update our TestSwarm configuration to use this parameter
   instead.

Change-Id: Iee3f40ca5d50694038e759268c07c2694c98bbc6

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Sun, 17 Jun 2012 19:44:01 +0000 (19:44 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I5a2edc647e05551a87cc76a1b397030eb6c42b16

11 years agoMerge "Update and fix AutoLoader definitions."
Aaron Schulz [Sun, 17 Jun 2012 18:16:25 +0000 (18:16 +0000)]
Merge "Update and fix AutoLoader definitions."

11 years agoMerge "Improve documentation of maintenance scripts."
Aaron Schulz [Sun, 17 Jun 2012 18:14:35 +0000 (18:14 +0000)]
Merge "Improve documentation of maintenance scripts."

11 years agoMerge "Wrap auto-numbering for section heading in a classed span (bug 33450)"
GWicke [Sun, 17 Jun 2012 16:39:27 +0000 (16:39 +0000)]
Merge "Wrap auto-numbering for section heading in a classed span (bug 33450)"

11 years agoMerge "(bug 21660) "Pipe trick" full width commas (with test!)"
GWicke [Sun, 17 Jun 2012 12:26:45 +0000 (12:26 +0000)]
Merge "(bug 21660) "Pipe trick" full width commas (with test!)"

11 years agoImprove documentation of maintenance scripts.
Alexandre Emsenhuber [Sat, 16 Jun 2012 20:35:13 +0000 (22:35 +0200)]
Improve documentation of maintenance scripts.

Change-Id: I328a3d42a09f2b082ebc153c2f399793e23942d7

11 years agoUpdate and fix AutoLoader definitions.
Alexandre Emsenhuber [Sat, 16 Jun 2012 20:32:56 +0000 (22:32 +0200)]
Update and fix AutoLoader definitions.

All these changes were found by running maintenance/checkAutoLoader.php.

Change-Id: Iffef080c8b0156af1fc6d4651c07e0e31e9c1674

11 years agoMerge "Double the size of the target input field of Special:Contributions"
Aaron Schulz [Sat, 16 Jun 2012 18:04:43 +0000 (18:04 +0000)]
Merge "Double the size of the target input field of Special:Contributions"

11 years agoCan't use return value of void functions
Reedy [Sat, 16 Jun 2012 13:42:30 +0000 (14:42 +0100)]
Can't use return value of void functions

Change-Id: Idce6e31f3f0eff0a0045c1cc62def3f5d79b9d48

11 years ago(bug 37301) add sizediff to list=usercontribs
umherirrender [Sat, 16 Jun 2012 07:47:11 +0000 (09:47 +0200)]
(bug 37301) add sizediff to list=usercontribs

Moving function getParentLength from SpecialContributions to Revision
and use it in the list module. The size of the parent is selected by a
batch, like the special page.

Change-Id: I6e388e75cd765f2a918b0c192477d87347e96bcd

11 years agoensure unique revision id in backupTextPassTest
umherirrender [Sat, 16 Jun 2012 07:09:27 +0000 (09:09 +0200)]
ensure unique revision id in backupTextPassTest

Idb82fe620c3395acaa8f051b4d4d0d770cd33d44 adds a unique contraints on
the revision id to export.xsd, which does not apply here
creating unique contraints in the same way than the pageids by adding an
offset

Change-Id: Ia19f1011a5c0ba8d21cc01a9be2e4d2ed300a80a

11 years agoMerge "(bug 33222) Add parentid to revision in export xml"
Aaron Schulz [Sat, 16 Jun 2012 04:25:52 +0000 (04:25 +0000)]
Merge "(bug 33222) Add parentid to revision in export xml"

11 years agoMerge "Revert "Deprecate no longer used Skin::getCommonStylePath.""
Krinkle [Sat, 16 Jun 2012 04:06:05 +0000 (04:06 +0000)]
Merge "Revert "Deprecate no longer used Skin::getCommonStylePath.""

11 years agoRevert "Deprecate no longer used Skin::getCommonStylePath."
Krinkle [Sat, 16 Jun 2012 04:03:40 +0000 (04:03 +0000)]
Revert "Deprecate no longer used Skin::getCommonStylePath."

This reverts commit 79dcf7686d857e1dcbc3f1127a106d847de10d9e

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Fri, 15 Jun 2012 21:40:23 +0000 (21:40 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I19b9e057f8ed555178480d04b12aa17c87bc97b3

11 years agoMerge "[FileBackend] Process cache fixes and cleanups."
Hashar [Fri, 15 Jun 2012 21:09:34 +0000 (21:09 +0000)]
Merge "[FileBackend] Process cache fixes and cleanups."

11 years agoMerge "Revert "Deprecate no longer used Skin::getCommonStylePath.""
Aaron Schulz [Fri, 15 Jun 2012 21:03:48 +0000 (21:03 +0000)]
Merge "Revert "Deprecate no longer used Skin::getCommonStylePath.""

11 years agoMerge "Fixes to LogEventsList."
Aaron Schulz [Fri, 15 Jun 2012 20:52:42 +0000 (20:52 +0000)]
Merge "Fixes to LogEventsList."

11 years agoUse canonical class name ApiBase also in ApiQueryLangLinks
Platonides [Fri, 15 Jun 2012 20:46:56 +0000 (22:46 +0200)]
Use canonical class name ApiBase also in ApiQueryLangLinks

Change-Id: I11c7b0540078e6934c8d9d8fa21891a87bfebd21

11 years agoUse canonical class name for ApiBase
Platonides [Fri, 15 Jun 2012 20:41:01 +0000 (22:41 +0200)]
Use canonical class name for ApiBase
 s/Apibase::PROP_NULLABLE/ApiBase::PROP_NULLABLE/

Change-Id: I222df124f947face5970bab810f497c43000dbf2

11 years agoFixes to LogEventsList.
Alexandre Emsenhuber [Fri, 15 Jun 2012 20:04:44 +0000 (22:04 +0200)]
Fixes to LogEventsList.

* Removed useless variables
* Use Linker::linkKnown() instead of Linker::link() where possible

Change-Id: I7cb668ef929cee159946a46cbcb07464a0913f81

11 years agoMerge "Added ORMIterator interface which can be used for type hinting (in particular...
Aaron Schulz [Fri, 15 Jun 2012 19:09:51 +0000 (19:09 +0000)]
Merge "Added ORMIterator interface which can be used for type hinting (in particular when passing ORMResult objects)"

11 years agoMerge "Fixup some wrong documentation"
Nikerabbit [Fri, 15 Jun 2012 18:24:31 +0000 (18:24 +0000)]
Merge "Fixup some wrong documentation"

11 years agoFixup some wrong documentation
Reedy [Fri, 15 Jun 2012 14:05:49 +0000 (15:05 +0100)]
Fixup some wrong documentation

Don't try and return the result of void functions

Change-Id: I7a4db738b3e3052aebcf43742d31753f8cc1f47a

11 years agoMinor additions to documentation stuff
Reedy [Fri, 15 Jun 2012 13:56:15 +0000 (14:56 +0100)]
Minor additions to documentation stuff

Change-Id: I79417ce790c22a3f6ad1d24153da898901d1142f

11 years agoMerge "(bug 34933) Create "Check: [All] [None]" buttons with JavaScript"
Siebrand [Fri, 15 Jun 2012 13:12:55 +0000 (13:12 +0000)]
Merge "(bug 34933) Create "Check: [All] [None]" buttons with JavaScript"

11 years agoMerge "(bug 15853) Wrong entries in history feed"
Siebrand [Fri, 15 Jun 2012 13:02:02 +0000 (13:02 +0000)]
Merge "(bug 15853) Wrong entries in history feed"

11 years agoMerge "Added some extra tests for ORMRow class"
Siebrand [Fri, 15 Jun 2012 12:59:34 +0000 (12:59 +0000)]
Merge "Added some extra tests for ORMRow class"

11 years agoMerge "Do proper conversion table detection."
Siebrand [Fri, 15 Jun 2012 12:53:12 +0000 (12:53 +0000)]
Merge "Do proper conversion table detection."

11 years agoMerge "(bug 37452) Added class="mw-redirect" to redirect links in Special:PrefixIndex"
Siebrand [Fri, 15 Jun 2012 12:51:47 +0000 (12:51 +0000)]
Merge "(bug 37452) Added class="mw-redirect" to redirect links in Special:PrefixIndex"

11 years agoAdded a hook for formatting autocomments
jeblad [Fri, 15 Jun 2012 09:40:40 +0000 (11:40 +0200)]
Added a hook for formatting autocomments

Removed some spurious whitespace

Changed how wfRunHooks are used, and also the test for default formatting

Change-Id: I4c3fc1080f83166d7b89aeb9a1487e173e9ccb65

11 years agoPut skin classes in the Autoloader
Catrope [Fri, 15 Jun 2012 01:41:33 +0000 (18:41 -0700)]
Put skin classes in the Autoloader

Also remove require_once() calls from skin files.

This fixes a bug introduced in 0ec77e2b31 where MySkin would throw a
fatal error because it couldn't find the MonoBookTemplate class.

Change-Id: I63bbe1d25e8cb70ee4baf99ec6e685444b663c1f

11 years agoRevert "Deprecate no longer used Skin::getCommonStylePath."
Daniel Friesen [Fri, 15 Jun 2012 01:08:29 +0000 (18:08 -0700)]
Revert "Deprecate no longer used Skin::getCommonStylePath."

This reverts commit 79dcf7686d857e1dcbc3f1127a106d847de10d9e.

getCommonStylePath and getSkinStylePath are a pair of methods for use in 3rd party skins (NOT core).
They cut down on the boilerplate for including skin urls into skins for things like <img> tags.
Without these methods skin authors will be forced to revert to unintuitive boilerplate to add style paths and style versions into their code.
Most won't even bother to include the style version.
And ResourceLoader is a tangent to the whole topic because no matter what the advantages to CSS are developers writing custom skins for a single site from scratch will not care and they will choose CSS or <img> based on situations on hand in their own markup that make one or the other harder to handle.
This addition was part of the effort to fix the longstanding issue that our our skin system does not properly account for 3rd party skin developers.

Change-Id: I98f4fd83c93aba7681306d0a1edb58f798057543

11 years agoMerge "Check validity of fetched titles and show a descriptive messages when an inval...
Aaron Schulz [Thu, 14 Jun 2012 23:42:56 +0000 (23:42 +0000)]
Merge "Check validity of fetched titles and show a descriptive messages when an invalid title is encountered."

11 years agoMerge "Deprecate no longer used Skin::getCommonStylePath."
Timo Tijhof [Thu, 14 Jun 2012 22:36:42 +0000 (22:36 +0000)]
Merge "Deprecate no longer used Skin::getCommonStylePath."

11 years agoMerge "(bug 27283) SqlBagOStuff breaks PostgreSQL txns"
Demon [Thu, 14 Jun 2012 21:45:31 +0000 (21:45 +0000)]
Merge "(bug 27283) SqlBagOStuff breaks PostgreSQL txns"

11 years ago(bug 27283) SqlBagOStuff breaks PostgreSQL txns
saper [Fri, 30 Mar 2012 00:10:52 +0000 (02:10 +0200)]
(bug 27283) SqlBagOStuff breaks PostgreSQL txns

* SqlBagOStuff should not turn off automatic transaction
    control just like that. Keep previous
    connection for PostgreSQL and SQLite

94633ff448e9253c5503124df6748be1fc26b8e2 introduced
    rollback on error to restore sanity
    for the connection. Don't do this
    if you are in the middle of INSERT IGNORE
    and we have a savepoint open.

    Making sure query syntax errors don't
    get silenced by our "wonderful" implementation
    of INSERT IGNORE is bug 35572.

Change-Id: I841b03895e1189c47307fefb1516c4c7c4102e25

11 years agoMerge "avoid Title::exist/getArticleId in ApiQueryInfo::extractPageInfo"
Aaron Schulz [Thu, 14 Jun 2012 19:56:02 +0000 (19:56 +0000)]
Merge "avoid Title::exist/getArticleId in ApiQueryInfo::extractPageInfo"

11 years agoMerge "fix backup unit tests"
Aaron Schulz [Thu, 14 Jun 2012 19:32:43 +0000 (19:32 +0000)]
Merge "fix backup unit tests"

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Thu, 14 Jun 2012 18:21:49 +0000 (18:21 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I1c650dacc81e725610740e6ec773bbcbd8bcbec8

11 years agoAllowing the change password form to be extended
Ryan Lane [Wed, 13 Jun 2012 16:34:32 +0000 (18:34 +0200)]
Allowing the change password form to be extended

Change-Id: Id676b1ec4b43140790b18a87bc8466f10c957577

11 years agoMerge "Correct case for the "MediaWiki:Revdelete-reason-dropdown" link in Special...
Siebrand [Thu, 14 Jun 2012 13:18:19 +0000 (13:18 +0000)]
Merge "Correct case for the "MediaWiki:Revdelete-reason-dropdown" link in Special:RevisionDelete."

11 years agoMerge "Use local context to get messages"
Siebrand [Thu, 14 Jun 2012 13:17:44 +0000 (13:17 +0000)]
Merge "Use local context to get messages"

11 years agoMerge "Use local context instead of hidden dependencies on global variables."
Siebrand [Thu, 14 Jun 2012 13:15:17 +0000 (13:15 +0000)]
Merge "Use local context instead of hidden dependencies on global variables."

11 years agoAdded missing GPLv2 headers in some places.
Alexandre Emsenhuber [Thu, 14 Jun 2012 12:25:13 +0000 (14:25 +0200)]
Added missing GPLv2 headers in some places.

Also made file/class documentation more consistent.

Change-Id: I8ee0861bfc2e9ff6511ad61175f1f1273739816c

11 years agoUse message 'brackets' for brackets
Liangent [Fri, 8 Jun 2012 14:11:07 +0000 (22:11 +0800)]
Use message 'brackets' for brackets

Change-Id: I92419cb6d86e313b611b1f7132a278f7f8f97d5f

11 years agolint mediawiki.Uri.js
Timo Tijhof [Thu, 7 Jun 2012 16:13:19 +0000 (18:13 +0200)]
lint mediawiki.Uri.js

* remove dangling _
* var hosting
* whitespace conventions

Change-Id: I7c78059f640dfdf52020018425026cb714bcdbfa

11 years agoMerge "Fixed pecl memcached client in persistent mode."
Tim Starling [Thu, 14 Jun 2012 02:10:33 +0000 (02:10 +0000)]
Merge "Fixed pecl memcached client in persistent mode."

11 years agoFixed pecl memcached client in persistent mode.
Aaron [Thu, 14 Jun 2012 01:08:38 +0000 (18:08 -0700)]
Fixed pecl memcached client in persistent mode.

* When using a persistend ID in the constructor, the object is effectively shared among
  the callers using that ID. If we always use __CLASS__, then this breaks when different
  BagOStuffs may be used. Instead, a hash of the settings is now used.
  See http://www.php.net/manual/en/memcached.construct.php.
* Don't keep adding servers to the pool, as the object is shared among callers. Once one thread
  initializes the object, it will already be initialized by the next thread. Calling addSever()
  again will cause an increasing number of duplicate servers to exist in the data structure, and
  thus an increasing number of socket connections over time.
* Also, use addServers() instead of multiple addServer() calls per
  http://www.php.net/manual/en/memcached.addserver.php.

Change-Id: I0e7510320cb79d9f152e8958ddd50400fa9da37f

11 years agoFix for 15e5193a19, broke in debug mode
Catrope [Thu, 14 Jun 2012 00:46:39 +0000 (17:46 -0700)]
Fix for 15e5193a19, broke in debug mode

We shouldn't be combining styles in debug mode anyways.

Change-Id: I8f0503e665df870e0940314e10185b94624869b9

11 years agoFix media type handling for CSS that's not loaded with only=styles
Catrope [Wed, 13 Jun 2012 23:50:13 +0000 (16:50 -0700)]
Fix media type handling for CSS that's not loaded with only=styles

We were only doing server-side @media wrapping in only=styles mode but
not in regular mode. Meanwhile, the client-side loader had dropped all
support for media types under the assumption that this was all handled
server side, which caused media type handling to break for modules
loaded the normal way. We didn't notice this before because the only
core module that uses this is skins.vector, which is loaded through
only=styles.

Change-Id: I8228cc0317328440256b45b166eef1b57dbf4602

11 years agoMerge "Localisation updates from http://translatewiki.net."
Translation updater bot [Wed, 13 Jun 2012 21:04:41 +0000 (21:04 +0000)]
Merge "Localisation updates from translatewiki.net."

11 years agoAllow cleanupSpam.php optionally delete offending pages
Max Semenik [Mon, 14 May 2012 19:24:31 +0000 (23:24 +0400)]
Allow cleanupSpam.php optionally delete offending pages

Change-Id: I69387df1b3d404a6d00d8073e58d7556c7ab9298

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Wed, 13 Jun 2012 19:41:29 +0000 (19:41 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I66636cc9e42eb82cdf12b4974a48ba9264fae4c2

11 years agoBug 24985 use $wgTmpDirectory when available
Mark A. Hershberger [Sat, 26 May 2012 03:19:55 +0000 (23:19 -0400)]
Bug 24985 use $wgTmpDirectory when available

We had two way to get a temporary directory:

 - $wgTempDirectory: more or less stable accross sessions
 - wfTempDir(): set through environnement variable and could potentially
   vary from a session to another one thanks to tempnam()

This patch makes wfTempDir() to always use the global $wgTempDirectory
first when it is available. Thus explicitly overriding tempnam() or any
environnement variable such as TMP or TEMP.

Hence, people who don't have access to a system wide directory
specificed by their environnement (such as /tmp) can specify an
alternative straight from the MediaWiki configuration.

The patch remove references to $wgTmpDirectory and replace them with
calls to wfTempDir().  Make wfTempDir() use $wgTmpDirectory first.

The default setting of $wgTmpDirectory was removed in favor of having it
initialized through Setup.php by calling wfTempDir.

Note: this may also address Bug 36475 - Generating thumbnails does not
work when there is no access to /tmp

Change-Id: Ifdc79e9c5d95f978025b237a5eeb95fd75092f46

11 years agoMerge "(bug 37090) Remove Spanish gender aliases."
Siebrand Mazeland [Wed, 13 Jun 2012 18:12:22 +0000 (18:12 +0000)]
Merge "(bug 37090) Remove Spanish gender aliases."