6 years agoMerge "mediawiki.widgets: Remove use of bind() for lexical 'this' binding"
jenkins-bot [Fri, 25 Mar 2016 13:55:42 +0000 (13:55 +0000)]
Merge "mediawiki.widgets: Remove use of bind() for lexical 'this' binding"

6 years agomediawiki.widgets: Remove use of bind() for lexical 'this' binding
Timo Tijhof [Fri, 25 Mar 2016 00:35:39 +0000 (00:35 +0000)]
mediawiki.widgets: Remove use of bind() for lexical 'this' binding

Follows-up 4636ac79dd.

Bind can be useful when needing to pass an instance method elewhere.

However when nesting closures, use the scope directly instead of binding 'this'
several layers deep. This is fragile at best and doesn't make it less confusing.

Leave the natural 'this' unchanged. Change this can go wrong both ways and
results in unpredictable behaviour and confusing code that is hard to review.
Sometimes one means the outer 'this' but gets the inner one, and sometimes you
need the inner one (e.g. inside callbacks for jQuery). Consistently assign a
variable and use scope to access objects. Besides, one can't escape it when you
need both.

This avoids an entire class of potential errors. It also performs marginally
better without a binding but that's besides the point as there are other valid
uses of bind().

Change-Id: I1fcfdbd8fa7c52e150cadd8a520591e700c5bfa9

6 years agoMerge "Allow titles with falsy title text in suggestions"
jenkins-bot [Fri, 25 Mar 2016 11:01:08 +0000 (11:01 +0000)]
Merge "Allow titles with falsy title text in suggestions"

6 years agoMerge "Use WIS:addWatchBatchForUser in SpecialEditWatchlist"
jenkins-bot [Fri, 25 Mar 2016 10:47:50 +0000 (10:47 +0000)]
Merge "Use WIS:addWatchBatchForUser in SpecialEditWatchlist"

6 years agoMerge "Switch Signature of WatchedItemStore::addWatchBatch"
jenkins-bot [Fri, 25 Mar 2016 10:37:43 +0000 (10:37 +0000)]
Merge "Switch Signature of WatchedItemStore::addWatchBatch"

6 years agoMerge "Avoid master queries on deletion form view"
jenkins-bot [Fri, 25 Mar 2016 10:37:00 +0000 (10:37 +0000)]
Merge "Avoid master queries on deletion form view"

6 years agomedia: Misc code clean up in DjVu.php
Timo Tijhof [Fri, 25 Mar 2016 00:18:09 +0000 (00:18 +0000)]
media: Misc code clean up in DjVu.php

* Use $cache->makeKey() instead of global.
* Access constants via $cache.
* Remove obsolete 'that = this' PHP 5.3 workaround.

Change-Id: I75505d3e3017fde185e43815d4e7acaba3fee69c

6 years agoAllow titles with falsy title text in suggestions
Erik Bernhardson [Thu, 24 Mar 2016 23:35:54 +0000 (16:35 -0700)]
Allow titles with falsy title text in suggestions

A valid title, such as 0, would end up being ignored in this clause and
not providing a title. Make the empty string check stricter to allow
these titles through.

Change-Id: I938a7dfe294e979c19f720eadb6f96282b1c4588

6 years agoMerge "Set doesWrites() for Special:Undelete"
jenkins-bot [Thu, 24 Mar 2016 21:55:22 +0000 (21:55 +0000)]
Merge "Set doesWrites() for Special:Undelete"

6 years agoSet doesWrites() for Special:Undelete
Aaron Schulz [Thu, 24 Mar 2016 21:18:27 +0000 (14:18 -0700)]
Set doesWrites() for Special:Undelete

Change-Id: Ie9044c9a57cb354a412ab515208b71ce44e52185

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 24 Mar 2016 21:09:30 +0000 (22:09 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I31cbae4f585f73a2a0ab97909206185a0d1c0aef

6 years agoAvoid master queries on deletion form view
Aaron Schulz [Thu, 24 Mar 2016 20:53:55 +0000 (13:53 -0700)]
Avoid master queries on deletion form view

Bug: T92357
Change-Id: I9c785e8e541f0e4fb7fa0f11cab2d33c26f7fb3a

6 years agoMerge "Define 'zh-hans' and 'zh-hant' localisations for Moment.js"
jenkins-bot [Thu, 24 Mar 2016 20:49:15 +0000 (20:49 +0000)]
Merge "Define 'zh-hans' and 'zh-hant' localisations for Moment.js"

6 years agoMerge "Set $wgIncludeLegacyJavaScript false by default"
jenkins-bot [Thu, 24 Mar 2016 20:38:27 +0000 (20:38 +0000)]
Merge "Set $wgIncludeLegacyJavaScript false by default"

6 years agoMerge "Throw an exception when the $key argument to hash_hmac is not a string"
jenkins-bot [Thu, 24 Mar 2016 20:31:01 +0000 (20:31 +0000)]
Merge "Throw an exception when the $key argument to hash_hmac is not a string"

6 years agoMerge "parserTest: Remove mention of non-existent 'noxml' option"
jenkins-bot [Thu, 24 Mar 2016 19:59:56 +0000 (19:59 +0000)]
Merge "parserTest: Remove mention of non-existent 'noxml' option"

6 years agoDefine 'zh-hans' and 'zh-hant' localisations for Moment.js
Gary Guo [Thu, 24 Mar 2016 18:45:46 +0000 (18:45 +0000)]
Define 'zh-hans' and 'zh-hant' localisations for Moment.js

Bug: T123080
Change-Id: I38ac5f1669364f7512be8c63ee51ce1449f6db26

6 years agoThrow an exception when the $key argument to hash_hmac is not a string
Gergő Tisza [Thu, 24 Mar 2016 18:22:45 +0000 (19:22 +0100)]
Throw an exception when the $key argument to hash_hmac is not a string

HHVM throws a fatal error when $key is not a string (unlike $data which
is typecast), so we might as well as throw an exception so that
at least we have a stack trace.

Bug: T126316
Change-Id: Iad9a499b51647c7dbcd58e9ab7ac8e8cb6359bba

6 years agomw.widgets.TitleWidget.js: Share interwikiPrefixes between multiple instances
Fomafix [Wed, 27 Jan 2016 15:31:07 +0000 (15:31 +0000)]
mw.widgets.TitleWidget.js: Share interwikiPrefixes between multiple instances

The interwikiPrefixes are static and do not need to load separately for every instance.

Bug: T124899
Change-Id: I316bdcc67ba176d22a70cd30fc3eb72bfe0be509

6 years agoSet $wgIncludeLegacyJavaScript false by default
James D. Forrester [Wed, 16 Mar 2016 10:53:33 +0000 (10:53 +0000)]
Set $wgIncludeLegacyJavaScript false by default

This setting was deprecated in 0ac4f998 but was left as true by default, which
means sysadmins weren't prompted to find and fix faulty code. Setting this to
false by default gives them a release in which to fix the code (setting this
back to true until such fixes are made) before we remove it entirely in the
next MediaWiki release. Extensions, skins, gadgets and scripts that need the
mediawiki.legacy.wikibits module should express a dependency on it in their
ResourceLoader manifest.

Bug: T35836
Change-Id: If787d0975b6019827e81f4ea0d90898e361d9acd

6 years agoUse WIS:addWatchBatchForUser in SpecialEditWatchlist
addshore [Wed, 16 Mar 2016 13:54:26 +0000 (13:54 +0000)]
Use WIS:addWatchBatchForUser in SpecialEditWatchlist

Bug: T129481
Change-Id: I550e295786afaf9970fe96788f31d514827cd0bc

6 years agoSwitch Signature of WatchedItemStore::addWatchBatch
addshore [Tue, 22 Mar 2016 18:07:49 +0000 (18:07 +0000)]
Switch Signature of WatchedItemStore::addWatchBatch

Adding batches of watched items per users
makes much more sense.
Only the deprecated static WatchedItem method
needed the old silly way of passing in objects.

Change-Id: I90f9583b66bd3b5afcf07faefedb38a8a0149f6e

6 years agoSync up with Parsoid parserTests.
Subramanya Sastry [Thu, 24 Mar 2016 17:48:52 +0000 (12:48 -0500)]
Sync up with Parsoid parserTests.

This now aligns with Parsoid commit 5538d868777d2d5abb125dac310550fde3873689

Change-Id: I6750107c92c6dd96fe28ca96e66db43e0235c470

6 years agoMerge "Dont count RC_CATEGORIZE in Special:ActiveUsers"
jenkins-bot [Thu, 24 Mar 2016 17:10:35 +0000 (17:10 +0000)]
Merge "Dont count RC_CATEGORIZE in Special:ActiveUsers"

6 years agoMerge "Add redirect=no only to redirects on redirect pages"
Tjones [Thu, 24 Mar 2016 15:45:43 +0000 (15:45 +0000)]
Merge "Add redirect=no only to redirects on redirect pages"

6 years agoMerge "Use WIS::getWatchedItemsForUser in SpecialEditWatchlist"
jenkins-bot [Thu, 24 Mar 2016 15:06:34 +0000 (15:06 +0000)]
Merge "Use WIS::getWatchedItemsForUser in SpecialEditWatchlist"

6 years agoMerge "Introduce basic SpecialEditWatchlistTest"
jenkins-bot [Thu, 24 Mar 2016 15:06:30 +0000 (15:06 +0000)]
Merge "Introduce basic SpecialEditWatchlistTest"

6 years agoMerge "Introduce basic SpecialWatchlistTest"
jenkins-bot [Thu, 24 Mar 2016 15:03:32 +0000 (15:03 +0000)]
Merge "Introduce basic SpecialWatchlistTest"

6 years agoMerge "Cast row namespace to int in SpecialWatchlist"
jenkins-bot [Thu, 24 Mar 2016 15:03:28 +0000 (15:03 +0000)]
Merge "Cast row namespace to int in SpecialWatchlist"

6 years agoIntroduce basic SpecialEditWatchlistTest
addshore [Thu, 24 Mar 2016 13:18:38 +0000 (13:18 +0000)]
Introduce basic SpecialEditWatchlistTest

Change-Id: I9f765c4183314850169f685abd242e979a79bd68

6 years agoIntroduce basic SpecialWatchlistTest
addshore [Thu, 24 Mar 2016 13:11:07 +0000 (13:11 +0000)]
Introduce basic SpecialWatchlistTest

Change-Id: I98a2ad112189a09581a0564da3c3357939a5d7de

6 years agoUse WIS::getWatchedItemsForUser in SpecialEditWatchlist
addshore [Wed, 16 Mar 2016 13:40:40 +0000 (13:40 +0000)]
Use WIS::getWatchedItemsForUser in SpecialEditWatchlist

This also adds a order option to:

Tests are also updated

Change-Id: Ia683b92846ad79bde3f37068a8e168c5a8bdc201

6 years agoDont count RC_CATEGORIZE in Special:ActiveUsers
addshore [Thu, 24 Mar 2016 11:02:29 +0000 (11:02 +0000)]
Dont count RC_CATEGORIZE in Special:ActiveUsers

Bug: T130550
Change-Id: Ia2296586d35bb21085fcf386f26ad6f4e765e534

6 years agoCast row namespace to int in SpecialWatchlist
addshore [Thu, 24 Mar 2016 10:43:58 +0000 (10:43 +0000)]
Cast row namespace to int in SpecialWatchlist

Something similar to this recently got through
and caused exceptions on mw.org

This looks like the same thing, a ns from a db row
being handed straight to the TitleValue constructor
without being cast.

Change-Id: Ic126cd713c5210c9ae3d8e805081849ccf84a7f6

6 years agoMerge "ZipDirectoryReader: Don't try to parse zero-length files"
jenkins-bot [Thu, 24 Mar 2016 10:38:19 +0000 (10:38 +0000)]
Merge "ZipDirectoryReader: Don't try to parse zero-length files"

6 years agoMerge "MimeMagic: Prevent PHP warning when trying to read zero bytes"
jenkins-bot [Thu, 24 Mar 2016 10:33:23 +0000 (10:33 +0000)]
Merge "MimeMagic: Prevent PHP warning when trying to read zero bytes"

6 years agoZipDirectoryReader: Don't try to parse zero-length files
Bartosz Dziewoński [Thu, 24 Mar 2016 09:14:03 +0000 (10:14 +0100)]
ZipDirectoryReader: Don't try to parse zero-length files

With the current code, 'zip-bad' would be returned (eventually). I think
'zip-wrong-format' is a more correct response. This prevents weird errors
when trying to upload such a file (and results in saner errors instead).

Change-Id: Ic2c010f318d98df4783da1cf5126e8dd88aa9014

6 years agoMimeMagic: Prevent PHP warning when trying to read zero bytes
Bartosz Dziewoński [Thu, 24 Mar 2016 09:06:34 +0000 (10:06 +0100)]
MimeMagic: Prevent PHP warning when trying to read zero bytes

Honestly, there's no reason why fread() should warn when asked to read
zero bytes. It should just return zero bytes of content. Eh, PHP.

Bug: T130813
Change-Id: I56c4826759390bdbf6af04da28e2d9ed07781bca

6 years agoAlways use 'bool' instead of 'boolean' in Doxygen tags
Ricordisamoa [Thu, 24 Mar 2016 08:44:09 +0000 (09:44 +0100)]
Always use 'bool' instead of 'boolean' in Doxygen tags

Just like commit f86a5590aae7fbe6d9b8a3d129c7a04a11a27579

Change-Id: Ic9d08bca6524d6bb4baf5170c081ad0f3d738e28

6 years agoMerge "Improve sign-up portion of the login form"
jenkins-bot [Thu, 24 Mar 2016 06:56:30 +0000 (06:56 +0000)]
Merge "Improve sign-up portion of the login form"

6 years agoMerge "Title: Fix inaccurate documentation of getUserPermissionsErrorsInternal"
jenkins-bot [Thu, 24 Mar 2016 04:44:21 +0000 (04:44 +0000)]
Merge "Title: Fix inaccurate documentation of getUserPermissionsErrorsInternal"

6 years agoTitle: Fix inaccurate documentation of getUserPermissionsErrorsInternal
Matthew Flaschen [Fri, 18 Mar 2016 23:54:46 +0000 (19:54 -0400)]
Title: Fix inaccurate documentation of getUserPermissionsErrorsInternal

Blocks are checked (checkUserBlock).

Change-Id: I3a164d1003f2bea3e3e07081c9bebfabd884ade9

6 years agoMerge "OutputPage: Minor clean up of <head> and HTML"
jenkins-bot [Thu, 24 Mar 2016 03:45:16 +0000 (03:45 +0000)]
Merge "OutputPage: Minor clean up of <head> and HTML"

6 years agoOutputPage: Minor clean up of <head> and HTML
Timo Tijhof [Thu, 18 Feb 2016 16:33:15 +0000 (16:33 +0000)]
OutputPage: Minor clean up of <head> and HTML

* Remove trailing space in self-closing tag.
  Brings parserTest output of Parser and Parsoid closer together.

* Remove various line breaks at begin and end of script contents.

* Remove FILTER_NOMIN from makeConfigSetScript() output.
  This isn't part of any user- or page-dependent module and not minified.
  And Xml::encodeJsCall already ensures compact output for prod mode.

Bug: T127328
Change-Id: I85a5a59fd0955c1a112e8b24b933f0d9e983a156

6 years agoMerge "jquery.suggestions: Fix typo "singleton" in documentation"
jenkins-bot [Thu, 24 Mar 2016 02:56:31 +0000 (02:56 +0000)]
Merge "jquery.suggestions: Fix typo "singleton" in documentation"

6 years agojquery.suggestions: Fix typo "singleton" in documentation
Timo Tijhof [Thu, 24 Mar 2016 02:44:47 +0000 (02:44 +0000)]
jquery.suggestions: Fix typo "singleton" in documentation

Change-Id: I81af9a1974ea9c9dcd26f201bf055554087ccd99

6 years agoMerge "Request-local caching of DjVu dimensions"
jenkins-bot [Thu, 24 Mar 2016 01:04:14 +0000 (01:04 +0000)]
Merge "Request-local caching of DjVu dimensions"

6 years agoparserTest: Remove mention of non-existent 'noxml' option
Timo Tijhof [Tue, 8 Mar 2016 18:32:37 +0000 (18:32 +0000)]
parserTest: Remove mention of non-existent 'noxml' option

The 'noxml' documentation in parserTests.txt was added in 2006 (7eea2398; r12504),
however it wasn't actually implemented.

It wasn't until 2009 (7aa4a8f9; r54767) that $wgWellFormedXml was created,
which defaults to true and has no relation to this option.

Remove the 'noxml' options from existing tests.

Change-Id: Ie3ae9f491b5747716080607b81b9763bf2bcc889

6 years agoMerge "Request-local caching of revision text"
jenkins-bot [Wed, 23 Mar 2016 23:28:58 +0000 (23:28 +0000)]
Merge "Request-local caching of revision text"

6 years agoRequest-local caching of DjVu dimensions
Ori Livneh [Wed, 23 Mar 2016 19:37:01 +0000 (12:37 -0700)]
Request-local caching of DjVu dimensions

Make DjVuHandler::getDimensionInfo() cache dimension info in memory so that
operations which get the dimensions of each page don't result in multiple
round-trips to memcached.

Change-Id: Idbd11637a8f7d87e4774f76a5b90d7469f3b0857

6 years agomediawiki.requestIdleCallback: Implement timeRemaining()
Timo Tijhof [Sat, 12 Mar 2016 02:19:35 +0000 (02:19 +0000)]
mediawiki.requestIdleCallback: Implement timeRemaining()

This matches the native API. This allows callers to better batch and spread out
expensive operations based on actual execution speed.

Right now CentralNotice is manually creating arbitrarily sized batches in
kvStoreMaintenance. Instead this can use a while loop with timeRemaining()
to run as quickly as possible whilst still being able to stop and yield when
it runs for too long. This way will naturally take more iterations on slow
devices and less iterations on faster ones - to be least disruptive.

While timeRemaining() is already available in the native interface,
it was previously unsafe to call because the fallback didn't implement it.

* Remove redundant QUnit.test() expect numbers.

* Add a test for the native one if available. This will catch silly mistakes
  like assigning the native one to mw.requestIdleCallback directly that result
  in 'Uncaught TypeError: Illegal invocation' due to missing call context.

Change-Id: I9721fab9e89c561e31101b5556a3748431353548

6 years agoMerge "Cast namespaceId to int in SpecialEditWatchlist::cleanupWatchlist"
jenkins-bot [Wed, 23 Mar 2016 21:55:54 +0000 (21:55 +0000)]
Merge "Cast namespaceId to int in SpecialEditWatchlist::cleanupWatchlist"

6 years agoCast namespaceId to int in SpecialEditWatchlist::cleanupWatchlist
addshore [Wed, 23 Mar 2016 21:21:00 +0000 (21:21 +0000)]
Cast namespaceId to int in SpecialEditWatchlist::cleanupWatchlist

Bug: T130778
Change-Id: I4b62e5b251f8c3d31aa2f76a9988b5cb7c8cf3b7

6 years agoMerge "SpecialUploadStash: Add links to view a thumb of each uploaded file"
jenkins-bot [Wed, 23 Mar 2016 21:20:56 +0000 (21:20 +0000)]
Merge "SpecialUploadStash: Add links to view a thumb of each uploaded file"

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 23 Mar 2016 20:54:56 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Idf395e9379605a64103df4ee0ce3847b600f5ede

6 years agoCleanups to WikiRevision
Aaron Schulz [Fri, 4 Mar 2016 19:58:20 +0000 (11:58 -0800)]
Cleanups to WikiRevision

* Check for blank $source variable more properly.
* Avoid use of ugly File::DELETE_SOURCE flag.
* Remove now-unused $flags parameter to uploadOld().

Change-Id: I6bc610cfead0036700b4f9a82e13f2bd9ab10f32

6 years agoMerge "Add WatchedItemStore::getWatchedItemsForUser"
jenkins-bot [Wed, 23 Mar 2016 15:45:45 +0000 (15:45 +0000)]
Merge "Add WatchedItemStore::getWatchedItemsForUser"

6 years agoMerge "Ensure that User::getId() returns int"
jenkins-bot [Wed, 23 Mar 2016 14:58:51 +0000 (14:58 +0000)]
Merge "Ensure that User::getId() returns int"

6 years agoAdd WatchedItemStore::getWatchedItemsForUser
addshore [Tue, 15 Mar 2016 22:19:16 +0000 (22:19 +0000)]
Add WatchedItemStore::getWatchedItemsForUser

This method is also no used in SpecialEditWatchlist

Unit and Integration tests have also been added.

Bug: T129481
Change-Id: Ica136b6fee63be8de4c2fe502288dd2318d99114

6 years agoMerge "SessionManager: Use existing backend for the ID if one is loaded"
jenkins-bot [Wed, 23 Mar 2016 10:37:13 +0000 (10:37 +0000)]
Merge "SessionManager: Use existing backend for the ID if one is loaded"

6 years agoRequest-local caching of revision text
Ori Livneh [Wed, 23 Mar 2016 00:21:48 +0000 (17:21 -0700)]
Request-local caching of revision text

It's not uncommon for the revision text of a Scribunto module to be retrieved
half a dozen times or more in the course of a single request. Caching them in
APC is a non-starter, because there is no practical way to determine which keys
are hot, and storing everything in APC is not viable. Request-local caching
gives us much of the benefit with no negative consequences apart from a nominal
increase to memory usage.

Use a MapCacheLRU to hold cache items so we can limit the size of the cache to
10 items, to prevent uncontrolled memory growth for long-running scripts.

Change-Id: I77575d6d0ea2d06fc6c93f664c5407641aab88d9

6 years agoMerge "Add new index to make updateCollation.php painless"
jenkins-bot [Wed, 23 Mar 2016 00:56:01 +0000 (00:56 +0000)]
Merge "Add new index to make updateCollation.php painless"

6 years agoMerge "Fix typos in docs/memcached.txt"
jenkins-bot [Tue, 22 Mar 2016 23:26:36 +0000 (23:26 +0000)]
Merge "Fix typos in docs/memcached.txt"

6 years agoFix typos in docs/memcached.txt
Ori Livneh [Tue, 22 Mar 2016 23:02:29 +0000 (16:02 -0700)]
Fix typos in docs/memcached.txt

expriy, expriry => expiry

Change-Id: I96304392e79499d78551e9d66fb0161d759bf1e0

6 years agoUpdate OOjs UI to v0.16.4
James D. Forrester [Tue, 22 Mar 2016 22:50:39 +0000 (15:50 -0700)]
Update OOjs UI to v0.16.4

Release notes:

Change-Id: Ic0f8cf4fc956feff29189c4d3e1d83e071daa8f7

6 years agoAdd new index to make updateCollation.php painless
Brian Wolff [Sun, 21 Feb 2016 21:59:14 +0000 (16:59 -0500)]
Add new index to make updateCollation.php painless

We want to update categories in order, to minimize disruption
to users. Previous indexes required a filesort to do this, which
exploded things on large wikis. See bug for details

Bug: T58041
Change-Id: Iee6cd997ff87a313a46fda19d8ab063d0fed8ce8

6 years agoSessionManager: Use existing backend for the ID if one is loaded
Brad Jorsch [Tue, 22 Mar 2016 21:50:32 +0000 (17:50 -0400)]
SessionManager: Use existing backend for the ID if one is loaded

This fixes a bug where SessionBackend::resetId() of the PHP session will
fail to properly load $_SESSION because the new session ID hasn't been
saved to the store yet. It's also a reasonable performance improvement,
no need to call loadSessionInfoFromStore() when we already have the
session loaded.

Change-Id: I30f159ef1267442a6325aabbbdfaf69defc10ed6

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 22 Mar 2016 21:00:03 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Iba1610b61c1658b22216e57ed5d60d131073feab

6 years agoMerge "Revert "Add link to anon's user page; remove "Not logged in"""
jenkins-bot [Tue, 22 Mar 2016 18:08:27 +0000 (18:08 +0000)]
Merge "Revert "Add link to anon's user page; remove "Not logged in"""

6 years agoMerge "Message: Use RequestContext instead of $wgLang"
jenkins-bot [Tue, 22 Mar 2016 17:17:53 +0000 (17:17 +0000)]
Merge "Message: Use RequestContext instead of $wgLang"

6 years agoRevert "Add link to anon's user page; remove "Not logged in""
Tyler Cipriani [Tue, 22 Mar 2016 16:08:52 +0000 (09:08 -0700)]
Revert "Add link to anon's user page; remove "Not logged in""

This reverts change I049d0671a7050.

This change was reverted in the wmf/1.27.0-wmf.17. Since there is no
clear consensus, revert in master before branching wmf/1.27.0-wmf.18.

Bug: T121793
Change-Id: I2dc0f2562c908d4e419d34e80a64065843778f3d

6 years agoNames.php: Use ʻ instead of ` as ʻokina in Hawaiian
Fomafix [Tue, 22 Mar 2016 06:15:46 +0000 (06:15 +0000)]
Names.php: Use ʻ instead of ` as ʻokina in Hawaiian

In the Unicode standard, the ʻokina is encoded as U+02BB ʻ MODIFIER LETTER TURNED COMMA

Change-Id: I030f3b46382d5c5ed5ba81471f7c4156c660b244

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 21 Mar 2016 22:00:56 +0000 (23:00 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I9e4277291fc529f86496f46c8eab1c2cd4590903

6 years agoMerge "mw.widgets.CategoryCapsuleItemWidget: Pass the right 'this'"
jenkins-bot [Mon, 21 Mar 2016 20:48:12 +0000 (20:48 +0000)]
Merge "mw.widgets.CategoryCapsuleItemWidget: Pass the right 'this'"

6 years agomw.widgets.CategoryCapsuleItemWidget: Pass the right 'this'
Bartosz Dziewoński [Mon, 21 Mar 2016 16:38:06 +0000 (17:38 +0100)]
mw.widgets.CategoryCapsuleItemWidget: Pass the right 'this'

Follow-up to 7b57752e65c3cac62d973f43d1060b6bd0ab2a2f.

Bug: T130544
Change-Id: I89c18be911bcc492f3a70e1c1da3d2fd2bf65a05

6 years agoMerge "Use WatchedItemStore in ApiQueryInfo::getWatchedInfo"
jenkins-bot [Mon, 21 Mar 2016 10:24:09 +0000 (10:24 +0000)]
Merge "Use WatchedItemStore in ApiQueryInfo::getWatchedInfo"

6 years agoUse WatchedItemStore in ApiQueryInfo::getWatchedInfo
Leszek Manicki [Fri, 18 Mar 2016 13:43:26 +0000 (14:43 +0100)]
Use WatchedItemStore in ApiQueryInfo::getWatchedInfo

Adds a method for getting watchlist's notification timestamps
for a batch of LinkTargets.

Bug: T129482
Change-Id: I1f84212e7879a84b34bb3b53859069fcea282bba

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 20 Mar 2016 21:15:07 +0000 (22:15 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I3d9b14ae3a5d77fea9694ef113b0180e5677c39e

6 years agoMerge "Update phpunit to 4.8.24"
jenkins-bot [Sun, 20 Mar 2016 17:28:35 +0000 (17:28 +0000)]
Merge "Update phpunit to 4.8.24"

6 years agoMerge "Call Skin::setRelevantUser on Special:EmailUser"
jenkins-bot [Sun, 20 Mar 2016 14:08:18 +0000 (14:08 +0000)]
Merge "Call Skin::setRelevantUser on Special:EmailUser"

6 years agoUpdate phpunit to 4.8.24
Paladox [Sun, 20 Mar 2016 12:12:41 +0000 (12:12 +0000)]
Update phpunit to 4.8.24

See changelog at

Change-Id: I604f10917e015788acf49cdcd6389957da89fbdb

6 years agoUploadBase: Set mFileSize, if given, even if mTempPath is unknown
Bartosz Dziewoński [Sun, 20 Mar 2016 07:24:29 +0000 (08:24 +0100)]
UploadBase: Set mFileSize, if given, even if mTempPath is unknown

When uploading a file from stash using the action=upload API, with
async=1, UploadFromStash is initialized without initializing a temp
file. dcb5ec5cbf92b9a07f0776b9c194183a13400193 accidentally made it so
that the given file size is ignored if there's no path. This caused
validity checks to fail (because mFileSize is null) and action=upload
to also fail with cryptic 'emptyfile' warning.

This made it impossible to upload files bigger than 10 MB using
UploadWizard, as it uses the async mode for them.

Bug: T130238
Change-Id: Ie35a66a565a370fe9adc66d5fee0866c4d51470e

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 19 Mar 2016 21:10:06 +0000 (22:10 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I67c4a49a16f5cee599db767b1414cac75bc19fd5

6 years agobuild: Bump npm development dependencies to latest
James D. Forrester [Thu, 17 Mar 2016 19:45:21 +0000 (19:45 +0000)]
build: Bump npm development dependencies to latest

 grunt-contrib-copy     0.8.2  →    1.0.0
 grunt-contrib-watch    0.6.1  →    1.0.0
 karma                0.13.19  →  0.13.22

Change-Id: Idc5c1ac97580e91d9c958c55cdfdda681330c254

6 years agoMerge "Handle HTTPS when running jobs asynchronously"
jenkins-bot [Sat, 19 Mar 2016 16:27:43 +0000 (16:27 +0000)]
Merge "Handle HTTPS when running jobs asynchronously"

6 years agoListFiles: Call Skin::setRelevantUser() when applicable
rillke [Mon, 14 Mar 2016 05:28:04 +0000 (06:28 +0100)]
ListFiles: Call Skin::setRelevantUser() when applicable

Also validate user name before calling `User::newFromName()`

Bug: T129825
Change-Id: I7481ab0fc1720e5e840f0d552934324f676c0241

6 years agoCall Skin::setRelevantUser on Special:EmailUser
umherirrender [Sat, 19 Mar 2016 11:24:04 +0000 (12:24 +0100)]
Call Skin::setRelevantUser on Special:EmailUser

Adding the relevant user to the skin will add user releated links to the
navigation bar. User related links are: contributions, logs and blocks

Change-Id: I37126a228717addc9879fd69fcbe89057ca94cb7

6 years agoMerge "Many more function case mismatches"
jenkins-bot [Sat, 19 Mar 2016 00:37:53 +0000 (00:37 +0000)]
Merge "Many more function case mismatches"

6 years agoMany more function case mismatches
Reedy [Sat, 19 Mar 2016 00:08:06 +0000 (00:08 +0000)]
Many more function case mismatches

Change-Id: I5d3a5eb8adea1ecbf136415bb9fd7a162633ccca

6 years agoMerge "MediaWikiTestCase::assertException() was removed"
jenkins-bot [Sat, 19 Mar 2016 00:15:13 +0000 (00:15 +0000)]
Merge "MediaWikiTestCase::assertException() was removed"

6 years agoMediaWikiTestCase::assertException() was removed
Siebrand Mazeland [Tue, 8 Mar 2016 23:46:51 +0000 (00:46 +0100)]
MediaWikiTestCase::assertException() was removed

Deprecated since 1.22. No uses in core or Gerrit extensions remaining.

Change-Id: Icae4077078c73d766d3c1c9e9e569922151296d9

6 years agoUpdate grunt-karma to 0.12.2
Paladox [Fri, 18 Mar 2016 23:38:07 +0000 (23:38 +0000)]
Update grunt-karma to 0.12.2

Reason because this update will include a fix for incompatibility with
grunt 1.0.0 when it is released.

Change-Id: I39f01e3a68b764a4638c3465a1d116aefd517ef5

6 years agoMessage: Use RequestContext instead of $wgLang
Timo Tijhof [Tue, 1 Mar 2016 00:13:28 +0000 (00:13 +0000)]
Message: Use RequestContext instead of $wgLang

This cuts the $wgLang and StubUserLang which is a bit cleaner.
It also makes it more reliable when load.php sets its
RequestContext user interface language.

Bug: T127920
Change-Id: I05302feb9b3ce9e4c29541e07a4260effc4b55b2

6 years agoFix numerous class/function casing
Reedy [Fri, 18 Mar 2016 13:55:54 +0000 (13:55 +0000)]
Fix numerous class/function casing

Change-Id: I23982bfa0548c9ea3bdb432be7982f1563930715

6 years agoMerge "API: Allow fetching login token from action=query&meta=tokens on private wikis"
jenkins-bot [Fri, 18 Mar 2016 22:19:25 +0000 (22:19 +0000)]
Merge "API: Allow fetching login token from action=query&meta=tokens on private wikis"

6 years agoMerge "resetUserEmail: Allow resetting email without scrambling password"
jenkins-bot [Fri, 18 Mar 2016 22:04:52 +0000 (22:04 +0000)]
Merge "resetUserEmail: Allow resetting email without scrambling password"

6 years agoMerge "Actually make $wgNoReplyAddress default to $wgPasswordSender"
jenkins-bot [Fri, 18 Mar 2016 21:30:58 +0000 (21:30 +0000)]
Merge "Actually make $wgNoReplyAddress default to $wgPasswordSender"

6 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Fri, 18 Mar 2016 21:23:55 +0000 (21:23 +0000)]
Merge "Localisation updates from https://translatewiki.net."

6 years agoMerge "Try to fix some other broken-looking legacy maintenance script options"
jenkins-bot [Fri, 18 Mar 2016 21:13:39 +0000 (21:13 +0000)]
Merge "Try to fix some other broken-looking legacy maintenance script options"

6 years agoMerge "Register importImages options without arguments as actual maintenance script...
jenkins-bot [Fri, 18 Mar 2016 21:13:35 +0000 (21:13 +0000)]
Merge "Register importImages options without arguments as actual maintenance script options so they are usable"