lhc/web/wiklou.git
3 years agoAdd tablesUsed to RevisionStoreDbTest
addshore [Mon, 29 Jan 2018 17:08:58 +0000 (17:08 +0000)]
Add tablesUsed to RevisionStoreDbTest

Bug: T183777
Change-Id: Ie8bc2a9aca341a44c22828c9e9c3a7f89c7f87cd

3 years agoMerge "API: Allow to pass whitespaces in MultiValue"
jenkins-bot [Mon, 29 Jan 2018 15:31:43 +0000 (15:31 +0000)]
Merge "API: Allow to pass whitespaces in MultiValue"

3 years agoMerge "benchmarks: Simplify benchmarkLruHash.php by using a --method option"
jenkins-bot [Mon, 29 Jan 2018 12:53:22 +0000 (12:53 +0000)]
Merge "benchmarks: Simplify benchmarkLruHash.php by using a --method option"

3 years agoMerge "selenium: add new message banner test to user spec"
jenkins-bot [Mon, 29 Jan 2018 11:53:46 +0000 (11:53 +0000)]
Merge "selenium: add new message banner test to user spec"

3 years agobenchmarks: Simplify benchmarkLruHash.php by using a --method option
Timo Tijhof [Sat, 27 Jan 2018 17:06:12 +0000 (09:06 -0800)]
benchmarks: Simplify benchmarkLruHash.php by using a --method option

Easier to extend.

Change-Id: Ib9c6b3d10caad7de138d8bafd2f0e6e9bbe6a8cc

3 years agoAPI: Allow to pass whitespaces in MultiValue
Fomafix [Sun, 21 Jan 2018 20:58:59 +0000 (21:58 +0100)]
API: Allow to pass whitespaces in MultiValue

This allows to response with an invalidreason instead silently ignore
the parameter.

Example request: api.php?format=json&action=query&titles=%20

Response before this change:
{
  "batchcomplete": ""
}

Response with this change:
{
  "batchcomplete": "",
  "query": {
    "pages": {
      "-1": {
        "title": " ",
        "invalidreason": "The requested page title is empty or contains only the name of a namespace.",
        "invalid": ""
      }
    }
  }
}

Bug: T185846
Change-Id: I6fdaf32792a0e6e37b08176f975c10607093351b

3 years agoImprove MediaWiki's lock file error message when uploading files
Zoranzoki21 [Sun, 28 Jan 2018 13:56:02 +0000 (13:56 +0000)]
Improve MediaWiki's lock file error message when uploading files

Bug: T181453
Change-Id: I1e78d5eadd19c5cf203b8f4bbc8ab6d533307a15

3 years agoUpdate CREDITS file to include new contributors
Alangi Derick [Fri, 19 Jan 2018 12:33:36 +0000 (13:33 +0100)]
Update CREDITS file to include new contributors

Ran the updateCredits.php script to include new contributors of
MW and its extensions into the CREDITS file after a while. Keeping
the contributor list updated is useful.

Change-Id: I491c35285b562e1792715b83c674b8f1173add77

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 27 Jan 2018 21:04:00 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I2839c3d3bdb2b229e2cb8226af32964cfc2669ab

3 years agoMerge "benchmarks: Improve readme and convert to Markdown"
jenkins-bot [Sat, 27 Jan 2018 13:20:47 +0000 (13:20 +0000)]
Merge "benchmarks: Improve readme and convert to Markdown"

3 years agoRemove deprecated PreparedEdit properties
addshore [Sat, 27 Jan 2018 00:57:13 +0000 (16:57 -0800)]
Remove deprecated PreparedEdit properties

The following properties of PreparedEdit were deprecated in
1.21 and have been removed:
  * PreparedEdit->newText
  * PreparedEdit->oldText
  * PreparedEdit->pst

These have no use left in core or extensions.

Change-Id: Ic48c817aaf3fbb6d5f33678fcb4843180f0bc9fb

3 years agobenchmarks: Improve readme and convert to Markdown
Timo Tijhof [Sat, 27 Jan 2018 00:31:54 +0000 (16:31 -0800)]
benchmarks: Improve readme and convert to Markdown

* Add sections.
* Rename to *.md.
* Document that taskset is Linux-specific.

Change-Id: If6c5e54eda4dd1d6ea02445efa73e356dbc49016

3 years agoRemove "Created on" from file header comments
Umherirrender [Fri, 12 Jan 2018 21:03:53 +0000 (22:03 +0100)]
Remove "Created on" from file header comments

It is the job of git and svn to provide this information/metadata.
The form was different, some with short, some with long month name
some with leading zero at the day, some without.
The year is also present in the Copyright clause

Change-Id: If006907b82b9e45f13cfa2e45d41107a95570e1a

3 years agoUse ::class to resolve class names in tests
Umherirrender [Sat, 13 Jan 2018 00:02:09 +0000 (01:02 +0100)]
Use ::class to resolve class names in tests

This helps to find renamed or misspelled classes earlier.
Phan will check the class names

Change-Id: Ie541a7baae10ab6f5c13f95ac2ff6598b8f8950c

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 26 Jan 2018 21:15:50 +0000 (22:15 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I3c040bc4add0a8c325afa5d8403e8ce3f5842060

3 years agoMerge "rdbms: Simplify Database::factory()"
jenkins-bot [Fri, 26 Jan 2018 19:38:07 +0000 (19:38 +0000)]
Merge "rdbms: Simplify Database::factory()"

3 years agoMerge "Gallery: Use Parser::parseWidthParam() for gallery dimensions"
jenkins-bot [Fri, 26 Jan 2018 18:17:55 +0000 (18:17 +0000)]
Merge "Gallery: Use Parser::parseWidthParam() for gallery dimensions"

3 years agoMerge "Revert and fix "Revert "EditPage: Show EditFilterMergedContent hook errors...
jenkins-bot [Fri, 26 Jan 2018 18:01:45 +0000 (18:01 +0000)]
Merge "Revert and fix "Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"""

3 years agoMerge "Improve 1-letter variable names in MutableContext and implementations"
jenkins-bot [Fri, 26 Jan 2018 17:49:40 +0000 (17:49 +0000)]
Merge "Improve 1-letter variable names in MutableContext and implementations"

3 years agoRevert and fix "Revert "EditPage: Show EditFilterMergedContent hook errors in an...
Brad Jorsch [Fri, 26 Jan 2018 17:12:28 +0000 (09:12 -0800)]
Revert and fix "Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox""

Instead of making a one-line fix to fix the issue in T149473, the change
was reverted.

This reverts commit 022f26e9fd3ae865331f3bb1b3eec63e212240c9.
This reverts commit 12f170502cfef525344ae69caef6240eaafbf63f.

Bug: T149473
Bug: T185638
Change-Id: Ib44ba2a6d2405309ad91bcc4d6440d05b67379da

3 years agoMerge "Don’t write to stderr when testing"
jenkins-bot [Fri, 26 Jan 2018 14:12:46 +0000 (14:12 +0000)]
Merge "Don’t write to stderr when testing"

3 years agoMerge "thumb.php: Set ENT_NOQUOTES for htmlspecialchars"
jenkins-bot [Fri, 26 Jan 2018 10:58:17 +0000 (10:58 +0000)]
Merge "thumb.php: Set ENT_NOQUOTES for htmlspecialchars"

3 years agoMerge "Remove misleading comment for $wgLegalTitleChars"
jenkins-bot [Fri, 26 Jan 2018 08:45:01 +0000 (08:45 +0000)]
Merge "Remove misleading comment for $wgLegalTitleChars"

3 years agoRemove misleading comment for $wgLegalTitleChars
Bartosz Dziewoński [Fri, 26 Jan 2018 08:28:35 +0000 (00:28 -0800)]
Remove misleading comment for $wgLegalTitleChars

This comment originates from rSVN1420 (9d51f616), dated 2 July 2003,
where it was written as "ISO 8859-* don't allow 0x80-0x9F... But that
breaks interlanguage links at the moment". It was rephrased to the
current form in rSVN2621 (840dee3a).

It is incorrect for two reasons:

* "Theoretically 0x80-0x9F of ISO 8859-1 should be disallowed..."

  We cannot disallow 0x80-0x9F here; this config variable actually
  specifies the valid ranges of *bytes* rather than characters, and
  0x80 to 0x9F can happily appear in valid UTF-8 encodings of other
  characters.

  In case we wanted to disallow the Unicode characters U+0080 to U+009F
  (encoded in UTF-8 as 0xC2 0x80 to 0xC2 0x9F), it would probably have
  to be done explicitly in MediaWikiTitleCodec::splitTitleString().
  (The task for this is T7732.)

* "...but this breaks interlanguage links"

  Back then, most wikis were using single-byte ISO encodings rather
  than UTF-8, and that is the only configuration this comment applies
  to: disallowing the bytes 0x80-0x9F in page titles on wikis using
  single-byte ISO encodings would indeed have broken interlanguage
  links from them to wikis using UTF-8. However, disallowing the
  Unicode characters U+0080 to U+009F today definitely would not break
  interlanguage links.

Change-Id: Ic5ba502ccfbb9cf3ff56cc47eb7fe463e7d45959

3 years agoMerge "Convert the sha1 value from base-36 to base-16"
jenkins-bot [Fri, 26 Jan 2018 06:54:37 +0000 (06:54 +0000)]
Merge "Convert the sha1 value from base-36 to base-16"

3 years agoGallery: Use Parser::parseWidthParam() for gallery dimensions
Prateek Saxena [Sun, 19 Jun 2016 06:41:43 +0000 (12:11 +0530)]
Gallery: Use Parser::parseWidthParam() for gallery dimensions

Used by the `setWidths` and `setHeights` methods to make sure we are
using correct values.

Makes `parseWidthParam` static to be used in the gallery class.

Bug: T129372
Change-Id: I38b9ef0ea26e3748ad5d5458fadd2545f677ef93

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 25 Jan 2018 20:54:23 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I10962812b862c1949ee0d196d6d70fd1c33445d1

3 years agoMerge "SpecialPage: Fix typo in comment"
jenkins-bot [Thu, 25 Jan 2018 20:48:44 +0000 (20:48 +0000)]
Merge "SpecialPage: Fix typo in comment"

3 years agoSpecialPage: Fix typo in comment
Bartosz Dziewoński [Thu, 25 Jan 2018 20:38:51 +0000 (12:38 -0800)]
SpecialPage: Fix typo in comment

Change-Id: I03f30b978e5dc7736d24873a04e91f5bb0171a86

3 years agoConvert the sha1 value from base-36 to base-16
RazeSoldier [Thu, 25 Jan 2018 04:58:06 +0000 (12:58 +0800)]
Convert the sha1 value from base-36 to base-16

Convert the sha1 value displayed on the file info page from base-36 to
base-16

Bug: T181651
Change-Id: I39d6d5d68973c9e67959b2bbbe77937f4ccca76a

3 years agoLivePreview: Add uselang parameter to API diff request
Fomafix [Thu, 25 Jan 2018 18:30:55 +0000 (19:30 +0100)]
LivePreview: Add uselang parameter to API diff request

Some elements like the line numbers of a diff depends on the user
interface language. This change ensures that the language of the user
interface is used of live preview diffs, too.

Bug: T185683
Change-Id: I438e19028700fb2d5bcd57d214e1134d656fb7b2

3 years agordbms: Simplify Database::factory()
Timo Tijhof [Wed, 24 Jan 2018 19:33:37 +0000 (11:33 -0800)]
rdbms: Simplify Database::factory()

Follows-up 0ff2b7a776 (T120333) which removed support for the
deprecated php 'mysql' extension.

It surprised me that the 'DatabaseMysql' entry could safely be removed
from $classAliases. This was because the key is not direct input,
but based on $canonicalDBTypes, which maps mysql to mysqli.

Take this further by removing the indirection between type, driver
and class name.

* Map built-in db types directly to their class and driver.
* Change fallback to assign $class directly from $dbType, without
  indirection of a $driver variable.
* Remove unused $classAliases.

Change-Id: I1200b07f66f23624410d848b6f382cb2dafa5c59

3 years agoMerge "Remove very, very old disabled test cases and todos"
jenkins-bot [Thu, 25 Jan 2018 17:01:54 +0000 (17:01 +0000)]
Merge "Remove very, very old disabled test cases and todos"

3 years agoMerge "widget: Fix changes of copyright year"
jenkins-bot [Thu, 25 Jan 2018 10:34:02 +0000 (10:34 +0000)]
Merge "widget: Fix changes of copyright year"

3 years agoMerge "Load preferences js/css in mobile"
jenkins-bot [Wed, 24 Jan 2018 22:55:50 +0000 (22:55 +0000)]
Merge "Load preferences js/css in mobile"

3 years agoMerge "Use RevisionLookup and RevisionFactory interfaces in Revision"
jenkins-bot [Wed, 24 Jan 2018 22:51:44 +0000 (22:51 +0000)]
Merge "Use RevisionLookup and RevisionFactory interfaces in Revision"

3 years agoUse RevisionLookup and RevisionFactory interfaces in Revision
addshore [Tue, 9 Jan 2018 08:53:38 +0000 (08:53 +0000)]
Use RevisionLookup and RevisionFactory interfaces in Revision

Lets not depend on the big blob that is RevisionStore.
Try to bind to the nice interfaces that we have where possible.

In the future RevisionStore should be split up further into
it's individual interfaces.

It looks like there are some more methods which should be moved
to both RevisionLookup and RevisionFactory.
See draft:
I214c5952d4a0fad55ff4116e90eab9ac3ba54fd3

Change-Id: I8df61374e24abcf4a7e38e53647489b8ecc1fd77

3 years agoExtra tests for SqlBlobStore with 'windows-1252' legacy encoding
addshore [Thu, 11 Jan 2018 20:55:37 +0000 (20:55 +0000)]
Extra tests for SqlBlobStore with 'windows-1252' legacy encoding

Bug: T184749
Change-Id: Ida717dbe6ae742b3b61f0f09dc60712307c53a96

3 years agoselenium: add new message banner test to user spec
addshore [Sat, 13 Jan 2018 14:25:09 +0000 (14:25 +0000)]
selenium: add new message banner test to user spec

Change-Id: I92dc612d215d1d3eb8dff02c2ff4d57da0105d69

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 24 Jan 2018 20:55:30 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I31c3b81ae100f17d7fecb607b2a0a1ab4a9b60b1

3 years agowidget: Fix changes of copyright year
Kunal Mehta [Wed, 24 Jan 2018 19:59:05 +0000 (11:59 -0800)]
widget: Fix changes of copyright year

Fixes up e8b10f68049c19a.

Change-Id: I474e508a2bd4d783272eda87c1cc91f5597bc1b1

3 years agoMerge "Simplify documentation headers of includes/widgets/…Widget.php files"
jenkins-bot [Wed, 24 Jan 2018 19:14:56 +0000 (19:14 +0000)]
Merge "Simplify documentation headers of includes/widgets/…Widget.php files"

3 years agoLoad preferences js/css in mobile
jdlrobson [Wed, 24 Jan 2018 18:54:05 +0000 (10:54 -0800)]
Load preferences js/css in mobile

Change-Id: Idbf62486c787179ee67deb22e4644f4fc742d9db

3 years agoMerge "poolcounter: Fix type hint for PoolWorkArticleView::getParserOutput"
jenkins-bot [Wed, 24 Jan 2018 18:53:19 +0000 (18:53 +0000)]
Merge "poolcounter: Fix type hint for PoolWorkArticleView::getParserOutput"

3 years agopoolcounter: Fix type hint for PoolWorkArticleView::getParserOutput
Thiemo Mättig [Wed, 24 Jan 2018 14:22:12 +0000 (15:22 +0100)]
poolcounter: Fix type hint for PoolWorkArticleView::getParserOutput

Change-Id: Ib6a71e198481cf2a0230b3f8721c019ef3c7288c

3 years agoMerge "Fix called function case in a bunch of places"
jenkins-bot [Wed, 24 Jan 2018 16:25:52 +0000 (16:25 +0000)]
Merge "Fix called function case in a bunch of places"

3 years agoMerge "Set $_SERVER['SERVER_NAME'] to the value set by --server"
jenkins-bot [Wed, 24 Jan 2018 15:24:57 +0000 (15:24 +0000)]
Merge "Set $_SERVER['SERVER_NAME'] to the value set by --server"

3 years agoDon’t write to stderr when testing
Lucas Werkmeister [Wed, 24 Jan 2018 13:29:23 +0000 (14:29 +0100)]
Don’t write to stderr when testing

This change makes it possible to test error() messages with
expectOutputString() or expectOutputRegex().

Change-Id: I61970403f9c371d3798f34fd48c70bc72f0c7eda

3 years agoAdd missing Maintenance import
Lucas Werkmeister [Wed, 24 Jan 2018 13:28:39 +0000 (14:28 +0100)]
Add missing Maintenance import

Without this import, the @var Maintenance comment on $maintenance
doesn’t refer to the right class.

Change-Id: I2b5efa422f3e9d50f2132658b04ea2814af61954

3 years agoMerge "Add a hook into LanguageConverter#getPreferredVariant() to allow extensions...
jenkins-bot [Tue, 23 Jan 2018 23:01:34 +0000 (23:01 +0000)]
Merge "Add a hook into LanguageConverter#getPreferredVariant() to allow extensions to pull the desired variant from cookies (or other such source)"

3 years agoMerge "Phan: resolve and reenable PhanAccessMethodProtected"
jenkins-bot [Tue, 23 Jan 2018 22:43:10 +0000 (22:43 +0000)]
Merge "Phan: resolve and reenable PhanAccessMethodProtected"

3 years agoMerge "Remove dot from summary used by fixDoubleRedirects.php"
jenkins-bot [Tue, 23 Jan 2018 20:58:50 +0000 (20:58 +0000)]
Merge "Remove dot from summary used by fixDoubleRedirects.php"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 23 Jan 2018 20:55:21 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Iaa76ffaa796a221bb23a3aa411634744726285cc

3 years agoMerge "Create factory for MWHttpRequest"
jenkins-bot [Tue, 23 Jan 2018 19:49:25 +0000 (19:49 +0000)]
Merge "Create factory for MWHttpRequest"

3 years agoCreate factory for MWHttpRequest
Stanislav Malyshev [Tue, 16 Jan 2018 23:11:08 +0000 (15:11 -0800)]
Create factory for MWHttpRequest

This will allow classes that need MWHttpRequest to inject HttpRequestFactory
and thus make it overridable and testable.

Also made MWHttpRequest abstract class since it doesn't implement
execute anyway. Maybe a good idea to move execute to an abstract
method?

Change-Id: I5c0e035542ff5f791a21a95ed13bed4cea6906d0

3 years agoExtensionRegistry: Properly detect if a global is already set
Marius Hoch [Tue, 23 Jan 2018 18:44:28 +0000 (10:44 -0800)]
ExtensionRegistry: Properly detect if a global is already set

$foo = null; isset( $foo ); will yield false.

Sometimes we want to explicitly set a config to null, but ExtensionRegistry
is then overriding this variable with the default value.

This is no consistent with the old workflow:
require_once the extension and then override the setting with null.

Bug: T128661
Change-Id: I0654c9369a596e84591fcaa9643703e6b4ccf57e

3 years agoMerge "Add collation for Abkhaz (ab)"
jenkins-bot [Tue, 23 Jan 2018 18:42:29 +0000 (18:42 +0000)]
Merge "Add collation for Abkhaz (ab)"

3 years agoRemove dot from summary used by fixDoubleRedirects.php
MarcoAurelio [Tue, 23 Jan 2018 18:32:57 +0000 (19:32 +0100)]
Remove dot from summary used by fixDoubleRedirects.php

Bug: T185592
Change-Id: Iae6ab7787fcf8150f738cf361c545c796ce84f16

3 years agoUse ::class to resolve class names in maintenance scripts
Umherirrender [Sat, 13 Jan 2018 00:02:09 +0000 (01:02 +0100)]
Use ::class to resolve class names in maintenance scripts

This helps to find renamed or misspelled classes earlier.
Phan will check the class names

Change-Id: I1d4567f47f93eb1436cb98558388e48d35258666

3 years agoPhan: resolve and reenable PhanAccessMethodProtected
Max Semenik [Tue, 23 Jan 2018 17:31:13 +0000 (09:31 -0800)]
Phan: resolve and reenable PhanAccessMethodProtected

Change-Id: I2bd7c787012f4f54600f3289d9d0d725f87788bc

3 years agoMerge "rdbms: make LoadBalancer::waitForAll() better respect the timeout"
jenkins-bot [Tue, 23 Jan 2018 17:26:12 +0000 (17:26 +0000)]
Merge "rdbms: make LoadBalancer::waitForAll() better respect the timeout"

3 years agoMerge "Use getSize since SearchSuggestionSet does not implement Countable"
jenkins-bot [Tue, 23 Jan 2018 16:00:20 +0000 (16:00 +0000)]
Merge "Use getSize since SearchSuggestionSet does not implement Countable"

3 years agoMake Gender normalize usernames
Brian Wolff [Sun, 17 Dec 2017 22:12:06 +0000 (22:12 +0000)]
Make Gender normalize usernames

This ensures that if GENDER is fed wfEscapeWikitext()'d version
of a username, it will normalize it.

See discussion on T182800.

Note, we do not need to worry about the case of a user named
"Project:*foo" as such namespace prefixes are illegal in
usernames.

Change-Id: Ic5a8fc76c28dca43ce8e334ef1874c2673433f00

3 years agoMerge "Use MediaWiki\restoreWarnings in deprecated wfRestoreWarnings"
jenkins-bot [Mon, 22 Jan 2018 21:03:03 +0000 (21:03 +0000)]
Merge "Use MediaWiki\restoreWarnings in deprecated wfRestoreWarnings"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 22 Jan 2018 20:55:34 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I89efc6e7a8f23ef71268502cda5542338ee892fe

3 years agoMerge "Widgets: Allow titles with name of Object.prototypes"
jenkins-bot [Mon, 22 Jan 2018 20:35:26 +0000 (20:35 +0000)]
Merge "Widgets: Allow titles with name of Object.prototypes"

3 years agoMerge "mediawiki.special.upload: Use ES5 .forEach() instead of jQuery"
jenkins-bot [Mon, 22 Jan 2018 20:24:58 +0000 (20:24 +0000)]
Merge "mediawiki.special.upload: Use ES5 .forEach() instead of jQuery"

3 years agoUse getSize since SearchSuggestionSet does not implement Countable
Stanislav Malyshev [Mon, 22 Jan 2018 20:13:34 +0000 (12:13 -0800)]
Use getSize since SearchSuggestionSet does not implement Countable

Bug: T184934
Change-Id: I39459352399e2023149b715b049084826df22935

3 years agomediawiki.special.upload: Use ES5 .forEach() instead of jQuery
Fomafix [Fri, 19 Jan 2018 10:16:19 +0000 (11:16 +0100)]
mediawiki.special.upload: Use ES5 .forEach() instead of jQuery

Replace
* $.each( array, function ( index, value ) { ... } ) by
  array.forEach( function ( value ) { ... } )

Change-Id: I0574f130e93b53895e2c76363285084a6df05649

3 years agoMerge "Use native ES5 Array prototype methods instead of jQuery"
jenkins-bot [Mon, 22 Jan 2018 19:37:15 +0000 (19:37 +0000)]
Merge "Use native ES5 Array prototype methods instead of jQuery"

3 years agoMerge "Set default fragment mode to [ 'legacy', 'html5' ]"
jenkins-bot [Mon, 22 Jan 2018 19:02:35 +0000 (19:02 +0000)]
Merge "Set default fragment mode to [ 'legacy', 'html5' ]"

3 years agoUse MediaWiki\restoreWarnings in deprecated wfRestoreWarnings
WMDE-Fisch [Mon, 22 Jan 2018 17:53:09 +0000 (18:53 +0100)]
Use MediaWiki\restoreWarnings in deprecated wfRestoreWarnings

This will give devs a better hint on how to replace this.

Change-Id: I2332b6173b7816aef11841725752745e174fa69f

3 years agoFix called function case in a bunch of places
Max Semenik [Sat, 20 Jan 2018 00:44:30 +0000 (16:44 -0800)]
Fix called function case in a bunch of places

Change-Id: If1e392290a5bab3bce389f7da692e53a748b8aff

3 years agoMerge "selenium: add re-creatable page test to page spec"
jenkins-bot [Mon, 22 Jan 2018 17:04:13 +0000 (17:04 +0000)]
Merge "selenium: add re-creatable page test to page spec"

3 years agoMerge "selenium, add restoration test to page spec"
jenkins-bot [Mon, 22 Jan 2018 17:02:24 +0000 (17:02 +0000)]
Merge "selenium, add restoration test to page spec"

3 years agoMerge "selenium: add deletion test to page spec"
jenkins-bot [Mon, 22 Jan 2018 15:58:52 +0000 (15:58 +0000)]
Merge "selenium: add deletion test to page spec"

3 years agoReplace some of MaintenanceTest with dataProviders
Adam Roses Wight [Wed, 17 Jan 2018 13:33:10 +0000 (08:33 -0500)]
Replace some of MaintenanceTest with dataProviders

Bug: T184775
Change-Id: Icbaf3cbcf3c51e5b4cd53d55a5230534e74a0a38

3 years agoMerge "Refactor MaintenanceTest to use a base test case"
jenkins-bot [Mon, 22 Jan 2018 06:33:59 +0000 (06:33 +0000)]
Merge "Refactor MaintenanceTest to use a base test case"

3 years agoMerge "Begin splitting out maintenance test base classes"
jenkins-bot [Mon, 22 Jan 2018 06:31:03 +0000 (06:31 +0000)]
Merge "Begin splitting out maintenance test base classes"

3 years agoMerge "mediawiki.api.category: Use formatversion=2 and simplify code"
jenkins-bot [Mon, 22 Jan 2018 06:20:08 +0000 (06:20 +0000)]
Merge "mediawiki.api.category: Use formatversion=2 and simplify code"

3 years agoRefactor MaintenanceTest to use a base test case
Adam Roses Wight [Wed, 17 Jan 2018 13:32:00 +0000 (08:32 -0500)]
Refactor MaintenanceTest to use a base test case

Bug: T184775
Change-Id: I0cb2320f765e847a59c721918401da07a3a2b24a

3 years agoBegin splitting out maintenance test base classes
Adam Roses Wight [Tue, 16 Jan 2018 16:28:38 +0000 (11:28 -0500)]
Begin splitting out maintenance test base classes

Bug: T184775
Change-Id: I73c2f3c6975deec50cf879201cf292c217b51c51

3 years agoMerge "mediawiki.ForeignStructuredUpload: Simplify code by using ES5"
jenkins-bot [Mon, 22 Jan 2018 05:01:41 +0000 (05:01 +0000)]
Merge "mediawiki.ForeignStructuredUpload: Simplify code by using ES5"

3 years agoMerge "Use ES5 String.prototype.trim() instead of jQuery.trim()"
jenkins-bot [Mon, 22 Jan 2018 01:44:51 +0000 (01:44 +0000)]
Merge "Use ES5 String.prototype.trim() instead of jQuery.trim()"

3 years agoMerge "mediawiki.special.upload: Use mediawiki.api.parse"
jenkins-bot [Mon, 22 Jan 2018 01:37:19 +0000 (01:37 +0000)]
Merge "mediawiki.special.upload: Use mediawiki.api.parse"

3 years agoMerge "mediawiki.special.upload: Show an error message on "|""
jenkins-bot [Mon, 22 Jan 2018 01:35:34 +0000 (01:35 +0000)]
Merge "mediawiki.special.upload: Show an error message on "|""

3 years agoMerge "mediawiki.special.upload: trim nameToCheck"
jenkins-bot [Sun, 21 Jan 2018 22:19:33 +0000 (22:19 +0000)]
Merge "mediawiki.special.upload: trim nameToCheck"

3 years agowatch.js: Let api.js do the joining of the array
Fomafix [Sun, 21 Jan 2018 21:35:37 +0000 (22:35 +0100)]
watch.js: Let api.js do the joining of the array

Change-Id: Ie283ed3e071fe1a041f040e72cac061ebc3209d0

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 21 Jan 2018 20:54:05 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie8641f203a6bd289d018a571c56cda69d4a9e2bb

3 years agoUse ES5 String.prototype.trim() instead of jQuery.trim()
Fomafix [Sun, 21 Jan 2018 19:10:42 +0000 (20:10 +0100)]
Use ES5 String.prototype.trim() instead of jQuery.trim()

Replace:
* $.trim( str ) by str.trim()

Ensure that str is a string before calling str.trim().

Change-Id: I48f08fdac1e7d802813563c4691e9bbaf2c78336

3 years agomediawiki.special.upload: Show an error message on "|"
Fomafix [Sun, 21 Jan 2018 14:41:30 +0000 (15:41 +0100)]
mediawiki.special.upload: Show an error message on "|"

This change prevents that "|" is interpreted as title separator and
shows the following message when the title contains a "|" character:

  The requested page title contains invalid characters: "|".

Before this change the following message is shown on this case:

  The requested page title is empty or contains only the name of a
  namespace.

Change-Id: If67ed573ea0b5c28c59a7d90e8581c4b67528450

3 years agomediawiki.special.upload: Use mediawiki.api.parse
Fomafix [Sun, 21 Jan 2018 13:54:14 +0000 (14:54 +0100)]
mediawiki.special.upload: Use mediawiki.api.parse

This also adds the parameter contentmodel=wikitext to the API request.
This ensures that the text is always parsed as wikitext, even with a
title with a different content model like 'MediaWiki:Common.js'.

Change-Id: I29f0c76c3354a8c97b8296224e14341f71726c2f

3 years agomediawiki.ForeignStructuredUpload: Simplify code by using ES5
Fomafix [Sun, 21 Jan 2018 09:45:43 +0000 (10:45 +0100)]
mediawiki.ForeignStructuredUpload: Simplify code by using ES5

For iterating over an array replace for() by .push.apply() and .map().

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/push#Merging_two_arrays
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map

Change-Id: I0bb4ed7f71db1e60eb4d76a77c53d022bb2081d1

3 years agoMerge "Use HTTPS instead of HTTP for caniuse.com"
jenkins-bot [Sun, 21 Jan 2018 06:11:44 +0000 (06:11 +0000)]
Merge "Use HTTPS instead of HTTP for caniuse.com"

3 years agordbms: make LoadBalancer::waitForAll() better respect the timeout
Aaron Schulz [Tue, 16 Jan 2018 16:58:59 +0000 (17:58 +0100)]
rdbms: make LoadBalancer::waitForAll() better respect the timeout

If several replicas (or even all) had replication stuck, then the
timeout would happen for each server, one after another.

Change-Id: Id5431360b9cde7e5dc0115a1f41b9903003f47c4

3 years agoUpdate RunningStat use statement
Reedy [Sun, 21 Jan 2018 04:40:34 +0000 (04:40 +0000)]
Update RunningStat use statement

Bug: T182273
Change-Id: If9e946e767ca8f4c1af9b1a4855bbbffb98deff5

3 years agoUpdate WrappedString use statements
Reedy [Sun, 21 Jan 2018 04:39:17 +0000 (04:39 +0000)]
Update WrappedString use statements

Bug: T182273
Change-Id: Ia9515863491fa9c8684698fa33612eec5eb6d937

3 years agoUpdate IPSet use statements
Reedy [Sun, 21 Jan 2018 04:37:26 +0000 (04:37 +0000)]
Update IPSet use statements

Bug: T182273
Change-Id: I73fb52678dc56a542eccd209441557610b562d4b

3 years agoUpdate RelPath calls
Reedy [Sun, 21 Jan 2018 04:33:38 +0000 (04:33 +0000)]
Update RelPath calls

Bug: T182273
Change-Id: Ifd04e3b3ab72cc56bef48a1fc18fccb34b0af618

3 years agoMerge "Bypass wfGetDB when LoadBalancer is used in scope"
jenkins-bot [Sun, 21 Jan 2018 01:19:00 +0000 (01:19 +0000)]
Merge "Bypass wfGetDB when LoadBalancer is used in scope"