4 years agoAdd structure test to ensure PSR-4 autoloader covers everything
Kunal Mehta [Fri, 25 May 2018 01:55:47 +0000 (18:55 -0700)]
Add structure test to ensure PSR-4 autoloader covers everything

This ensures that there aren't any classes inside a PSR-4 autoloaded
directory that aren't being autoloaded properly.

Change-Id: I200a8535c2f47a6bf3287a7fe1182151493372f4

4 years agoMove includes/auth back to the standard classmap autoloader
Kunal Mehta [Fri, 25 May 2018 01:57:28 +0000 (18:57 -0700)]
Move includes/auth back to the standard classmap autoloader

Partially reverts c587ab1375eaf61acbd3e066ff791d096e769189.

Change-Id: Ie8cfe356b07f08d481370b9f61b1d08ed6c9c799

4 years agoMerge "EditPage: Fix duplicate classic toolbar"
jenkins-bot [Thu, 24 May 2018 23:08:23 +0000 (23:08 +0000)]
Merge "EditPage: Fix duplicate classic toolbar"

4 years agoEditPage: Fix duplicate classic toolbar
Bartosz Dziewoński [Thu, 24 May 2018 22:54:14 +0000 (00:54 +0200)]
EditPage: Fix duplicate classic toolbar

Caused by an incorrectly resolved rebase conflict
between 14cffee7c1ea7e6f411730a52aadb2458fcfb0fd
and 70941efd35562dcb7003229b56c91a98a67de7a9.

Bug: T195517
Change-Id: I294acff48fe9b1a1a9384d717f09d90e417204ab

4 years agoInsert space before compatibility link in PHP version message
petarpetkovic [Thu, 24 May 2018 22:27:21 +0000 (00:27 +0200)]
Insert space before compatibility link in PHP version message

Change-Id: Ia056ba7f9eddbcf31082c7b2f7a64e7dbf02cba4

4 years agoMerge "Add unicode mapping for ICU 60 and 61"
jenkins-bot [Thu, 24 May 2018 21:46:32 +0000 (21:46 +0000)]
Merge "Add unicode mapping for ICU 60 and 61"

4 years agoAdd unicode mapping for ICU 60 and 61
Reedy [Thu, 24 May 2018 21:28:19 +0000 (22:28 +0100)]
Add unicode mapping for ICU 60 and 61

Change-Id: Ifbbc8d7ecc788bc2c6b07a8ebba46a9648545786

4 years agoIcuCollation: Deprecate getICUVersion(), no need for PHP53 back-compat
James D. Forrester [Thu, 24 May 2018 20:11:11 +0000 (13:11 -0700)]
IcuCollation: Deprecate getICUVersion(), no need for PHP53 back-compat

Change-Id: If8dfdaf187b32b7b9a2c09a240416b9f481593f1

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 24 May 2018 19:53:30 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie807be662d077fe0e177e82834d70581210a5f3e

4 years agoMerge "mw.page.gallery: Prevent jumpiness due to viewport height changes"
jenkins-bot [Thu, 24 May 2018 19:17:44 +0000 (19:17 +0000)]
Merge "mw.page.gallery: Prevent jumpiness due to viewport height changes"

4 years agomw.page.gallery: Prevent jumpiness due to viewport height changes
Bartosz Dziewoński [Tue, 8 May 2018 19:12:00 +0000 (21:12 +0200)]
mw.page.gallery: Prevent jumpiness due to viewport height changes

* Do not recalculate if only viewport height has changed, but not
  width. Viewport height doesn't affect this at all.
* Set a min-height on the gallery element before resetting image
  dimensions so that content following it only reflows once, when
  we calculate dimensions again.

Bug: T194193
Change-Id: I6362863cc0f3f7b76c9ec7437d37ff6762ecf153

4 years agoMerge "Switch includes/{auth,edit,editpage} to use the PSR-4 autoloader"
jenkins-bot [Thu, 24 May 2018 17:00:16 +0000 (17:00 +0000)]
Merge "Switch includes/{auth,edit,editpage} to use the PSR-4 autoloader"

4 years agoMerge "Re-enable MediaWiki.Files.ClassMatchesFilename sniffs"
jenkins-bot [Thu, 24 May 2018 17:00:13 +0000 (17:00 +0000)]
Merge "Re-enable MediaWiki.Files.ClassMatchesFilename sniffs"

4 years agoMerge "Have class match filename in some maintenance scripts"
jenkins-bot [Thu, 24 May 2018 16:49:18 +0000 (16:49 +0000)]
Merge "Have class match filename in some maintenance scripts"

4 years agoBump PHP version requirement to 7.0.0+
James D. Forrester [Thu, 18 Jan 2018 23:34:32 +0000 (15:34 -0800)]
Bump PHP version requirement to 7.0.0+

Bug: T172165
Change-Id: I740f32ac859d9bb3787fdf8414f82ae6f410492f

4 years agoDrop $wgStyleVersion, deprecated in 1.31 and now unused
James D. Forrester [Wed, 23 May 2018 22:00:46 +0000 (15:00 -0700)]
Drop $wgStyleVersion, deprecated in 1.31 and now unused

Bug: T181318
Change-Id: Ib988f3118786debda135d6ad3d27deda5a51fc8a

4 years agoMerge "Skin: Drop appending of wgStyleVersion in getSkinStylePath()"
jenkins-bot [Thu, 24 May 2018 14:05:28 +0000 (14:05 +0000)]
Merge "Skin: Drop appending of wgStyleVersion in getSkinStylePath()"

4 years agoMerge "resourceloader: Move style deprecation warnings to <body>"
jenkins-bot [Thu, 24 May 2018 13:03:21 +0000 (13:03 +0000)]
Merge "resourceloader: Move style deprecation warnings to <body>"

4 years agoRemove mentions of jquery.mw-jump in code comments
Timo Tijhof [Thu, 24 May 2018 12:35:50 +0000 (13:35 +0100)]
Remove mentions of jquery.mw-jump in code comments

The idea of listening for an event and doing something, with on('focus'),
is rather trivial and not worth attributing to another module, in particular
when that module is being phased out :)

Bug: T195256
Change-Id: Ic6a65254cbcc5e9503fece1afb7861a706713d77

4 years agoMerge "Add ability to filter based on rc_title in API"
jenkins-bot [Thu, 24 May 2018 10:13:06 +0000 (10:13 +0000)]
Merge "Add ability to filter based on rc_title in API"

4 years agoSwitch includes/{auth,edit,editpage} to use the PSR-4 autoloader
Kunal Mehta [Thu, 24 May 2018 01:24:05 +0000 (18:24 -0700)]
Switch includes/{auth,edit,editpage} to use the PSR-4 autoloader

Change-Id: I9210d26c1031d69f6691fef038cc2db6f391b70e

4 years agoRe-enable MediaWiki.Files.ClassMatchesFilename sniffs
Kunal Mehta [Thu, 24 May 2018 02:23:49 +0000 (19:23 -0700)]
Re-enable MediaWiki.Files.ClassMatchesFilename sniffs

Change-Id: I63f54b0336168a50aef72e38202e153677eafd3c

4 years agoHave class match filename in some maintenance scripts
Kunal Mehta [Thu, 24 May 2018 01:34:01 +0000 (18:34 -0700)]
Have class match filename in some maintenance scripts

Each of these scripts had a class name that was not referenced outside
of the script file itself, and are safe to rename as a result.

Change-Id: Id605aca11db51ee433baeaa998a0e33184c930ca

4 years agoMerge "Update wikimedia/wrappedstring to v3.0.0"
jenkins-bot [Thu, 24 May 2018 02:14:00 +0000 (02:14 +0000)]
Merge "Update wikimedia/wrappedstring to v3.0.0"

4 years agoMerge "IP: Fix sanitization of IPv4 ranges"
jenkins-bot [Thu, 24 May 2018 00:31:31 +0000 (00:31 +0000)]
Merge "IP: Fix sanitization of IPv4 ranges"

4 years agoMerge "Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag errors"
jenkins-bot [Thu, 24 May 2018 00:27:01 +0000 (00:27 +0000)]
Merge "Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag errors"

4 years agoMerge "RELEASE-NOTES-1.32: Line wrap to 80 chars"
jenkins-bot [Thu, 24 May 2018 00:08:04 +0000 (00:08 +0000)]
Merge "RELEASE-NOTES-1.32: Line wrap to 80 chars"

4 years agoSkin: Drop appending of wgStyleVersion in getSkinStylePath()
James D. Forrester [Wed, 23 May 2018 21:56:13 +0000 (14:56 -0700)]
Skin: Drop appending of wgStyleVersion in getSkinStylePath()

This setting is deprecated.

Bug: T181318
Change-Id: I9e56764e37b5f10ce1bddfb7826c18982fb1ebb2

4 years agoMerge "Enable deleteAutoPatrolLogs to delete pre-2011 autopatrol logs as well"
jenkins-bot [Wed, 23 May 2018 23:48:44 +0000 (23:48 +0000)]
Merge "Enable deleteAutoPatrolLogs to delete pre-2011 autopatrol logs as well"

4 years agoRELEASE-NOTES-1.32: Line wrap to 80 chars
James D. Forrester [Wed, 23 May 2018 21:59:52 +0000 (14:59 -0700)]
RELEASE-NOTES-1.32: Line wrap to 80 chars

Change-Id: I673efe2777da17bd44788ee8a11707e040242176

4 years agoFix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag errors
Kunal Mehta [Wed, 23 May 2018 23:23:42 +0000 (16:23 -0700)]
Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag errors

Change-Id: I936c3f5fca1a0061f215e80469f5d882cb32ee29

4 years agoEnable deleteAutoPatrolLogs to delete pre-2011 autopatrol logs as well
Amir Sarabadani [Fri, 18 May 2018 13:46:47 +0000 (15:46 +0200)]
Enable deleteAutoPatrolLogs to delete pre-2011 autopatrol logs as well

Bug: T184485
Change-Id: I3f123ea0ae69f80beec7425be0f3e4c00a409c0d

4 years agoUpdate wikimedia/wrappedstring to v3.0.0
Timo Tijhof [Wed, 23 May 2018 22:00:45 +0000 (23:00 +0100)]
Update wikimedia/wrappedstring to v3.0.0

Notable changes:
- Remove back compat layer for WrappedString\ -> Wikimedia\.
- Improve merging of nested lists.

Depends-On: I89c015e638fe3e77ef12b88948d3cfa007afa7b0
Change-Id: I10cc2ed66e1d78a77fec7ffeafc75962f7d73090

4 years agobuild: Updating mediawiki/mediawiki-codesniffer to 18.0.0
libraryupgrader [Sat, 14 Apr 2018 10:27:27 +0000 (10:27 +0000)]
build: Updating mediawiki/mediawiki-codesniffer to 18.0.0

Change-Id: Id39e8dcf22262d1b3c57628467163a995fe4053b

4 years agoMerge "WatchAction::onSubmit return correct value, not always true"
jenkins-bot [Wed, 23 May 2018 21:48:14 +0000 (21:48 +0000)]
Merge "WatchAction::onSubmit return correct value, not always true"

4 years agoMerge "Setup: Remove various Profile sections"
jenkins-bot [Wed, 23 May 2018 21:39:39 +0000 (21:39 +0000)]
Merge "Setup: Remove various Profile sections"

4 years agoMerge "Update 'OpenSearchDescription' links"
jenkins-bot [Wed, 23 May 2018 21:38:28 +0000 (21:38 +0000)]
Merge "Update 'OpenSearchDescription' links"

4 years agoMerge "Add 'Special:MyLanguage' in Short URL link"
jenkins-bot [Wed, 23 May 2018 21:36:01 +0000 (21:36 +0000)]
Merge "Add 'Special:MyLanguage' in Short URL link"

4 years agoMerge "OutputPage: Remove appending of wgStyleVersion to legacy resources"
jenkins-bot [Wed, 23 May 2018 21:34:07 +0000 (21:34 +0000)]
Merge "OutputPage: Remove appending of wgStyleVersion to legacy resources"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 23 May 2018 20:00:37 +0000 (22:00 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I12af86ca297eae5af2e7c74fce0d198e6c473827

4 years agoOutputPage: Remove appending of wgStyleVersion to legacy resources
Timo Tijhof [Mon, 21 May 2018 21:21:28 +0000 (22:21 +0100)]
OutputPage: Remove appending of wgStyleVersion to legacy resources

For addScriptFile(), just remove the appending of wgStyleVersion.
Going forward, anyone still using this, should simply append a query
parameter themselves in a way that is specific to that one url
(instead of relying on a generic global variable). Alternatively, one
could use OutputPage::transformResourcePath if the file is in /w/.

For addStyles(), also remove the appending of wgStyleVersion. Since this
method takes paths relative to /w/skins, we can easily update this to
automatically use transformResourcePath(), so that file-hash based query
parameters are automatically added.

Test Plan:
* Add calls to top of OutputPage::output():
  `$this->addStyle( 'Vector/README.md' );`
  `$this->addScriptFile( "{$GLOBALS['wgScriptPath']}/composer.json" );`
* Before, they are both inserted as `<link>` (head) and `<script>` (body)
  with a query parameter based on wgStyleVersion.
* After, the `<script>` (end of body) has no query.
  After, the stylesheet (head) has a SHA1 content hash as query.

Bug: T181318
Change-Id: Ie5ab5066ef7d07279086bde838d7305e9e4eabaf

4 years agoWatchAction::onSubmit return correct value, not always true
Florian Schmidt [Fri, 18 May 2018 20:08:09 +0000 (22:08 +0200)]
WatchAction::onSubmit return correct value, not always true

The onSubmit method documentation states, that the caller can expect either
true for a successfull run, false if not tried and an array of error messages
in case of an failure. WatchAction however always returned false, even though
a Status object is availble with all needed information.

The behaviour of WatchAction::onSubmit is now changed to return the appropriate
value taken from the returned Status object of WatchAction::doSelf.

 * Added WatchAction test class to higher test coverage, especially for the
   static methods
 * Marked getUnwatchToken as deprecated, it's not used and a caller can easily
   switch to getWatchToken with "unwatch" as the action parameter

Change-Id: I2c1b91e1884a0d5f27f5e7ab9eafd6173642c21c

4 years agoMerge "Translate ApiHelp, ApiSandbox and Autoblocklist to Spanish"
jenkins-bot [Wed, 23 May 2018 18:15:40 +0000 (18:15 +0000)]
Merge "Translate ApiHelp, ApiSandbox and Autoblocklist to Spanish"

4 years agoMerge "resourceloader: Remove 'user.styles' dependency from 'user' module"
jenkins-bot [Wed, 23 May 2018 18:04:39 +0000 (18:04 +0000)]
Merge "resourceloader: Remove 'user.styles' dependency from 'user' module"

4 years agoMerge "OutputPage: Remove support for non-existent /w/skins/common directory"
jenkins-bot [Wed, 23 May 2018 18:01:11 +0000 (18:01 +0000)]
Merge "OutputPage: Remove support for non-existent /w/skins/common directory"

4 years agoMerge "Remove the unused 'jquery.farbtastic' module"
jenkins-bot [Wed, 23 May 2018 17:41:24 +0000 (17:41 +0000)]
Merge "Remove the unused 'jquery.farbtastic' module"

4 years agoMerge "Convert content.externallinks.css to less"
jenkins-bot [Wed, 23 May 2018 17:01:55 +0000 (17:01 +0000)]
Merge "Convert content.externallinks.css to less"

4 years agoRemove the unused 'jquery.farbtastic' module
Timo Tijhof [Wed, 23 May 2018 16:28:23 +0000 (17:28 +0100)]
Remove the unused 'jquery.farbtastic' module

This was added in (r99923; 4d8c7e96ed1f) while reviewing the
'gadget-preferences' branch in SVN of the Gadgets extension during
development of MediaWiki 1.18, intended for use in a color picker
on Special:Gadgets as part of an experimental feature that was
never completed (r94051).

The module has no usage anywhere in Wikimedia Git, nor in any
third-party hosted repos indexed by MediaWiki Codesearch, nor
anywhere on-wiki at WMF in site scripts (per mwgrep).

Bug: T193826
Bug: T192623
Change-Id: I8ed6c09dc7efd750ad4688b895b2e3f808a0e52b

4 years agoMerge "resourceloader: Remove mwLoadEnd code (moved to Navigation Timing)"
jenkins-bot [Wed, 23 May 2018 16:03:49 +0000 (16:03 +0000)]
Merge "resourceloader: Remove mwLoadEnd code (moved to Navigation Timing)"

4 years agoMerge "Translate special pages into Gorontalo"
jenkins-bot [Wed, 23 May 2018 15:58:38 +0000 (15:58 +0000)]
Merge "Translate special pages into Gorontalo"

4 years agoMerge "Crimean Tatar/crh transliteration odds and ends"
jenkins-bot [Wed, 23 May 2018 15:58:33 +0000 (15:58 +0000)]
Merge "Crimean Tatar/crh transliteration odds and ends"

4 years agoTranslate special pages into Gorontalo
Martin Urbanec [Wed, 25 Apr 2018 13:05:14 +0000 (15:05 +0200)]
Translate special pages into Gorontalo

Bug: T189128
Change-Id: Icb3685f4115c63fb5b50ce5429f564481d2cdfd6

4 years agoTranslate ApiHelp, ApiSandbox and Autoblocklist to Spanish
MarcoAurelio [Wed, 23 May 2018 15:07:31 +0000 (15:07 +0000)]
Translate ApiHelp, ApiSandbox and Autoblocklist to Spanish

Change-Id: Ie8cab864112cde17a5f5ced7645fff25c558abdf

4 years agoTranslate PasswordPolicies to Spanish
MarcoAurelio [Wed, 23 May 2018 14:55:01 +0000 (16:55 +0200)]
Translate PasswordPolicies to Spanish

New message added in Ifb4876f7

Change-Id: I621f81c023c4c1af4e33a4784ff7e1aca08df182

4 years agoresourceloader: Remove 'user.styles' dependency from 'user' module
Timo Tijhof [Wed, 23 May 2018 14:53:33 +0000 (15:53 +0100)]
resourceloader: Remove 'user.styles' dependency from 'user' module

Follows-up c3f200849b99721, which made isKnownEmpty() return false
for modules that have dependencies.

This had the side-effect of causing the 'user' module to be loaded
in its own HTTP request on all page views, even for logged-out users
and for registered users without scripts, because it has a dependency
on the 'user.styles' module.

This commit fixes that regression by removing the dependency so
that the 'user' module can, once again, be considered "empty".

The dependency isn't needed. It was only added for the transitional
period after the 'user' module was split up so that existing cached
views for logged-in users (in theory, e.g. 304 Not Modified) would
still trigger a load for the styles.

But that transition ended over a year ago. Now, both modules act
independently and are always queued separately, with user.styles
explicitly added as a style module (as it should be).

Even for the case of an AJAX preview (if it is somehow possible for
the 'user' module to not be loaded already), the API would respond
with a module list that contains both 'user' and 'user.styles'.

Bug: T195380
Change-Id: I9852516af1bd55c84a9213628c7796e2c2168745

4 years agoresourceloader: Remove mwLoadEnd code (moved to Navigation Timing)
Timo Tijhof [Tue, 22 May 2018 23:28:36 +0000 (00:28 +0100)]
resourceloader: Remove mwLoadEnd code (moved to Navigation Timing)

This internal hook was primarily added for the Navigation Timing
extension. As part of T192623, this should be removed from mediawiki.js

* It is not used in anyway by core.
* It should not be used by anything other than Navigation Timing.
* It depends heavily on jQuery, which we don't want for mediawiki.js.

Bug: T192623
Depends-On: I011c9d1beebe6fa8d21ab9260da0a817ff7aa5f0
Change-Id: I0bf60d37ebea96f2a22044f9db221c87dd88521c

4 years agoIP: Fix sanitization of IPv4 ranges
Brad Jorsch [Tue, 22 May 2018 21:12:30 +0000 (17:12 -0400)]
IP: Fix sanitization of IPv4 ranges

'' should sanitize to '', not

Change-Id: I9364cb268dcc9b9b24aa1c627a87482978c4cf34

4 years agoMerge "Only load PEAR Smtp mailer from vendor/composer, not from `pear` itself"
jenkins-bot [Wed, 23 May 2018 14:15:37 +0000 (14:15 +0000)]
Merge "Only load PEAR Smtp mailer from vendor/composer, not from `pear` itself"

4 years agoOnly load PEAR Smtp mailer from vendor/composer, not from `pear` itself
Chad Horohoe [Fri, 18 May 2018 01:56:00 +0000 (18:56 -0700)]
Only load PEAR Smtp mailer from vendor/composer, not from `pear` itself

Change-Id: I91c42a3eafd079039ddbc17a11ad3c7b6579e3c1

4 years agoMerge "ContentSecurityPolicy: Add trailing & to report urls"
jenkins-bot [Wed, 23 May 2018 11:22:12 +0000 (11:22 +0000)]
Merge "ContentSecurityPolicy: Add trailing & to report urls"

4 years agoConvert content.externallinks.css to less
Ed Sanders [Tue, 22 May 2018 20:01:59 +0000 (21:01 +0100)]
Convert content.externallinks.css to less

As suggested in the comment, since the blocking
bug was fixed 3.5 years ago.

Change-Id: I345f81ca5b9672c34525d223f01844df0a74f617

4 years agoMerge "PageDataRequestHandler: Use getHeader() instead of getAllHeaders()"
jenkins-bot [Wed, 23 May 2018 06:21:13 +0000 (06:21 +0000)]
Merge "PageDataRequestHandler: Use getHeader() instead of getAllHeaders()"

4 years agoPageDataRequestHandler: Use getHeader() instead of getAllHeaders()
Fomafix [Fri, 23 Feb 2018 08:58:11 +0000 (09:58 +0100)]
PageDataRequestHandler: Use getHeader() instead of getAllHeaders()

WebRequest has already the function getHeader to extract the requested
HTTP header.

Change-Id: Ifb63ce2ca8851cddf7e5e249509d60fd3620c3e7

4 years agoAvoid sorting the language array twice
Fomafix [Thu, 22 Feb 2018 21:09:04 +0000 (22:09 +0100)]
Avoid sorting the language array twice

Language::fetchLanguageNames returns already a sorted array. An
additional ksort is only needed when inserting a new value.

Change-Id: If8c7b16fa6e7dfe1545f72ac9c742a2f43eaee57

4 years agoMerge "installer: Do not wrongly hide namespace input field"
jenkins-bot [Wed, 23 May 2018 05:26:05 +0000 (05:26 +0000)]
Merge "installer: Do not wrongly hide namespace input field"

4 years agoMerge "Remove deprecated mediawiki.widgets.visibleByteLimit alias"
jenkins-bot [Wed, 23 May 2018 02:50:33 +0000 (02:50 +0000)]
Merge "Remove deprecated mediawiki.widgets.visibleByteLimit alias"

4 years agoMerge "Remove deprecated 'es5-shim' module"
jenkins-bot [Wed, 23 May 2018 02:43:17 +0000 (02:43 +0000)]
Merge "Remove deprecated 'es5-shim' module"

4 years agoMerge "mediawiki.debug: Move internal footHovzer to the same module"
jenkins-bot [Wed, 23 May 2018 02:43:13 +0000 (02:43 +0000)]
Merge "mediawiki.debug: Move internal footHovzer to the same module"

4 years agoMerge "API: Raise an error when too many values are passed"
jenkins-bot [Wed, 23 May 2018 02:20:38 +0000 (02:20 +0000)]
Merge "API: Raise an error when too many values are passed"

4 years agoRemove deprecated mediawiki.widgets.visibleByteLimit alias
Timo Tijhof [Mon, 21 May 2018 18:48:55 +0000 (19:48 +0100)]
Remove deprecated mediawiki.widgets.visibleByteLimit alias

Follows-up 777336288bc807a, which renamed the module in 1.31.
It was only used in a few places, which have been updated except
for MassMessage, which is updated with Id7612859dfba.

Depends-On: Id7612859dfbace9052f62df1c07595f85a75515b
Change-Id: I475fe6fef5b863b44895c201217a82ee18a020c6

4 years agoRemove deprecated 'es5-shim' module
Timo Tijhof [Sun, 20 May 2018 14:15:40 +0000 (16:15 +0200)]
Remove deprecated 'es5-shim' module

This is an empty placeholder module that does nothing, for
backwards compatibility with older extensions that were still
supporting MediaWiki versions from a time where ES3 was the
requirement and ES5 was shimmed. There is no longer any use
of 'es5-shim' anywhere in Wikimedia Git, nor on-wiki.

Bug: T192623
Change-Id: I143b89d3658ab83b98a1f201dd1f67a2d506fb09

4 years agomediawiki.debug: Move internal footHovzer to the same module
Timo Tijhof [Sun, 20 May 2018 13:25:40 +0000 (15:25 +0200)]
mediawiki.debug: Move internal footHovzer to the same module

This is an internal dev utility used by mediawiki.debug, not
used anywhere else, and probably wouldn't be supported even if
it was re-used somewhere, given it's custom made for mwdebug.

Bug: T192623
Change-Id: I086f7a1d06ab33d9dd9fc29fff27ddcdeb9a304b

4 years agoMake RCCacheEntry use the local part of the user name for linking
Amir Sarabadani [Tue, 24 Apr 2018 18:52:04 +0000 (20:52 +0200)]
Make RCCacheEntry use the local part of the user name for linking

Bug: T190530
Change-Id: Ib9e555c65fbe9befdb8413e6fbc3b3a53614bad8

4 years agoSetup: Remove various Profile sections
Timo Tijhof [Tue, 22 May 2018 13:35:21 +0000 (14:35 +0100)]
Setup: Remove various Profile sections

- Setup.php
- - Setup.php-defaults
- - Setup.php-validation
- - Setup.php-defaults2
- - Setup.php-misc1
- - Setup.php-memcached
- - Setup.php-globals
- - - Setup.php-session
- - Setup.php-extensions
- - - Setup.php-extensions-{extensionName}
- - - Setup.php-autocreate

- Setup.php
- - Setup.php-defaults
- - Setup.php-defaults2
- - Setup.php-misc
- - Setup.php-globals
- - Setup.php-extensions

The removed sections are mainly things were essentially sections
consisting of one invocation, which profilers already track

Bug: T189966
Change-Id: I1ed648cdcca9e5a9ea7013394381eacd67f327a3

4 years agoContentSecurityPolicy: Add trailing & to report urls
Brian Wolff [Sat, 19 May 2018 09:30:17 +0000 (09:30 +0000)]
ContentSecurityPolicy: Add trailing & to report urls

This works around a bug in HHVM, where it treats post body as part of
request parameters, even if content-type is application/json.

See https://github.com/facebook/hhvm/issues/6676.

Change-Id: Id54d6657056dee56fc71100dedfb3b53d512eaba

4 years agoresourceloader: Move style deprecation warnings to <body>
Timo Tijhof [Tue, 22 May 2018 17:58:04 +0000 (18:58 +0100)]
resourceloader: Move style deprecation warnings to <body>

Follows-up If35a106c7. These log messages are not criticial and
should not be in the <head> competing with stylesheets and article
content. Move them to the end of <body> instead, nearby other
low-priority script tags.

The getBodyHtml() method from ClientHtml was empty, but has been
non-empty in the past. It's fine to repopulate.

Also, while ClientHtml::getBodyHtml was empty, there are additional
RLQ scripts created by OutputPage that do exist even without this.
Namely, there is a <script> for wgPageParseReport, and one for
wgBackendResponseTime etc.

Change-Id: Ibda7091bdcd5ed207395b20196cdc33df926a24c

4 years agojquery.tablesorter: Allow this module to load on mobile
jdlrobson [Mon, 7 May 2018 20:46:41 +0000 (13:46 -0700)]
jquery.tablesorter: Allow this module to load on mobile

If any special pages are loading this code, let it load.
Skins can disable this code if necessary (see Minerva for example)
In T111565 we will look to enabling this on the Minerva skin.

Bug: T111565
Change-Id: I837c16bdad7769f5cb4ce0bcfadb380b34c48bd4

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 22 May 2018 19:59:31 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I01cfc16ecfe218fde89387a6d77333c0ed03dce8

4 years agoCrimean Tatar/crh transliteration odds and ends
tjones [Fri, 4 May 2018 15:34:32 +0000 (11:34 -0400)]
Crimean Tatar/crh transliteration odds and ends

* refactor '\b' into WB const to make it easy to update in the future
* add new ц-related exceptions

Bug: T193764
Change-Id: Ib707136f8f2598d1f8ec995bf129b436dfb53cd9

4 years agoMerge "Minor fixes to CRH language conversion."
jenkins-bot [Tue, 22 May 2018 18:47:13 +0000 (18:47 +0000)]
Merge "Minor fixes to CRH language conversion."

4 years agoMerge "mediawiki.page.gallery: Improve documentation"
jenkins-bot [Tue, 22 May 2018 18:18:41 +0000 (18:18 +0000)]
Merge "mediawiki.page.gallery: Improve documentation"

4 years agomediawiki.page.gallery: Improve documentation
Timo Tijhof [Mon, 21 May 2018 16:52:13 +0000 (17:52 +0100)]
mediawiki.page.gallery: Improve documentation

This file does a lot of things, but the header starts with
explaining a random/obscure thing it does with 4 lines of code
at the end of this large file.

Move that explanation near that actual code. Presumably it was
placed at the top because it used to be the only thing the
file was responsible for.

Change-Id: I75299a25dd8f5f4d4ab4cdc8fc90d74e6a74422c

4 years agoOutputPage: Remove support for non-existent /w/skins/common directory
Timo Tijhof [Mon, 21 May 2018 21:08:02 +0000 (22:08 +0100)]
OutputPage: Remove support for non-existent /w/skins/common directory

Test Plan:
* Add calls `$this->addScriptFile( 'example.js' )` and
  `$this->addScriptFile( '/example.js' )` to top of OutputPage::output().
* Without this change, two `<script>` are added.
* With this change, only for the latter a script is added,
  and the former triggers a deprecation warning.

Bug: T71277
Bug: T181318
Change-Id: I0576ef09fafa4ba34d52d75f4211fcfa28f4f3b0

4 years agoReplace HTTP by HTTPS
Fomafix [Sat, 2 Dec 2017 20:38:29 +0000 (21:38 +0100)]
Replace HTTP by HTTPS

* https://www.unicode.org/ instead of http://www.unicode.org/ or
* https://secure.php.net/ instead of http://www.php.net/ or
* https://hhvm.com/ instead of http://hhvm.com/
* https://www.iis.net/ instead of http://www.iis.net/

Change-Id: I84d818a7e0ced5ffb9485ec89a75efb28a77c1e0

4 years agoMerge "Job: Remove insert() and batchInsert(), deprecated since 1.21"
jenkins-bot [Tue, 22 May 2018 03:37:41 +0000 (03:37 +0000)]
Merge "Job: Remove insert() and batchInsert(), deprecated since 1.21"

4 years agoAPI: Raise an error when too many values are passed
Brad Jorsch [Fri, 18 May 2018 15:22:44 +0000 (17:22 +0200)]
API: Raise an error when too many values are passed

Since 2008 the API has truncated with a warning when too many values are
passed to a multi-valued parameter. It's long past time to make this an

Bug: T41936
Change-Id: I0f9efbdf9230373fa0c175a7fcacbca68225cf40

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 21 May 2018 19:53:48 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I2961ab68c20aadbbb601bb8191e06764be9ec443

4 years agoMerge "registration: Validate AutoloadNamespaces keys have trailing \"
jenkins-bot [Mon, 21 May 2018 19:28:51 +0000 (19:28 +0000)]
Merge "registration: Validate AutoloadNamespaces keys have trailing \"

4 years agoMerge "Use LinkRenderer instead of deprecated Linker in LogPage"
jenkins-bot [Mon, 21 May 2018 19:23:53 +0000 (19:23 +0000)]
Merge "Use LinkRenderer instead of deprecated Linker in LogPage"

4 years agoJob: Remove insert() and batchInsert(), deprecated since 1.21
James D. Forrester [Sun, 20 May 2018 12:10:20 +0000 (14:10 +0200)]
Job: Remove insert() and batchInsert(), deprecated since 1.21

Bug: T179624
Change-Id: I0d78a926c8c513fd652a424e8a51ded20e524a4a

4 years agoAdd support for Tachawit (Latin script) (shy-latn)
MarcoAurelio [Mon, 7 May 2018 16:02:41 +0000 (18:02 +0200)]
Add support for Tachawit (Latin script) (shy-latn)

Bug: T194047
Change-Id: If02515754857c224579519b94fe6fea27e1bd08f

4 years agoUse LinkRenderer instead of deprecated Linker in LogPage
Kunal Mehta [Sun, 20 May 2018 21:05:00 +0000 (14:05 -0700)]
Use LinkRenderer instead of deprecated Linker in LogPage

Change-Id: Ia31706cbbffd1d03916b6c087cc3a6b218e83fe6

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 20 May 2018 20:08:02 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I0eb6cee336672321dd707f0fa84825f686fe65db

4 years agoregistration: Validate AutoloadNamespaces keys have trailing \
Kunal Mehta [Sun, 20 May 2018 19:13:05 +0000 (12:13 -0700)]
registration: Validate AutoloadNamespaces keys have trailing \

The PSR-4 autoloader requires "AutoloadNamespaces" keys to have a
trailing \ (\\ in JSON), so add a validation check for that.

Unfortunately the validation error isn't great, since it checks to see
if the property matches patternProperties, and when it doesn't, it
claims the property isn't defined since additionalProperties is false.
But it's still better than not failing when they are missing.

Bug: T189136
Change-Id: If01bd06cdd767fb704a8ff85cdf1c143e53fa4ca

4 years agoMerge "Don't require trailing slash in PSR-4 autoloader directory"
jenkins-bot [Sun, 20 May 2018 18:52:31 +0000 (18:52 +0000)]
Merge "Don't require trailing slash in PSR-4 autoloader directory"

4 years agoDon't require trailing slash in PSR-4 autoloader directory
Mark A. Hershberger [Sun, 20 May 2018 14:51:34 +0000 (10:51 -0400)]
Don't require trailing slash in PSR-4 autoloader directory

This avoids the confusing error “Fatal error: Uncaught
InvalidArgumentException” or similar.

Bug: T195211
Change-Id: Ifda59a26f8bd968a2d0acbdb157d81dc0bf6aab4

4 years agoMerge "API: Use User::getCanonicalName() when validating user names"
jenkins-bot [Sun, 20 May 2018 17:46:13 +0000 (17:46 +0000)]
Merge "API: Use User::getCanonicalName() when validating user names"

4 years agomediawiki.api: Merge modules into one
Timo Tijhof [Sun, 20 May 2018 13:39:47 +0000 (15:39 +0200)]
mediawiki.api: Merge modules into one

These are all quite tiny and not worth providing separately
to the system as deliverable file bundles.

Mark the other mediawiki.api.* modules as alias to 'mediawiki.api'
for back-compat, with deprecation warning.


* Change mediawiki.api.edit.js to not use mw.user, because that
  causes a circular dependency, given mw.user also depends on

Bug: T192623
Change-Id: I0afdc8ab50bc1354bb5099bf39923c07eab0b665

4 years agoMerge "filebackend: Fix undefined 'req_params' context in FileOperation log"
jenkins-bot [Sun, 20 May 2018 08:55:03 +0000 (08:55 +0000)]
Merge "filebackend: Fix undefined 'req_params' context in FileOperation log"

4 years agoMerge "resourceloader: Add test case for ResourceLoader::getLessCompiler"
jenkins-bot [Sun, 20 May 2018 08:50:48 +0000 (08:50 +0000)]
Merge "resourceloader: Add test case for ResourceLoader::getLessCompiler"