4 years agoDeprecate PasswordPolicyChecks::checkPopularPasswordBlacklist
Reedy [Thu, 27 Dec 2018 20:19:35 +0000 (20:19 +0000)]
Deprecate PasswordPolicyChecks::checkPopularPasswordBlacklist

Change-Id: I4c90e361b7538efeb0c5efa7ca61aed2e468591c

4 years agoSimplify default password policy
Gergő Tisza [Thu, 20 Dec 2018 22:51:14 +0000 (14:51 -0800)]
Simplify default password policy

* Remove PasswordNotInLargeBlacklist => false, it's a no-op
* Deduplicate PasswordCannotMatchUsername
* Remove PasswordCannotBePopular. There is no point in using both
  PasswordCannotBePopular (top 10K passwords from SecLists) and
  PasswordNotInLargeBlacklist (top 100K passwords from SecLists),
  and the CDB lookup is probably not that cheap.

Change-Id: I868846931988b88f06800e42861e82e2bb0bc427

4 years agoCorrect $magicWords for sa.wiki
Jayprakash12345 [Sat, 30 Jun 2018 13:20:44 +0000 (18:50 +0530)]
Correct $magicWords for sa.wiki

Bug: T102320
Change-Id: I4ef78dc7a41916a9af6aa259de455e3948662913

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 27 Dec 2018 08:16:39 +0000 (09:16 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: If00b12af3d4346114260c9e4312bcab489e9a622

4 years agoFix comments in language class tests
Fomafix [Tue, 25 Dec 2018 13:35:21 +0000 (14:35 +0100)]
Fix comments in language class tests

* Add `@covers LanguageGa`.
* Language code `bs` is for "Bosnian (bosanski)" and not for "Croatian

Change-Id: I605bdd254518dd708343e36a2dee65dd0aa17b63

4 years agoFix typo "maintainance"
MarcoAurelio [Mon, 24 Dec 2018 14:51:11 +0000 (15:51 +0100)]
Fix typo "maintainance"

Bug: T201491
Change-Id: I8724206404a461eaace3b60f91c7704bd6581ee2

4 years agoMerge "Update OOUI to v0.30.0"
jenkins-bot [Mon, 24 Dec 2018 01:51:37 +0000 (01:51 +0000)]
Merge "Update OOUI to v0.30.0"

4 years agoMerge "Add 'suppressrevision' right to new 'oversight' grant"
jenkins-bot [Sun, 23 Dec 2018 23:47:10 +0000 (23:47 +0000)]
Merge "Add 'suppressrevision' right to new 'oversight' grant"

4 years agoAdd 'suppressrevision' right to new 'oversight' grant
Martin Urbanec [Sat, 29 Sep 2018 18:40:33 +0000 (20:40 +0200)]
Add 'suppressrevision' right to new 'oversight' grant

Change-Id: Ic7eeff94ea533670c85c9e82801f38fded9e7a30

4 years agoUpdate OOUI to v0.30.0
James D. Forrester [Sat, 22 Dec 2018 11:36:59 +0000 (11:36 +0000)]
Update OOUI to v0.30.0

Release notes:

Bug: T150071
Bug: T150781
Bug: T183271
Bug: T190581
Bug: T196208
Bug: T208644
Bug: T208821
Bug: T210039
Bug: T210914
Bug: T211154
Bug: T211223
Bug: T212064
Bug: T212068
Bug: T212159
Bug: T212186
Bug: T212299
Bug: T212389
Depends-On: I00d3fa932de968019c6ad676237ed5e5077fb961
Change-Id: I00d3fa932de968019c6ad676237ed5e5077fb962

4 years agoeval.php: write error messages to stderr
Mukunda Modell [Fri, 19 Oct 2018 18:45:54 +0000 (13:45 -0500)]
eval.php: write error messages to stderr

Error messages should go to stderr not stdout.

Bug: T121597
Change-Id: Ibde26059982d1e621a104694343682a2032ac844

4 years agoMerge "XmlSelect: Fix PHPDoc param comments for addOption() & formatOptions()"
jenkins-bot [Sat, 22 Dec 2018 00:25:15 +0000 (00:25 +0000)]
Merge "XmlSelect: Fix PHPDoc param comments for addOption() & formatOptions()"

4 years agoXmlSelect: Fix PHPDoc param comments for addOption() & formatOptions()
Alangi Derick [Mon, 17 Dec 2018 15:51:19 +0000 (16:51 +0100)]
XmlSelect: Fix PHPDoc param comments for addOption() & formatOptions()

Change-Id: I60f1bd78b3820510f9fbc497e1c703f9da7fd900

4 years agoMerge "Mark protected IndexPager properties also as protected in subclasses"
jenkins-bot [Fri, 21 Dec 2018 23:39:16 +0000 (23:39 +0000)]
Merge "Mark protected IndexPager properties also as protected in subclasses"

4 years agoMerge "Avoid expensive array_shift where possible"
jenkins-bot [Fri, 21 Dec 2018 23:33:07 +0000 (23:33 +0000)]
Merge "Avoid expensive array_shift where possible"

4 years agoMerge "Revision: Assert that $mRecord is never null in Revision"
jenkins-bot [Fri, 21 Dec 2018 23:33:01 +0000 (23:33 +0000)]
Merge "Revision: Assert that $mRecord is never null in Revision"

4 years agoMerge "Linker: Deprecate non-Language types for $lang of tocList() and generateTOC()"
jenkins-bot [Fri, 21 Dec 2018 23:29:59 +0000 (23:29 +0000)]
Merge "Linker: Deprecate non-Language types for $lang of tocList() and generateTOC()"

4 years agoRevision: Assert that $mRecord is never null in Revision
daniel [Thu, 20 Dec 2018 18:26:42 +0000 (19:26 +0100)]
Revision: Assert that $mRecord is never null in Revision

Bug: T187153
Change-Id: I828954855aa24114ec756e45d4dfe1468b2efa27

4 years agoMerge "objectcache: add expiration check callback to WANObjectCache::getWithSetCallback"
jenkins-bot [Fri, 21 Dec 2018 22:42:41 +0000 (22:42 +0000)]
Merge "objectcache: add expiration check callback to WANObjectCache::getWithSetCallback"

4 years agoMerge "rdbms: add trace to getLagFromPtHeartbeat() log entries"
jenkins-bot [Fri, 21 Dec 2018 22:42:08 +0000 (22:42 +0000)]
Merge "rdbms: add trace to getLagFromPtHeartbeat() log entries"

4 years agoMerge "Make thumbnail image decoding async"
Aaron Schulz [Fri, 21 Dec 2018 21:24:54 +0000 (21:24 +0000)]
Merge "Make thumbnail image decoding async"

4 years agoMark private properties in ContribsPager as "private"
Thiemo Kreuz [Thu, 20 Dec 2018 16:58:15 +0000 (17:58 +0100)]
Mark private properties in ContribsPager as "private"

There should not be any code accessing these. The way to set these
properties is via the constructor.

Change-Id: I8f2a8e88b8dfad53d0b16bc3f73974b894a031fb

4 years agoobjectcache: add expiration check callback to WANObjectCache::getWithSetCallback
Aaron Schulz [Wed, 5 Dec 2018 19:46:57 +0000 (14:46 -0500)]
objectcache: add expiration check callback to WANObjectCache::getWithSetCallback

This is useful when the timestamps to be checked depend on the value or are stored
in the database rather than as check keys.

Change-Id: I81ab08a943ee7d2f96a132d371965501941ed37f

4 years agoRemove redundant property declarations
Thiemo Kreuz [Thu, 20 Dec 2018 16:54:51 +0000 (17:54 +0100)]
Remove redundant property declarations

These are already declared and initialized in the base class. No need
to repeat this.

Change-Id: I4f83202cc9076bd68fa25490bdf8b4a2913b6b04

4 years agoAdd missing, dynamically declared properties in ContribsPager
Thiemo Kreuz [Thu, 20 Dec 2018 16:51:42 +0000 (17:51 +0100)]
Add missing, dynamically declared properties in ContribsPager

These are all set in the constructor, and don't need a default because
of this.

I'm also adding documentation for the class properties in this class as
good as I can (type, possible values, meaning, and behavior).

Change-Id: Ic2367ca7e8d8b2b7ae4f80ad04081a0db2821de5

4 years agordbms: add trace to getLagFromPtHeartbeat() log entries
Aaron Schulz [Fri, 21 Dec 2018 18:20:58 +0000 (10:20 -0800)]
rdbms: add trace to getLagFromPtHeartbeat() log entries

Change-Id: I677610c711443b787f7cea1be2dd9f01486b1324

4 years agoLinker: Deprecate non-Language types for $lang of tocList() and generateTOC()
Fomafix [Mon, 16 Jul 2018 08:44:54 +0000 (10:44 +0200)]
Linker: Deprecate non-Language types for $lang of tocList() and generateTOC()

$lang still defaults to $wgLang on unset parameter.

Change-Id: I15b65fec987641885374dfef9e1229ea405f7c30

4 years agoMerge "Deprecate User::getPasswordValidity()"
jenkins-bot [Fri, 21 Dec 2018 05:06:40 +0000 (05:06 +0000)]
Merge "Deprecate User::getPasswordValidity()"

4 years agoDeprecate User::getPasswordValidity()
Gergő Tisza [Thu, 20 Dec 2018 22:44:04 +0000 (14:44 -0800)]
Deprecate User::getPasswordValidity()

Unused, the return format does not seem useful.

Also improve the documentation of $wgPasswordPolicy
and PasswordPolicyChecks.

Change-Id: Ic01e80cfefc4cfb0eee1eccc6a66942f692278a0

4 years agoAdd warning if you give Html::openElement a name with a space
Brian Wolff [Tue, 4 Sep 2018 17:44:44 +0000 (17:44 +0000)]
Add warning if you give Html::openElement a name with a space

Bug: T201747
Change-Id: I7772f1e8c0c12bdf1fd60d62e015f2ec82d8ac90

4 years agoEmailNotification should provide a getter for pageStatus
Mark A. Hershberger [Wed, 6 Sep 2017 00:42:21 +0000 (20:42 -0400)]
EmailNotification should provide a getter for pageStatus

Extensions that have hooks for
UpdateUserMailerFormattedPageStatus (to provide additional
pageStatus indicators) need a way to make sure that, when their
hook is called in SendWatchlistemailNotification, they only
notifications handling their pageStatus indicator.  This allows them
to fetch the protected property.

Bug: T175104
Change-Id: I2beb5b3576f2cd739dab16b9adf613c96636edd3

4 years agoregistration: Add release notes for platform requirements
MGChecker [Thu, 20 Dec 2018 23:52:35 +0000 (00:52 +0100)]
registration: Add release notes for platform requirements

This adds release notes for I510de1e6d80 and I6744cc0be2.

Bug: T197535
Change-Id: I563012dd7f398c4892ec8a4ecab6144bc589d441

4 years agoMerge "localisation: Make PHP cache files slimmer"
jenkins-bot [Thu, 20 Dec 2018 22:13:28 +0000 (22:13 +0000)]
Merge "localisation: Make PHP cache files slimmer"

4 years agolocalisation: Make PHP cache files slimmer
Seb35 [Sun, 23 Sep 2018 22:52:56 +0000 (00:52 +0200)]
localisation: Make PHP cache files slimmer

The only difference is the scalar values are no longer encoded as an
array, but just the value itself. As a result, PHP localisation cache
files are about 2/3rds of their previous size and become slightly
smaller than CDB files.

Bug: T99740
Change-Id: Iaa5e32830dc1bb710b9e0f1a681afe91e521ece9

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 20 Dec 2018 21:18:25 +0000 (22:18 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I6c5f1888a144fff4fd129244c43441535a47fd79

4 years agoMerge "Fix order on Special:Contributions when timestamps are identical"
jenkins-bot [Thu, 20 Dec 2018 17:56:36 +0000 (17:56 +0000)]
Merge "Fix order on Special:Contributions when timestamps are identical"

4 years agoMerge "Fix the cache timestamp for forced updates."
jenkins-bot [Thu, 20 Dec 2018 17:49:02 +0000 (17:49 +0000)]
Merge "Fix the cache timestamp for forced updates."

4 years agoMark protected IndexPager properties also as protected in subclasses
Thiemo Kreuz [Thu, 20 Dec 2018 17:25:19 +0000 (18:25 +0100)]
Mark protected IndexPager properties also as protected in subclasses

I'm intentionally only touching these protected properties and nothing
else, because I believe these are uncontroversial. They should be protected
according to modern SOLID standards, and actually are declared as
protected in the base class. What this patch effectively does is documenting
this fact, but it does not change anything.

Change-Id: I625307b58bd419c4a72e9842b2b46c08ed9b4f8e

4 years agoFix order on Special:Contributions when timestamps are identical
Thiemo Kreuz [Mon, 17 Dec 2018 14:03:44 +0000 (15:03 +0100)]
Fix order on Special:Contributions when timestamps are identical

Please see T200259#4827781 for a longer explanation why this is needed.

Bug: T200259
Change-Id: I1678f7ec994328a96eed208483421be2f82be0ce

4 years agoMerge "Include block ID in unblock log"
jenkins-bot [Thu, 20 Dec 2018 17:07:05 +0000 (17:07 +0000)]
Merge "Include block ID in unblock log"

4 years agoApiDelete: Handle batched deletions properly
Brad Jorsch [Thu, 20 Dec 2018 14:59:02 +0000 (09:59 -0500)]
ApiDelete: Handle batched deletions properly

When batched deletions via the job queue were added in Ie800fb5a, the
way this was reported caused ApiDelete to report an error. Instead it
should report success with appropriate signaling to the client.

Bug: T212356
Change-Id: I1ef66277e988572c6720cf3e3cb36b18530746b4

4 years agoMake thumbnail image decoding async
Gilles Dubuc [Thu, 20 Dec 2018 10:02:39 +0000 (11:02 +0100)]
Make thumbnail image decoding async

This is a browser hint indicating that decoding of the image can be done
asynchronously (instead of synchronously during the image's onload event).
Marking decoding as async enables the browser to display any other
non-image content that might be waiting to be rendered, without waiting
for the image to be decoding. This should allow text to appear sooner in
some situations, where the browser would have otherwise waited to
bundle its rendering with an image. The final result (non-image + image
content being displayed) will happen at the same time as before.

Given how text-heavy wiki context usually is, it makes sense to allow
users to see the text sooner in some situations, so they can start reading.


Bug: T212124
Change-Id: I3d738eba016bad486194f032a47ac6312f61c34e

4 years agoMerge "Add editing own JSON to editmyoptions grant"
jenkins-bot [Thu, 20 Dec 2018 07:35:09 +0000 (07:35 +0000)]
Merge "Add editing own JSON to editmyoptions grant"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 19 Dec 2018 20:56:04 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I30701a3722177d2ded82027426fb8984dc7c8f67

4 years agoMerge "API: Add User-Agent to CORS allow list"
jenkins-bot [Wed, 19 Dec 2018 20:27:03 +0000 (20:27 +0000)]
Merge "API: Add User-Agent to CORS allow list"

4 years agoMerge "ApiBlock: Avoid PHP warning when partial blocks are enabled but not used"
jenkins-bot [Wed, 19 Dec 2018 20:20:47 +0000 (20:20 +0000)]
Merge "ApiBlock: Avoid PHP warning when partial blocks are enabled but not used"

4 years agoAPI: Add User-Agent to CORS allow list
Brad Jorsch [Thu, 13 Dec 2018 17:05:33 +0000 (12:05 -0500)]
API: Add User-Agent to CORS allow list

An updated spec[1] removed the User-Agent header from the list of forbidden
headers for XHR, so some clients are now requesting to use it.

[1] https://github.com/whatwg/fetch/commit/dab09b0c483

Change-Id: I43d42c3c3a6510721ff7e5fc406db797bf08ffae

4 years agoFix the cache timestamp for forced updates.
daniel [Sat, 24 Nov 2018 15:59:58 +0000 (16:59 +0100)]
Fix the cache timestamp for forced updates.

Without this patch, the forcelinksupdate parameter of ApiPurge
was inoperational, caused by the fact that RefreshLinksJob got
the original revision's timestamp in the rootJobTimestamp parameter,
instead of the time at which the new ParserOutput was created.

See <https://phabricator.wikimedia.org/T210307#4771586> for details.

Bug: T210307
Change-Id: I281d6d0ed112b35e160775e528d363ce4770990a

4 years agoMerge "Use MediaWiki\SuppressWarnings around trigger_error('') instead @"
D3r1ck01 [Wed, 19 Dec 2018 17:15:17 +0000 (17:15 +0000)]
Merge "Use MediaWiki\SuppressWarnings around trigger_error('') instead @"

4 years agoMerge "Include bot password app ID in audit data"
jenkins-bot [Wed, 19 Dec 2018 16:37:46 +0000 (16:37 +0000)]
Merge "Include bot password app ID in audit data"

4 years agoApiBlock: Avoid PHP warning when partial blocks are enabled but not used
Brad Jorsch [Wed, 19 Dec 2018 16:11:59 +0000 (11:11 -0500)]
ApiBlock: Avoid PHP warning when partial blocks are enabled but not used

If partial blocks are available but a sitewide block is being made,
$params['pagerestrictions'] is null and implode() raises a warning.
Since null casts to the empty array, it's easy enough to work around.

Also add a test hitting this case.

Change-Id: Id7e2559d7569031b7c1228adb0c0a14b3c1527c3

4 years agoMerge "Fix regular expression"
jenkins-bot [Wed, 19 Dec 2018 12:35:52 +0000 (12:35 +0000)]
Merge "Fix regular expression"

4 years agoClean ups of dropping tag_summary table
Amir Sarabadani [Tue, 18 Dec 2018 22:10:52 +0000 (23:10 +0100)]
Clean ups of dropping tag_summary table

Change-Id: I92dc906d0dfd870e6b77671e5d7cfd3f56090325

4 years agoInclude block ID in unblock log
Gergő Tisza [Tue, 18 Dec 2018 07:50:05 +0000 (23:50 -0800)]
Include block ID in unblock log

Also change block log to only include the ID of the block.
Including autoblock IDs just makes analysis harder, and it is not
useful when searching for autoblocks since those created when a
blocked user tries to edit are not logged this way.

Bug: T210476
Change-Id: Iff1697be416abbb807227d0629cf41346bd379c2

4 years agoMerge "travis: Add PHP 7.3 (allowed failure)"
jenkins-bot [Wed, 19 Dec 2018 04:49:21 +0000 (04:49 +0000)]
Merge "travis: Add PHP 7.3 (allowed failure)"

4 years agoMerge "Special:AllMessages: Improve zebra striping on hover"
jenkins-bot [Tue, 18 Dec 2018 22:43:11 +0000 (22:43 +0000)]
Merge "Special:AllMessages: Improve zebra striping on hover"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 18 Dec 2018 21:16:37 +0000 (22:16 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Idfb2f9b39fe0eacd31663f9c769be3e88c46353e

4 years agoDrop tag_summary and valid_tag tables
Amir Sarabadani [Wed, 12 Dec 2018 19:20:42 +0000 (20:20 +0100)]
Drop tag_summary and valid_tag tables

Bug: T209525
Change-Id: I153607239145a772f5ea47eefd3340096a494b4b

4 years agoChangesList separates content elements from presentation
jdlrobson [Wed, 21 Nov 2018 22:55:48 +0000 (14:55 -0800)]
ChangesList separates content elements from presentation

Special:RecentChanges and Special:Watchlist benefit from this change

Bug: T205581
Change-Id: If46d9ed904fdc6f01decbfde12ade0c47e282171

4 years agoFix copy-paste error
Amir Sarabadani [Tue, 18 Dec 2018 17:55:13 +0000 (18:55 +0100)]
Fix copy-paste error

It's actually adding the column on the wrong table

Change-Id: I2fd8ea50f3eb4b5da04fce2ea0348a2dc6329965

4 years agoOption to load restrictions from DB_MASTER
Elliott Eggleston [Fri, 14 Dec 2018 20:06:53 +0000 (15:06 -0500)]
Option to load restrictions from DB_MASTER

Adds a $readLatest parameter to Title::loadRestrictions that skips
the replica DBs and goes straight to the master DB to get the latest.

TODO: should I add $readLatest to all the getRestrictions* functions?

Bug: T210983
Change-Id: I834de033fb79870de7d081701693663fb6ee93d3

4 years agoMerge "HTMLForm OOUI Flatlist: Reduce `margin` slightly"
jenkins-bot [Tue, 18 Dec 2018 13:16:54 +0000 (13:16 +0000)]
Merge "HTMLForm OOUI Flatlist: Reduce `margin` slightly"

4 years agoMerge "MagicWordFactory: Follow-up on I5d2166f155e31900cb40c"
jenkins-bot [Tue, 18 Dec 2018 12:24:22 +0000 (12:24 +0000)]
Merge "MagicWordFactory: Follow-up on I5d2166f155e31900cb40c"

4 years agoMagicWordFactory: Follow-up on I5d2166f155e31900cb40c
Alangi Derick [Tue, 18 Dec 2018 10:11:20 +0000 (11:11 +0100)]
MagicWordFactory: Follow-up on I5d2166f155e31900cb40c

Applied comments from I5d2166f155e31900cb40c to improve on
the unit test. makeMagicWordFactory() makes passing "null"
optional (which is default, hence some cleanup for calls).

Change-Id: Ib9a096c519f0de7286aa244bf3bb842cc11740f9

4 years agoMerge "ApiComparePages: Don't error with no prev/next rev"
jenkins-bot [Tue, 18 Dec 2018 10:06:23 +0000 (10:06 +0000)]
Merge "ApiComparePages: Don't error with no prev/next rev"

4 years agoMerge "tests: Add PHPUnit tests for methods in MagicWordFactory::class"
jenkins-bot [Tue, 18 Dec 2018 09:13:38 +0000 (09:13 +0000)]
Merge "tests: Add PHPUnit tests for methods in MagicWordFactory::class"

4 years agotests: Add PHPUnit tests for methods in MagicWordFactory::class
Alangi Derick [Mon, 19 Nov 2018 19:07:30 +0000 (20:07 +0100)]
tests: Add PHPUnit tests for methods in MagicWordFactory::class

* testGetContentLanguage() - covers the getContentLanguage() method.
* testGet() - covers the get() method in the MagicWordFactory class.
* testGetVariableIDs() - covers the getVariableIDs method.
* testGetSubstIDs() - covers the getSubstIDs() method.
* testGetCacheTTL() - covers the getCacheTTL() method. This covers
  both paths when there is a valid and an invalid caching hint.
* makeMagicWordFactory() - a helper function for creating an object
  of the MagicWordFactory class.
* testGetDoubleUnderscoreArray() - covers getDoubleUnderscoreArray()
  method and also calls newArray() under the hood so that is also

Change-Id: I5d2166f155e31900cb40c22fb976e81d0d545627

4 years agoHTMLForm OOUI Flatlist: Reduce `margin` slightly
Volker E [Tue, 18 Dec 2018 06:16:28 +0000 (22:16 -0800)]
HTMLForm OOUI Flatlist: Reduce `margin` slightly

When provided without label, flatlists are in general modificators
logically connected to the input above as seen on Special:BlockList
for example. Reducing the `margin` slightly helps to visually
emphasize the connection.

Bug: T177683
Change-Id: Ice666e54e440f97d177580ac258dfbed1577da0a

4 years agoUpgrade wikimedia/ip-set to 2.0.0
Kunal Mehta [Tue, 18 Dec 2018 04:00:19 +0000 (20:00 -0800)]
Upgrade wikimedia/ip-set to 2.0.0

Bug: T209756
Depends-On: I21a6032defb15b77519631b251b5e577207902a8
Change-Id: I424cf8871daf1e19b9d03511ace5f09d77746145

4 years agotravis: Add PHP 7.3 (allowed failure)
Kunal Mehta [Tue, 18 Dec 2018 03:57:22 +0000 (19:57 -0800)]
travis: Add PHP 7.3 (allowed failure)

Change-Id: I2205ae6b3543ec8fc094c043723c73ab1d1476b5

4 years agoMerge "Message: Don't include Title objects in the serialization (part 2)"
jenkins-bot [Tue, 18 Dec 2018 02:51:47 +0000 (02:51 +0000)]
Merge "Message: Don't include Title objects in the serialization (part 2)"

4 years agoMerge "ProfilerExcimer: allow early start"
jenkins-bot [Tue, 18 Dec 2018 02:27:03 +0000 (02:27 +0000)]
Merge "ProfilerExcimer: allow early start"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 17 Dec 2018 20:55:06 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I14d75d0d131a158d36055d612ab9139586258978

4 years agoMerge "DateTimeInputWidget: Fix UI/UX glitches"
jenkins-bot [Mon, 17 Dec 2018 20:40:09 +0000 (20:40 +0000)]
Merge "DateTimeInputWidget: Fix UI/UX glitches"

4 years agoMerge "Follow-up I2266ec0: Mark new method as an internal"
jenkins-bot [Mon, 17 Dec 2018 20:18:41 +0000 (20:18 +0000)]
Merge "Follow-up I2266ec0: Mark new method as an internal"

4 years agoMerge "Set default of sleep time in populateChangeTagDef to zero"
jenkins-bot [Mon, 17 Dec 2018 19:42:20 +0000 (19:42 +0000)]
Merge "Set default of sleep time in populateChangeTagDef to zero"

4 years agoSet API limits for page restrictions to 10
Thalia [Mon, 17 Dec 2018 17:53:27 +0000 (17:53 +0000)]
Set API limits for page restrictions to 10

Bug: T212142
Change-Id: Ide0f2f86df2101194155be53a4b9012ddefbbcaf

4 years agoMerge "Fix sql.php --json behavior"
jenkins-bot [Mon, 17 Dec 2018 13:26:21 +0000 (13:26 +0000)]
Merge "Fix sql.php --json behavior"

4 years agoMerge "DateTimeInputWidget: Use 'clear' icon to clear input"
jenkins-bot [Mon, 17 Dec 2018 12:49:23 +0000 (12:49 +0000)]
Merge "DateTimeInputWidget: Use 'clear' icon to clear input"

4 years agoMerge "Stop updating tag_summary table"
jenkins-bot [Mon, 17 Dec 2018 12:48:33 +0000 (12:48 +0000)]
Merge "Stop updating tag_summary table"

4 years agoSpecial:AllMessages: Improve zebra striping on hover
Bartosz Dziewoński [Tue, 13 Nov 2018 16:29:22 +0000 (17:29 +0100)]
Special:AllMessages: Improve zebra striping on hover

Previously, the full row (spanning two sub-rows) would not
get the hover effect when hovering over the second sub-row.

Inspired by <https://stackoverflow.com/a/15465002>.

Change-Id: Id698516da4fbe01f90cbe1499fb81721642a4dfd

4 years agoAvoid expensive array_shift where possible
Thiemo Kreuz [Mon, 17 Dec 2018 10:58:55 +0000 (11:58 +0100)]
Avoid expensive array_shift where possible

array_shift manipulates the original array. This is surprisingly
expensive, because it iterates *all* elements in the array and
decrements numeric keys. The code touched in this patch does not need
this restructured new array, but only the individual elements.

Change-Id: Iee28377b2c9930f6de821e041381a1d7564f7633

4 years agoMerge "Special:AllMessages: Remove al_title and allmessages-customised classes"
jenkins-bot [Mon, 17 Dec 2018 09:39:52 +0000 (09:39 +0000)]
Merge "Special:AllMessages: Remove al_title and allmessages-customised classes"

4 years agoSpecial:AllMessages: Remove al_title and allmessages-customised classes
Timo Tijhof [Sun, 16 Dec 2018 23:16:26 +0000 (23:16 +0000)]
Special:AllMessages: Remove al_title and allmessages-customised classes

* The al_title class was unused, and thus removed.

* The allmessages-customised class was used in CSS to target
  elements with 'al_default' and 'al_actual' classses within it,
  which are in turn only used for that purpose.
  Change the HTML to match the needs of the CSS by only setting
  al_default/al_actual classes on customised messages and remove
  need for the parent element class.

On a plain install this reduced output by ~2K from 75.8K to 74.0K,
and allocate 100 (2x50) fewer attribute nodes.

Change-Id: If2dd4cf5c937935f03f30b8410a32b6821b0bf34

4 years agoFix sql.php --json behavior
Gergő Tisza [Mon, 17 Dec 2018 05:06:32 +0000 (21:06 -0800)]
Fix sql.php --json behavior

* return empty array when the query had no result (instead of
  falling back into non-JSON mode)
* return JSON for write queries as well
* retain legacy behavior in non-JSON mode for empty SELECTs, just in
  case somebody relied on it

Change-Id: Iaefbb443650a395278d1cc9ab6aa668b13b217c9

4 years agoProfilerExcimer: allow early start
Tim Starling [Fri, 7 Dec 2018 04:13:43 +0000 (15:13 +1100)]
ProfilerExcimer: allow early start

Allow the profiler to be started elsewhere and passed into
ProfilerExcimer via the configuration array. This allows the profiler to
be started in the auto_prepend_file. XHProf doesn't need this because it
has a single global profiler.

Change-Id: I348499a15d9cc42de0ba1a20afc2283b794931a3

4 years agoDateTimeInputWidget: Fix UI/UX glitches
Volker E [Sat, 15 Dec 2018 20:08:39 +0000 (12:08 -0800)]
DateTimeInputWidget: Fix UI/UX glitches

- Limiting focus state of inputs to datetime handle boundaries
- Showing clear button only when there's value to be cleared
- Distance clear button from input
- Removing focus outline from day and timezone values

Bug: T212047
Change-Id: I9b815f38abeacacf921873529117c51c187d7fb9

4 years agoMerge "Add ProfilerExcimer"
jenkins-bot [Sun, 16 Dec 2018 23:00:16 +0000 (23:00 +0000)]
Merge "Add ProfilerExcimer"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 15 Dec 2018 20:55:18 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I005fa8d24c284741e5b139e1228b6a3251407a65

4 years agoSet default of sleep time in populateChangeTagDef to zero
Amir Sarabadani [Sat, 15 Dec 2018 17:28:54 +0000 (18:28 +0100)]
Set default of sleep time in populateChangeTagDef to zero

The script already has waitForReplication(), that's good for non-WMF setups

Bug: T206568
Change-Id: I020a4472796eeff2561da6c17a817091d4e9af5a

4 years agoDateTimeInputWidget: Use 'clear' icon to clear input
Volker E [Sat, 15 Dec 2018 03:32:41 +0000 (19:32 -0800)]
DateTimeInputWidget: Use 'clear' icon to clear input

Also removing unnecessary indicator overrides.

Bug: T212022
Change-Id: Ie962138811aff03d72ea29eb260131c37067456b

4 years agoFix exception on certain http failures
Bill Pirkle [Fri, 14 Dec 2018 21:55:28 +0000 (15:55 -0600)]
Fix exception on certain http failures

Task T202110 included a change to recognize an HTTP status code
of 0 (zero) as an error, but it failed to set a status message,
resulting in an exception.  Changed to set a status message of
'Error' so that required value is not empty.

Bug: T212005
Change-Id: I5fb78555bfcaeccdd726432f4dfc70924a385c41

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 14 Dec 2018 20:55:22 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I20f67d42ea1cd74c732c87a50d4db04e16a5abc5

4 years agoMerge "PostgreSQL: Drop three unused columns"
jenkins-bot [Fri, 14 Dec 2018 18:18:12 +0000 (18:18 +0000)]
Merge "PostgreSQL: Drop three unused columns"

4 years agoMerge "Use SpecialPageFactory in ApiQueryQueryPage"
jenkins-bot [Fri, 14 Dec 2018 18:13:43 +0000 (18:13 +0000)]
Merge "Use SpecialPageFactory in ApiQueryQueryPage"

4 years agoPostgreSQL: Drop three unused columns
Kevin Israel [Mon, 9 Jul 2018 15:28:59 +0000 (11:28 -0400)]
PostgreSQL: Drop three unused columns

The columns dropped in this commit are:

* category.cat_hidden
  (for MySQL, dropped in 1.20 / 0cbc85494d47cdeb)
* site_stats.ss_admins
  (for MySQL, dropped in 1.21 / bd602d20833f435f)
* recentchanges.rc_cur_time
  (for MySQL, dropped in 1.24 / 2b441eba406f2c49)

Bug: T64103
Change-Id: I7a7e9a2ac5066a9c9ab2583419d507e14fdd8c2c

4 years agoUse SpecialPageFactory in ApiQueryQueryPage
Lucas Werkmeister [Fri, 14 Dec 2018 15:56:56 +0000 (16:56 +0100)]
Use SpecialPageFactory in ApiQueryQueryPage

Instead of assuming that all query page classes can be instantiated with
no constructor parameters, use a SpecialPageFactory.

This would not have prevented T208924 (that would just have resulted in
a later, different error), but it’s just a good idea in general.

Change-Id: I2473a53acd9fefdeffb1fa7ecb88873f3ee345cc

4 years agoMerge "eslint: Turn on reportUnusedDisableDirectives"
jenkins-bot [Fri, 14 Dec 2018 16:52:31 +0000 (16:52 +0000)]
Merge "eslint: Turn on reportUnusedDisableDirectives"

4 years agoMerge "Introduce TagMultiselectWidget.php"
jenkins-bot [Fri, 14 Dec 2018 15:45:22 +0000 (15:45 +0000)]
Merge "Introduce TagMultiselectWidget.php"

4 years agoIntroduce TagMultiselectWidget.php
Thalia [Wed, 12 Dec 2018 15:57:57 +0000 (15:57 +0000)]
Introduce TagMultiselectWidget.php

TitlesMultiselectWidget and UsersMultiselectWidget share
a lot of functionality, so implement a common base class.

This also adds some things to UsersMultiselectWidget:
* shows a pending element to users with JavaScript
* makes the input configurable

Change-Id: Ie6649b476c64e795254f457e3863fa7f14aa05ac