lhc/web/wiklou.git
5 years agoUpdate OOUI to v0.31.2
James D. Forrester [Tue, 26 Mar 2019 23:19:10 +0000 (16:19 -0700)]
Update OOUI to v0.31.2

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.2

Bug: T161854
Bug: T192131
Bug: T218882
Bug: T218977
Bug: T219004
Bug: T219240
Depends-On: I6179266e71901182614ec24e7b0510b7a44ff50a
Change-Id: I6179266e71901182614ec24e7b0510b7a44ff50b

5 years agoMerge "objectcache: minor refactoring to BagOStuff"
jenkins-bot [Tue, 26 Mar 2019 22:47:55 +0000 (22:47 +0000)]
Merge "objectcache: minor refactoring to BagOStuff"

5 years agoMerge "Allow skins full control of Contributions/History styles"
jenkins-bot [Tue, 26 Mar 2019 22:31:58 +0000 (22:31 +0000)]
Merge "Allow skins full control of Contributions/History styles"

5 years agoobjectcache: minor refactoring to BagOStuff
Aaron Schulz [Tue, 26 Mar 2019 22:14:42 +0000 (15:14 -0700)]
objectcache: minor refactoring to BagOStuff

Split up expiry functions and moved add() near other primitive writes.

Change-Id: I97bb91e648b797b1ab5a6934d212689b1e67f7c6

5 years agoMerge "objectcache: improve comments for ATTR_/QOS_ constants"
jenkins-bot [Tue, 26 Mar 2019 22:14:15 +0000 (22:14 +0000)]
Merge "objectcache: improve comments for ATTR_/QOS_ constants"

5 years agoMerge "rdbms: treat cloned temporary tables as "effective write" targets"
jenkins-bot [Tue, 26 Mar 2019 22:02:10 +0000 (22:02 +0000)]
Merge "rdbms: treat cloned temporary tables as "effective write" targets"

5 years agoMerge "Prune old edit stash entries from users as they create more"
jenkins-bot [Tue, 26 Mar 2019 21:59:55 +0000 (21:59 +0000)]
Merge "Prune old edit stash entries from users as they create more"

5 years agoAllow skins full control of Contributions/History styles
jdlrobson [Mon, 25 Mar 2019 23:28:32 +0000 (16:28 -0700)]
Allow skins full control of Contributions/History styles

This switches 2 special page modules to be defined via skinStyles.
This allows skins to skin these pages as they wish rather than
relying on the defaults.

This is very important for Minerva, which provides a distinctly
different look and feel.

Bug: T205581
Change-Id: I429ab712099ede0fb3cbd64ca3fd1840a1615652

5 years agordbms: treat cloned temporary tables as "effective write" targets
Aaron Schulz [Wed, 20 Mar 2019 04:04:35 +0000 (21:04 -0700)]
rdbms: treat cloned temporary tables as "effective write" targets

Make IDatabase::lastDoneWrites() reflect creation and changes to
the cloned temporary unit test tables but not other temporary tables.
This effects the LB method hasOrMadeRecentMasterChanges(). Other tables
are assumpted to really just be there for temporary calculations rather
acting as test-only ephemeral versions of permanent tables. Treating
writes to the "fake permanent" temp tables more like real permanent
tables means that the tests better align with production.

At the moment, temporary tables still have to use DB_MASTER, given
the assertIsWritableMaster() check in query(). This restriction
can be lifted at some point, when RDBMs compatibility is robust.

Bug: T218388
Change-Id: I4c0d629da254ac2aaf31aae35bd2efc7bc064ac6

5 years agordbms: codify DatabaseDomain table "_" prefix convention
Aaron Schulz [Mon, 25 Mar 2019 14:51:45 +0000 (07:51 -0700)]
rdbms: codify DatabaseDomain table "_" prefix convention

Alos simplify isCompatible() slightly and make the string
case in convertToString() explicit.

Change-Id: Ifb61bb5fb012491520525bbebfbde2269fa55b52

5 years agoMerge "Make MWLBFactory sanity check that postgres is not used with a table prefix"
jenkins-bot [Tue, 26 Mar 2019 20:18:42 +0000 (20:18 +0000)]
Merge "Make MWLBFactory sanity check that postgres is not used with a table prefix"

5 years agoMerge "Avoid using calls to freeResults() and allow object go out of scope"
jenkins-bot [Tue, 26 Mar 2019 19:20:10 +0000 (19:20 +0000)]
Merge "Avoid using calls to freeResults() and allow object go out of scope"

5 years agoMerge "rdbms: use a direct "USE" query for doSelectDomain() for mysql"
jenkins-bot [Tue, 26 Mar 2019 19:19:51 +0000 (19:19 +0000)]
Merge "rdbms: use a direct "USE" query for doSelectDomain() for mysql"

5 years agoMerge "rdbms: remove $wgDBprefix reference from DatabaseOracle"
jenkins-bot [Tue, 26 Mar 2019 19:19:38 +0000 (19:19 +0000)]
Merge "rdbms: remove $wgDBprefix reference from DatabaseOracle"

5 years agoobjectcache: improve comments for ATTR_/QOS_ constants
Aaron Schulz [Tue, 26 Mar 2019 18:16:38 +0000 (11:16 -0700)]
objectcache: improve comments for ATTR_/QOS_ constants

Change-Id: Iaa5361a09e1dc559fee8eb034c9c05bc999c776e

5 years agoMerge "rdbms: Use correct value for 'sslmode' in DatabasePostgres"
jenkins-bot [Tue, 26 Mar 2019 18:51:26 +0000 (18:51 +0000)]
Merge "rdbms: Use correct value for 'sslmode' in DatabasePostgres"

5 years agordbms: use a direct "USE" query for doSelectDomain() for mysql
Aaron Schulz [Fri, 22 Mar 2019 01:12:44 +0000 (18:12 -0700)]
rdbms: use a direct "USE" query for doSelectDomain() for mysql

This should give better error messages on failure.

Bug: T212284
Change-Id: I55260c6e3db1770f01e3d6a6a363b917a57265be

5 years agordbms: remove $wgDBprefix reference from DatabaseOracle
Aaron Schulz [Tue, 26 Mar 2019 18:44:17 +0000 (11:44 -0700)]
rdbms: remove $wgDBprefix reference from DatabaseOracle

Rely on MWLBFactory as other DB classes do

Change-Id: I33d535c659626dd42c9cb8d20c1a0fc90a885c8c

5 years agoMerge "rdbms: Fix incomplete doc for DatabaseMssql::tableName()"
jenkins-bot [Tue, 26 Mar 2019 18:41:05 +0000 (18:41 +0000)]
Merge "rdbms: Fix incomplete doc for DatabaseMssql::tableName()"

5 years agoPrune old edit stash entries from users as they create more
Aaron Schulz [Tue, 26 Mar 2019 05:26:13 +0000 (22:26 -0700)]
Prune old edit stash entries from users as they create more

This should reduce pressure on certain medium-large sized memcached
slabs. Pre-1.5 memcached versions have a harder time pruning expired
entries in time to avoid evictions, so it will be most useful that
scenario.

Bug: T203786
Change-Id: Ic357dbfcd9abd525b02e8d631d1344db3745d24c

5 years agordbms: Use correct value for 'sslmode' in DatabasePostgres
Mark A. Hershberger [Thu, 9 Aug 2018 20:18:34 +0000 (16:18 -0400)]
rdbms: Use correct value for 'sslmode' in DatabasePostgres

Fix Postgres support by using ‘sslmode=require' instead of ‘sslmode=1'.

See https://www.postgresql.org/docs/current/static/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS

Change-Id: I424b0e3e144bbe9f0a2bde9a3b4a674dde10c729

5 years agordbms: Fix incomplete doc for DatabaseMssql::tableName()
Thiemo Kreuz [Tue, 26 Mar 2019 11:01:31 +0000 (12:01 +0100)]
rdbms: Fix incomplete doc for DatabaseMssql::tableName()

I'm also replacing a loop with an array_pad() call. When the count given
to array_pad() is negative, the padding is done to the left instead of
the right. This is exactly what the loop did before.

I'm also adding the missing limit to the explode() call.

Change-Id: I6737fcf6b60b822269b855f1405607be7fc23754

5 years agoMerge "Supress ChangeTags::addTags() exceptions for ManualLogEntry objects"
jenkins-bot [Tue, 26 Mar 2019 17:38:03 +0000 (17:38 +0000)]
Merge "Supress ChangeTags::addTags() exceptions for ManualLogEntry objects"

5 years agoMerge "OOUI forms: Remove infusable = false"
jenkins-bot [Tue, 26 Mar 2019 17:30:46 +0000 (17:30 +0000)]
Merge "OOUI forms: Remove infusable = false"

5 years agoMerge "HISTORY: Add MediaWiki 1.32.1 release change notes"
jenkins-bot [Tue, 26 Mar 2019 17:30:33 +0000 (17:30 +0000)]
Merge "HISTORY: Add MediaWiki 1.32.1 release change notes"

5 years agoHISTORY: Add MediaWiki 1.32.1 release change notes
Nikita Rana [Mon, 25 Mar 2019 19:19:08 +0000 (00:49 +0530)]
HISTORY: Add MediaWiki 1.32.1 release change notes

Add MediaWiki 1.32 release change notes, sourced from https://phabricator.wikimedia.org/source/mediawiki/browse/REL1_32/RELEASE-NOTES-1.32

Bug: T213714
Change-Id: I307ee0373021639835a6f3a3c4d3d6b7c6c3dbc8

5 years agoSupress ChangeTags::addTags() exceptions for ManualLogEntry objects
Piotr Miazga [Tue, 26 Mar 2019 15:17:05 +0000 (16:17 +0100)]
Supress ChangeTags::addTags() exceptions for ManualLogEntry objects

Looks like some parts of the code try to publish log event when
$newId is 0 or null. This cause ChangeTags::addTags to throw
an exception as at least one of rc_id, rev_id, or log_id must be
specified.

When ChangeTags::addTags() fails (because both $rev_id and $log_id
are not present), just ignore the exception and continue with
the execution.

Also, if one of those is set to 0, we need to pass null instead
(do not insert 0's in to DB as both log_id and rev_id are foreign
keys).

Additionally log all places where ManualLogEntry::publish() is
called with incorrect arguments so later we can fix all occurencie
and remove that try{}catch around ChangeTags::addTags() call.

Bug: T218940
Change-Id: I495f79f2b7a7ef1503d229a689babdc12deb353c

5 years agoMerge "HISTORY: Add MediaWiki 1.13 post-release change notes"
jenkins-bot [Tue, 26 Mar 2019 15:39:47 +0000 (15:39 +0000)]
Merge "HISTORY: Add MediaWiki 1.13 post-release change notes"

5 years agoMerge "HISTORY: Add MediaWiki 1.9 post-release change notes"
jenkins-bot [Tue, 26 Mar 2019 15:35:17 +0000 (15:35 +0000)]
Merge "HISTORY: Add MediaWiki 1.9 post-release change notes"

5 years agoMerge "HISTORY: Add MediaWiki 1.10 post-release change notes"
jenkins-bot [Tue, 26 Mar 2019 15:34:54 +0000 (15:34 +0000)]
Merge "HISTORY: Add MediaWiki 1.10 post-release change notes"

5 years agoMerge "Fix invalid HTMLForm::setValidationErrorMessage doc"
jenkins-bot [Tue, 26 Mar 2019 15:31:49 +0000 (15:31 +0000)]
Merge "Fix invalid HTMLForm::setValidationErrorMessage doc"

5 years agoHISTORY: Add MediaWiki 1.13 post-release change notes
Nikita Rana [Tue, 26 Mar 2019 11:28:18 +0000 (16:58 +0530)]
HISTORY: Add MediaWiki 1.13 post-release change notes

Add MediaWiki 1.13 post-release change notes, sourced from
https://www.mediawiki.org/wiki/Release_notes/1.13

Bug: T213714
Change-Id: Id1030ccb01e15538ba563cabbc283a90cf1e6992

5 years agoMerge "Stop gap to shut up log spam due to T212428."
jenkins-bot [Tue, 26 Mar 2019 14:26:54 +0000 (14:26 +0000)]
Merge "Stop gap to shut up log spam due to T212428."

5 years agoUse finally instead of try-catch-throw
Lucas Werkmeister [Tue, 26 Mar 2019 13:13:51 +0000 (14:13 +0100)]
Use finally instead of try-catch-throw

When this exception handler was introduced in change Ifbc1db4b82 (commit
9636d44448), MediaWiki still supported PHP 5.3.2, where finally was not
available. It was added in PHP 5.5, though, which we’ve required for a
while now, so we can simplify this a bit.

Change-Id: I7c967fb713de7495739e18ff6c6058a630129fda

5 years agoHISTORY: Add MediaWiki 1.9 post-release change notes
Nikita Rana [Tue, 26 Mar 2019 12:54:48 +0000 (18:24 +0530)]
HISTORY: Add MediaWiki 1.9 post-release change notes

Add MediaWiki 1.9 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.9

Bug:T213714
Change-Id: Idbb105e332afeec1daafaf275da6ae432a698371

5 years agoHISTORY: Add MediaWiki 1.10 post-release change notes
Nikita Rana [Tue, 26 Mar 2019 12:09:52 +0000 (17:39 +0530)]
HISTORY: Add MediaWiki 1.10 post-release change notes

Add MediaWiki 1.10 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.10

Bug:T213714
Change-Id: Ib313692a359d249ede38c51e823042a9f6f2b0e6

5 years agoMerge "OutputPage: Fix typo in escaped"
jenkins-bot [Tue, 26 Mar 2019 08:37:33 +0000 (08:37 +0000)]
Merge "OutputPage: Fix typo in escaped"

5 years agoOutputPage: Fix typo in escaped
Kunal Mehta [Tue, 26 Mar 2019 08:12:04 +0000 (01:12 -0700)]
OutputPage: Fix typo in escaped

Spotted by phan.

Change-Id: Iba372755869c602990ea063f3bfde36e19561adb

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 26 Mar 2019 07:29:03 +0000 (08:29 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I7090f89a59d6688c2e196d972f016785871cd89a

5 years agoMake MWLBFactory sanity check that postgres is not used with a table prefix
Aaron Schulz [Tue, 26 Mar 2019 06:09:32 +0000 (23:09 -0700)]
Make MWLBFactory sanity check that postgres is not used with a table prefix

Change-Id: If0c75a042c0e85d4f124be2204cdd52fcd602932

5 years agoMerge "db: Use variable functions/callbacks instead of call_user_func()"
jenkins-bot [Tue, 26 Mar 2019 05:41:52 +0000 (05:41 +0000)]
Merge "db: Use variable functions/callbacks instead of call_user_func()"

5 years agoMerge "block: Use correct function wfGetDB() as defined"
MaxSem [Tue, 26 Mar 2019 05:26:38 +0000 (05:26 +0000)]
Merge "block: Use correct function wfGetDB() as defined"

5 years agoMerge "specialpage: Remove unused QueryPage::doFeed()"
jenkins-bot [Tue, 26 Mar 2019 02:34:11 +0000 (02:34 +0000)]
Merge "specialpage: Remove unused QueryPage::doFeed()"

5 years agoMerge "Update some minor type hints"
jenkins-bot [Tue, 26 Mar 2019 02:24:04 +0000 (02:24 +0000)]
Merge "Update some minor type hints"

5 years agoStop gap to shut up log spam due to T212428.
daniel [Tue, 19 Mar 2019 22:16:49 +0000 (23:16 +0100)]
Stop gap to shut up log spam due to T212428.

Bug: T212428
Change-Id: I442bbe9837e73167cfdaabb0451bf974dc5039f3

5 years agoHistory page is now using pseudo elements for presentation
jdlrobson [Wed, 13 Feb 2019 22:18:31 +0000 (14:18 -0800)]
History page is now using pseudo elements for presentation

|, ( and ) separators are now added via CSS rather than being
made part of the HTML.

Bug: T205581
Change-Id: I272770418ee544b22f8f94312daf07010b7a2273

5 years agodictionary: Remove "mobilelanding"
Timo Tijhof [Mon, 25 Mar 2019 23:44:58 +0000 (23:44 +0000)]
dictionary: Remove "mobilelanding"

Bug: T187716
Change-Id: Ia3a77245fe0daacc39c42fd83e18bf9e59f7c74b

5 years agoMerge "Simplify Block::getBy and Block::getByName"
jenkins-bot [Mon, 25 Mar 2019 22:21:05 +0000 (22:21 +0000)]
Merge "Simplify Block::getBy and Block::getByName"

5 years agoMerge "Use Block::setTimestamp to set the timestamp on a block"
jenkins-bot [Mon, 25 Mar 2019 21:52:36 +0000 (21:52 +0000)]
Merge "Use Block::setTimestamp to set the timestamp on a block"

5 years agoMerge "GlobalFunctions: Document the usage of wfUrlencode( null )"
jenkins-bot [Mon, 25 Mar 2019 21:07:11 +0000 (21:07 +0000)]
Merge "GlobalFunctions: Document the usage of wfUrlencode( null )"

5 years agoMerge "HISTORY: Add MediaWiki 1.23 post-release change notes"
jenkins-bot [Mon, 25 Mar 2019 20:37:48 +0000 (20:37 +0000)]
Merge "HISTORY: Add MediaWiki 1.23 post-release change notes"

5 years agoMerge "HISTORY: Add MediaWiki 1.19 post-release change notes"
jenkins-bot [Mon, 25 Mar 2019 20:37:35 +0000 (20:37 +0000)]
Merge "HISTORY: Add MediaWiki 1.19 post-release change notes"

5 years agoMerge "HISTORY: Add MediaWiki 1.18 post-release change notes"
jenkins-bot [Mon, 25 Mar 2019 20:37:23 +0000 (20:37 +0000)]
Merge "HISTORY: Add MediaWiki 1.18 post-release change notes"

5 years agoMerge "HISTORY: Add MediaWiki 1.12 post-release change notes"
jenkins-bot [Mon, 25 Mar 2019 20:37:13 +0000 (20:37 +0000)]
Merge "HISTORY: Add MediaWiki 1.12 post-release change notes"

5 years agoMerge "fix up new text address handling in page content dumps"
jenkins-bot [Mon, 25 Mar 2019 20:23:18 +0000 (20:23 +0000)]
Merge "fix up new text address handling in page content dumps"

5 years agoMerge "HISTORY: Add MediaWiki 1.11 post-release change notes"
jenkins-bot [Mon, 25 Mar 2019 20:14:36 +0000 (20:14 +0000)]
Merge "HISTORY: Add MediaWiki 1.11 post-release change notes"

5 years agoMerge "resources: Add caching for faster runs and offline use"
jenkins-bot [Mon, 25 Mar 2019 20:12:55 +0000 (20:12 +0000)]
Merge "resources: Add caching for faster runs and offline use"

5 years agoMerge "resources: Improve foreign-resources docs and error messages"
jenkins-bot [Mon, 25 Mar 2019 20:11:33 +0000 (20:11 +0000)]
Merge "resources: Improve foreign-resources docs and error messages"

5 years agoMerge "resources: Make manageForeignResources a regular maint script"
jenkins-bot [Mon, 25 Mar 2019 20:04:08 +0000 (20:04 +0000)]
Merge "resources: Make manageForeignResources a regular maint script"

5 years agoOOUI forms: Remove infusable = false
Ed Sanders [Mon, 25 Mar 2019 18:58:52 +0000 (18:58 +0000)]
OOUI forms: Remove infusable = false

False is already the default value for infusable.

Change-Id: Ie0e9b7467b7f3f13c45372b38b7b80ba78852e55

5 years agoHISTORY: Add MediaWiki 1.23 post-release change notes
Nikita Rana [Mon, 25 Mar 2019 18:38:56 +0000 (00:08 +0530)]
HISTORY: Add MediaWiki 1.23 post-release change notes

Add MediaWiki 1.23 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.23

Bug:T213714
Change-Id: I20ad7615a2d9b0d3eb99abb41b125b30fc5d1ece

5 years agoMerge "Provide direct deprecation message for jquery.ui.spinner"
jenkins-bot [Mon, 25 Mar 2019 17:45:04 +0000 (17:45 +0000)]
Merge "Provide direct deprecation message for jquery.ui.spinner"

5 years agoMerge "mw.feedback: Remove unused custom spinner"
jenkins-bot [Mon, 25 Mar 2019 17:44:54 +0000 (17:44 +0000)]
Merge "mw.feedback: Remove unused custom spinner"

5 years agoGlobalFunctions: Document the usage of wfUrlencode( null )
Fomafix [Sat, 9 Mar 2019 13:04:28 +0000 (14:04 +0100)]
GlobalFunctions: Document the usage of wfUrlencode( null )

This was introduced for testing in 53b0052df.

Change-Id: I318d6d6c04334ea75fbc9ac1771fab9a9db8cb83

5 years agoMerge "registration: Follow-up on I54e8065c63f81016425c7dd40ce87e"
jenkins-bot [Mon, 25 Mar 2019 17:18:54 +0000 (17:18 +0000)]
Merge "registration: Follow-up on I54e8065c63f81016425c7dd40ce87e"

5 years agofix up new text address handling in page content dumps
Ariel T. Glenn [Mon, 25 Mar 2019 16:50:27 +0000 (18:50 +0200)]
fix up new text address handling in page content dumps

Broken in I979b6c8f0a72bc1f5ecce1d499d3fdfa0f671588

Bug: T174031
Change-Id: Ia31fc7b559f59d53bb503a59abf9110f0e65178c

5 years agoregistration: Follow-up on I54e8065c63f81016425c7dd40ce87e
Derick Alangi [Mon, 25 Mar 2019 15:56:14 +0000 (16:56 +0100)]
registration: Follow-up on I54e8065c63f81016425c7dd40ce87e

Change-Id: I610dfafcd180f89ee0e786f4516f9eb9c63a42b4

5 years agoMerge "objectcache: Remove unused variable $cache which is overriden"
jenkins-bot [Mon, 25 Mar 2019 15:47:44 +0000 (15:47 +0000)]
Merge "objectcache: Remove unused variable $cache which is overriden"

5 years agoMerge "Fix MessagecacheTest::testLoadFromDB_fetchLatestRevision"
jenkins-bot [Mon, 25 Mar 2019 15:47:29 +0000 (15:47 +0000)]
Merge "Fix MessagecacheTest::testLoadFromDB_fetchLatestRevision"

5 years agoMerge "changetags: Remove unnecessary semicolon after catch block"
jenkins-bot [Mon, 25 Mar 2019 15:38:54 +0000 (15:38 +0000)]
Merge "changetags: Remove unnecessary semicolon after catch block"

5 years agoUse Block::setTimestamp to set the timestamp on a block
Thalia [Mon, 25 Mar 2019 15:11:26 +0000 (15:11 +0000)]
Use Block::setTimestamp to set the timestamp on a block

Follow-up to I767ed44ce4c2e, where the setter was added.

Change-Id: I888e758aef44a101068bd52e89636e2656899f62

5 years agomw.feedback: Remove unused custom spinner
Ed Sanders [Mon, 25 Mar 2019 14:41:05 +0000 (14:41 +0000)]
mw.feedback: Remove unused custom spinner

Change-Id: I6d34006b943366045a69a89aa574c77be609440f

5 years agoMerge "Rename PoolCounter_Stub to PoolCounterNull"
jenkins-bot [Mon, 25 Mar 2019 14:59:25 +0000 (14:59 +0000)]
Merge "Rename PoolCounter_Stub to PoolCounterNull"

5 years agoMerge "rdbms: Drop unused constructor property and default method arg"
jenkins-bot [Mon, 25 Mar 2019 14:59:11 +0000 (14:59 +0000)]
Merge "rdbms: Drop unused constructor property and default method arg"

5 years agoMerge "DefaultSettings: Remove deprecated $wgDBmysql5 from core"
jenkins-bot [Mon, 25 Mar 2019 14:45:20 +0000 (14:45 +0000)]
Merge "DefaultSettings: Remove deprecated $wgDBmysql5 from core"

5 years agochangetags: Remove unnecessary semicolon after catch block
Derick Alangi [Mon, 25 Mar 2019 14:37:47 +0000 (15:37 +0100)]
changetags: Remove unnecessary semicolon after catch block

Change-Id: I89cc05dbbb8c0cf2382e251a3c144353af0906e5

5 years agoProvide direct deprecation message for jquery.ui.spinner
Ed Sanders [Mon, 25 Mar 2019 14:35:40 +0000 (14:35 +0000)]
Provide direct deprecation message for jquery.ui.spinner

The whole of jquery.ui is deprecated, but this provides
a more direct replacement suggestion for this module.

Change-Id: I1c09ca48765f3c82f2318fd53d679e4168e5d565

5 years agoobjectcache: Remove unused variable $cache which is overriden
Derick Alangi [Mon, 25 Mar 2019 14:20:19 +0000 (15:20 +0100)]
objectcache: Remove unused variable $cache which is overriden

This variable was defined to false and immediately overriden in the
if condition below it which makes the assignment above useless.

Change-Id: Ie72ec7a8860d2a38f59f38b3d861217d39da3e29

5 years agoMerge "rcfeed: Avoid extending/inheriting from a deprecated class"
jenkins-bot [Mon, 25 Mar 2019 14:10:21 +0000 (14:10 +0000)]
Merge "rcfeed: Avoid extending/inheriting from a deprecated class"

5 years agorcfeed: Avoid extending/inheriting from a deprecated class
Derick Alangi [Mon, 25 Mar 2019 13:27:22 +0000 (14:27 +0100)]
rcfeed: Avoid extending/inheriting from a deprecated class

Also, fix if...else syntax with return statement in the if block.

Change-Id: If14f0835731f264622cf90fcfd5c7cc850f63050

5 years agoregistration: Remove wrong `@return` PHPDoc comments
Derick Alangi [Mon, 25 Mar 2019 13:17:47 +0000 (14:17 +0100)]
registration: Remove wrong `@return` PHPDoc comments

$this->attributes is an array class property that gets set by the
method extractInfo(). This method really doesn't return an array
though in a sense $this->attributes gets set which can be used but
it's not returned.

Change-Id: I54e8065c63f81016425c7dd40ce87e1eb8ba0830

5 years agoMerge "Add filterFunction to visible{Byte,CodePoint}Limit"
jenkins-bot [Mon, 25 Mar 2019 12:42:29 +0000 (12:42 +0000)]
Merge "Add filterFunction to visible{Byte,CodePoint}Limit"

5 years agoFix MessagecacheTest::testLoadFromDB_fetchLatestRevision
daniel [Mon, 25 Mar 2019 10:47:53 +0000 (11:47 +0100)]
Fix MessagecacheTest::testLoadFromDB_fetchLatestRevision

This re-enables the "flaky" testLoadFromDB_fetchLatestRevision which
was disabled because it failed on random patches for no apparent
reason, as documented in T219042.

The reason was an invalid timestamp in the test data, which caused
the timestamp to default to "now", which was "sometimes" newer than
the timestamp of the revision immediately created before.

Bug: T219042
Bug: T218918
Change-Id: I38f4816b2dc735a7698626c7e3fe4a93ec95a9d1

5 years agoHISTORY: Add MediaWiki 1.19 post-release change notes
Nikita Rana [Sat, 23 Mar 2019 05:12:20 +0000 (10:42 +0530)]
HISTORY: Add MediaWiki 1.19 post-release change notes

Add MediaWiki 1.19 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.19

Bug:T213714
Change-Id: Ia3295c12938750337cfd42371a0ae72abfceff2c

5 years agoHISTORY: Add MediaWiki 1.18 post-release change notes
Nikita Rana [Sat, 23 Mar 2019 04:31:53 +0000 (10:01 +0530)]
HISTORY: Add MediaWiki 1.18 post-release change notes

Add MediaWiki 1.18 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.18

Bug:T213714
Change-Id: I2bea0ca7cb02d32fd24392fa167351851062ccb1

5 years agoHISTORY: Add MediaWiki 1.12 post-release change notes
Nikita Rana [Thu, 21 Mar 2019 07:06:20 +0000 (12:36 +0530)]
HISTORY: Add MediaWiki 1.12 post-release change notes

Add MediaWiki 1.12 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.12

Bug:T213714
Change-Id: Ib2d34bbb31525e4157d062bc4d89072098e106ce

5 years agoMerge "db: Drop child methods as they're same as parent methods"
jenkins-bot [Mon, 25 Mar 2019 09:35:22 +0000 (09:35 +0000)]
Merge "db: Drop child methods as they're same as parent methods"

5 years agospecialpage: Remove unused QueryPage::doFeed()
Thiemo Kreuz [Mon, 25 Mar 2019 08:17:06 +0000 (09:17 +0100)]
specialpage: Remove unused QueryPage::doFeed()

This code was written in 2004, and pretty much untouched since then.

The last non-trivial update to this code was done in 2014 via I1de6301.
But as far as I can tell this was just maintenance, not motivated by
somebody actually using this code.

I suspect this is unused for a long time already, long before 2014.
Possibly even unused in 2004. Really: I tried to dig into the revision
history of the core codebase to find when and where this was used, and
when it became unused. I could not find anything. I also used
https://codesearch.wmflabs.org to make sure there are no known callers
or subclasses hidden anywhere. I could not find anything either.

In conclusion I suggest to skip any deprecation phase.

Change-Id: I5f52c44760b903bcb348bebf8c6a0f6faf8180b7

5 years agordbms: Drop unused constructor property and default method arg
Derick Alangi [Sun, 24 Mar 2019 23:45:00 +0000 (00:45 +0100)]
rdbms: Drop unused constructor property and default method arg

Change-Id: Id83efd8f68b241ca0d7c5340cc2fd93379578fac

5 years agoUpdate some minor type hints
Thiemo Kreuz [Sun, 24 Mar 2019 14:07:01 +0000 (15:07 +0100)]
Update some minor type hints

Change-Id: If5a6372e79038d3750d30a931badd0c110da2fe5

5 years agoMerge "docs: Update outdated PageContentSave hook documentation"
jenkins-bot [Mon, 25 Mar 2019 06:40:12 +0000 (06:40 +0000)]
Merge "docs: Update outdated PageContentSave hook documentation"

5 years agoMerge "upload: Simplify file extension extraction in UploadBase"
jenkins-bot [Mon, 25 Mar 2019 06:33:58 +0000 (06:33 +0000)]
Merge "upload: Simplify file extension extraction in UploadBase"

5 years agoHISTORY: Add MediaWiki 1.11 post-release change notes
Nikita Rana [Wed, 20 Mar 2019 18:03:42 +0000 (23:33 +0530)]
HISTORY: Add MediaWiki 1.11 post-release change notes

Add MediaWiki 1.11 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.11

Bug:T213714
Change-Id: I3d0894a3f04b4d03b1a354c28025dc78a1b2e27b

5 years agoMerge "Use the ?? feature instead of isset() where it makes sense"
jenkins-bot [Mon, 25 Mar 2019 04:34:10 +0000 (04:34 +0000)]
Merge "Use the ?? feature instead of isset() where it makes sense"

5 years agoMerge "objectcache: remove BagOStuff::mergeViaLock() and update RESTBagOStuff"
jenkins-bot [Sun, 24 Mar 2019 23:55:59 +0000 (23:55 +0000)]
Merge "objectcache: remove BagOStuff::mergeViaLock() and update RESTBagOStuff"

5 years agodb: Drop child methods as they're same as parent methods
Derick Alangi [Sun, 24 Mar 2019 23:29:22 +0000 (00:29 +0100)]
db: Drop child methods as they're same as parent methods

Change-Id: I8b3827a57782f02497da2ab8191d1dad11e92bca

5 years agodb: Use variable functions/callbacks instead of call_user_func()
Derick Alangi [Sun, 24 Mar 2019 23:14:49 +0000 (00:14 +0100)]
db: Use variable functions/callbacks instead of call_user_func()

Performance-wise, this gives a little boost in performance and also
it's more readable I think. But I could be wrong so please someone
let me know.

See: https://www.php.net/manual/en/function.call-user-func.php

Change-Id: I2f0a00408c29549a786b56792411f88998a5f003

5 years agoblock: Use correct function wfGetDB() as defined
Derick Alangi [Sun, 24 Mar 2019 23:02:21 +0000 (00:02 +0100)]
block: Use correct function wfGetDB() as defined

Change-Id: I92ff76a9b62dec0f1e3253230676d4b5c0a877f0

5 years agoRename PoolCounter_Stub to PoolCounterNull
Umherirrender [Sun, 24 Mar 2019 21:44:46 +0000 (22:44 +0100)]
Rename PoolCounter_Stub to PoolCounterNull

Also move to own file
Remove "Stub", because it refers a php concept,
which is not used here

Change-Id: Ife952901b5ad8e4a408d229ee72de953a9acc220

5 years agoUse the ?? feature instead of isset() where it makes sense
Thiemo Kreuz [Sun, 24 Mar 2019 21:40:49 +0000 (22:40 +0100)]
Use the ?? feature instead of isset() where it makes sense

Change-Id: I3a54f36b33d99ef3ff4c63e32e7dfcbcfc296135