5 years agoMerge "WLFilters: new 'watchlist activity' filter group"
jenkins-bot [Fri, 18 Aug 2017 22:05:30 +0000 (22:05 +0000)]
Merge "WLFilters: new 'watchlist activity' filter group"

5 years agoMerge "WLFilters: convert mark as seen button to new style"
jenkins-bot [Fri, 18 Aug 2017 22:04:34 +0000 (22:04 +0000)]
Merge "WLFilters: convert mark as seen button to new style"

5 years agoMerge "Enable RCFilters app on Watchlist"
jenkins-bot [Fri, 18 Aug 2017 22:01:36 +0000 (22:01 +0000)]
Merge "Enable RCFilters app on Watchlist"

5 years agoDeprecate greys not part of WikimediaUI color palette any more
Volker E [Mon, 7 Aug 2017 16:45:11 +0000 (18:45 +0200)]
Deprecate greys not part of WikimediaUI color palette any more

Deprecating greys, which are not part of WikimediaUI color palette
any more:
- @colorGray3: #333;
- @colorGray6: #666;
- @colorGray8: #888;
- @colorGray9: #999;
- @colorGray11: #bbb;
- @colorGray13: #ddd;

See https://wikimedia.github.io/WikimediaUI-Style-Guide/visual-style_icons.html
for further information.

Bug: T152025
Change-Id: Iaef72470c59665682f4a54d0b754d41a2678f146

5 years agoWLFilters: new 'watchlist activity' filter group
Stephane Bisson [Fri, 18 Aug 2017 15:35:42 +0000 (11:35 -0400)]
WLFilters: new 'watchlist activity' filter group

Bug: T171127
Change-Id: I84bf122bd042dd9b8b5495cb59a2a8f7cb77eb55

5 years agoMerge "Remove deprecated jquery.mwExtension module"
jenkins-bot [Fri, 18 Aug 2017 19:43:52 +0000 (19:43 +0000)]
Merge "Remove deprecated jquery.mwExtension module"

5 years agoWLFilters: convert mark as seen button to new style
Stephane Bisson [Fri, 18 Aug 2017 14:52:24 +0000 (10:52 -0400)]
WLFilters: convert mark as seen button to new style

Bug: T171121
Change-Id: I52b3c318fe8270c857d9afebdfd7f440d56131c9

5 years agoEnable RCFilters app on Watchlist
Stephane Bisson [Thu, 3 Aug 2017 17:11:53 +0000 (13:11 -0400)]
Enable RCFilters app on Watchlist

* Add classes prefixed with cl (for ChangesList)
  to both RC and WL so that the JS app can locate
  similar elements using the same selectors

* Make saved queries preference name configurable
  so that RC and WL use different preferences

* Move some code from SpecialRecentchanges.php to
  its base class so it's accessible to SpecialWatchlist.php

To use the RCFilters app on WL, append ?rcfilters=1 to the URL

Bug: T171132
Bug: T171218
Change-Id: If7c63284224df24fa02022b4ea74bef116f28ca6

5 years agoMerge "Use json extension for .stylelintrc"
jenkins-bot [Fri, 18 Aug 2017 18:06:57 +0000 (18:06 +0000)]
Merge "Use json extension for .stylelintrc"

5 years agoMerge "Skin: Remove redundant use of QuickTemplate::setRef()"
jenkins-bot [Fri, 18 Aug 2017 15:39:18 +0000 (15:39 +0000)]
Merge "Skin: Remove redundant use of QuickTemplate::setRef()"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 18 Aug 2017 06:30:40 +0000 (08:30 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I7319928e9a7f6a9ec00cfcc27dba4e9a5fbf2f61

5 years agoRemove deprecated jquery.mwExtension module
Timo Tijhof [Fri, 18 Aug 2017 01:51:17 +0000 (18:51 -0700)]
Remove deprecated jquery.mwExtension module

* Deprecated since MediaWiki 1.26.

* Not used anywhere in Wikimedia Git.

* Grafana mw-js-deprecate dashboard shows < 1 hit per day on average
  for any of the jquery.mwExtension properties, during the past 3 weeks.
  Most days 0, some days 18 individual hits.
  By comparison, legacy wikibits before we removed it in May 2017 was down
  to about 6,000/24h (combined), so removal is quite overdue.

Change-Id: Ib66d1844b4fb8d7185b0e6607b9f98c1be632bb5

5 years agoMerge "rdbms: Support secondary autocommit connections in LoadBalancer"
jenkins-bot [Fri, 18 Aug 2017 01:38:01 +0000 (01:38 +0000)]
Merge "rdbms: Support secondary autocommit connections in LoadBalancer"

5 years agordbms: Support secondary autocommit connections in LoadBalancer
Aaron Schulz [Thu, 20 Jul 2017 03:51:54 +0000 (20:51 -0700)]
rdbms: Support secondary autocommit connections in LoadBalancer

This is useful for things like SqlBagOStuff and JobQueueDB
being able to write in auto-commit mode while the main
transaction round still goes on.

SqlBagOStuff already had this sort of logic.

JobQueueDB now also takes this approach so it does not have to
defer insertion except for sqlite. This makes callers more likely
to know when insertion failed or not.

Make sure LoadBalancer sets "master"/"replica" LB info itself;
this fixes a bug found in the new tests.

Bug: T140338
Bug: T42451
Change-Id: I4199a9598d7afbf976a6efa8ed84b85b56da02bd

5 years agoSkin: Remove redundant use of QuickTemplate::setRef()
Timo Tijhof [Thu, 17 Aug 2017 22:22:36 +0000 (15:22 -0700)]
Skin: Remove redundant use of QuickTemplate::setRef()

As part of long-term moving towards having skins consume prepared
data and not making additional run-time database queries or additional
PHP-specific semantics and global state, try to phase out use
of QuickTemplate::setRef(), which is incompatible with the idea of
data only flowing in one direction (given it allows the value to
change at any time).

* jsmimetype: Deprecated/unused, has a constant value for compat.
* mimetype: Obsolete, Content-Type header comes from OutputPage.
* skin: Objects are references by default, '$this' can't be
  modified anyway.

Bug: T140664
Change-Id: Ia505cc3e1b774a380fb36b4f0e2522550aef5bbd

5 years agoMerge "rdbms: Fix grammar in DBTransactionSizeError log message"
jenkins-bot [Thu, 17 Aug 2017 22:18:11 +0000 (22:18 +0000)]
Merge "rdbms: Fix grammar in DBTransactionSizeError log message"

5 years agoMerge "Make mysql getHeartbeatData() method not count query/RTT in estimate"
jenkins-bot [Thu, 17 Aug 2017 22:16:30 +0000 (22:16 +0000)]
Merge "Make mysql getHeartbeatData() method not count query/RTT in estimate"

5 years agoMerge "Restore the newFromId() approach in SpecialNewpages::feedItemDesc"
jenkins-bot [Thu, 17 Aug 2017 22:16:27 +0000 (22:16 +0000)]
Merge "Restore the newFromId() approach in SpecialNewpages::feedItemDesc"

5 years agordbms: Fix grammar in DBTransactionSizeError log message
Aaron Schulz [Thu, 17 Aug 2017 21:38:27 +0000 (14:38 -0700)]
rdbms: Fix grammar in DBTransactionSizeError log message

Change-Id: Icc09d674359012f60494b95a36127c14c1a8d630

5 years agoRestore the newFromId() approach in SpecialNewpages::feedItemDesc
Aaron Schulz [Thu, 17 Aug 2017 20:53:01 +0000 (13:53 -0700)]
Restore the newFromId() approach in SpecialNewpages::feedItemDesc

Trying to use the row data is problematic since the text related
fields are missing. This fixing a regression from 4475e1c8c.

Also make SpecialNewpages::feedItemDesc() handle null content.

Bug: T173541
Change-Id: I2213675d3392c6e9761bdc7acde35fd1caee4517

5 years agoMerge "RCFilters: Fix validation for single_option groups"
jenkins-bot [Thu, 17 Aug 2017 20:33:32 +0000 (20:33 +0000)]
Merge "RCFilters: Fix validation for single_option groups"

5 years agoMerge "rdbms: Rename "memCache" to "memStash" in LBFactory"
jenkins-bot [Thu, 17 Aug 2017 20:26:29 +0000 (20:26 +0000)]
Merge "rdbms: Rename "memCache" to "memStash" in LBFactory"

5 years agordbms: Rename "memCache" to "memStash" in LBFactory
Aaron Schulz [Thu, 17 Aug 2017 03:07:30 +0000 (20:07 -0700)]
rdbms: Rename "memCache" to "memStash" in LBFactory

This needs to be cross DC, so fix the name and comments.
Also update the one MWLBFactory reference to it.

Change-Id: I5ef10000276c300299fd1ece35ada0d78388bef7

5 years agoMerge "Support AJAX watch in skins that use a different class structure"
jenkins-bot [Thu, 17 Aug 2017 19:43:25 +0000 (19:43 +0000)]
Merge "Support AJAX watch in skins that use a different class structure"

5 years agoMerge "Remove "memCache" field from LoadBalancer"
jenkins-bot [Thu, 17 Aug 2017 19:33:37 +0000 (19:33 +0000)]
Merge "Remove "memCache" field from LoadBalancer"

5 years agoMake mysql getHeartbeatData() method not count query/RTT in estimate
Aaron Schulz [Thu, 17 Aug 2017 19:31:23 +0000 (12:31 -0700)]
Make mysql getHeartbeatData() method not count query/RTT in estimate

Optimize for the common case where lag does not strictly increase
during trip times instead of being pessimistic.

Change-Id: Ibb0e3faad23862d397e1cc2a9f7e2a8293fa5f2b

5 years agoRCFilters: Fix validation for single_option groups
Moriel Schottlender [Thu, 17 Aug 2017 18:27:44 +0000 (11:27 -0700)]
RCFilters: Fix validation for single_option groups

The single_option groups have a base definition that means they
always must have a value, and must never have more than one value.
The previous way we attempted to do that was confusing and missed
a case where after resetting filters, two values were selected before
one could be unselected, which then broke the behavior in the
entire group.

This fix reorganizes the validation when an item in the group is
selected or unselected to make sure the group retains its promised

Bug: T173303
Change-Id: I5758ec324a26c0e5e6f5c473d206e818a1d22523

5 years agoRCFilters UI: Correct full coverage message
Roan Kattouw [Sun, 13 Aug 2017 15:17:21 +0000 (11:17 -0400)]
RCFilters UI: Correct full coverage message

Not all groups have this behavior, so it's not accurate to say
that "Selecting all filters in *A* group" behaves this way.
Instead say "all filters in *THIS* group".

Change-Id: Iaa92db76b27a2b0175e1ba1c71d1ef087857e87e

5 years agoMerge "Revert "Localisation updates from https://translatewiki.net.""
jenkins-bot [Thu, 17 Aug 2017 17:04:52 +0000 (17:04 +0000)]
Merge "Revert "Localisation updates from https://translatewiki.net.""

5 years agoRemove "memCache" field from LoadBalancer
Aaron Schulz [Thu, 17 Aug 2017 05:14:48 +0000 (22:14 -0700)]
Remove "memCache" field from LoadBalancer

The only user was LoadMonitor, which is converted to only use
the WAN and server caches. Previously, the lock() calls there
were useless since LBFactory never injected "memcCache" to
LoadBalancer, ergo making it EmptyBagOStuff in LoadMonitor.

Change-Id: I0c7793d47b93b763dee478d16fb87ec637dc6cab

5 years agoRevert "Localisation updates from https://translatewiki.net."
Umherirrender [Thu, 17 Aug 2017 16:56:38 +0000 (16:56 +0000)]
Revert "Localisation updates from https://translatewiki.net."

Conflicts with Ia9e669376390a56e52422352840a5d9e2576b1a8

This reverts commit 26b883a2f8407847e673a23357035794b1c3ddc3.

Change-Id: I532b7d2782e9087cb6a5f114af5aac9ee14e3f2f

5 years agoMerge "Avoid lock acquisition errors for multi-title refreshlinks jobs"
jenkins-bot [Thu, 17 Aug 2017 16:55:54 +0000 (16:55 +0000)]
Merge "Avoid lock acquisition errors for multi-title refreshlinks jobs"

5 years agoAvoid lock acquisition errors for multi-title refreshlinks jobs
Aaron Schulz [Thu, 17 Aug 2017 09:01:30 +0000 (02:01 -0700)]
Avoid lock acquisition errors for multi-title refreshlinks jobs

Bug: T173462
Change-Id: I9dab9b4e5c4cae7306dc29bad9e62287d54b2281

5 years agoUse json extension for .stylelintrc
WMDE-Fisch [Thu, 17 Aug 2017 15:01:56 +0000 (17:01 +0200)]
Use json extension for .stylelintrc

Bug: T173516
Change-Id: I19e00ca6503b0212642bdb3a4735e0a52e43d670

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 17 Aug 2017 06:05:51 +0000 (08:05 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ibd0b5f8fac26cf59df39172d2297597b776a4aec

5 years agoMerge "RCFilters: tweak old changes indicator"
jenkins-bot [Thu, 17 Aug 2017 05:56:55 +0000 (05:56 +0000)]
Merge "RCFilters: tweak old changes indicator"

5 years agoMerge "RCFilters: Add marker between old and new changes in enhanced mode"
jenkins-bot [Thu, 17 Aug 2017 05:56:42 +0000 (05:56 +0000)]
Merge "RCFilters: Add marker between old and new changes in enhanced mode"

5 years agoMerge "database: make close() sanity check mTrxPreCommitCallbacks"
jenkins-bot [Thu, 17 Aug 2017 04:35:08 +0000 (04:35 +0000)]
Merge "database: make close() sanity check mTrxPreCommitCallbacks"

5 years agodatabase: make close() sanity check mTrxPreCommitCallbacks
Aaron Schulz [Thu, 17 Aug 2017 04:25:29 +0000 (21:25 -0700)]
database: make close() sanity check mTrxPreCommitCallbacks

The other callback types are already checked too.

Change-Id: Ibdc82110c0a0e74bb07ed92ee667bdf0d9f69f90

5 years agoHard-deprecate ProfileSection
Max Semenik [Sat, 12 Aug 2017 02:42:04 +0000 (19:42 -0700)]
Hard-deprecate ProfileSection

No usages anywhere, to be removed in 1.31

Change-Id: I3ed4c2aa07d97e18c026e9ee6dae66d3b023896f

5 years agoMerge "Restore non-mangled anchors in API help in all cases"
jenkins-bot [Wed, 16 Aug 2017 23:03:41 +0000 (23:03 +0000)]
Merge "Restore non-mangled anchors in API help in all cases"

5 years agoMerge ".gitignore: Ignore /composer.phar file"
jenkins-bot [Wed, 16 Aug 2017 22:29:45 +0000 (22:29 +0000)]
Merge ".gitignore: Ignore /composer.phar file"

5 years ago.gitignore: Ignore /composer.phar file
Huji Lee [Wed, 16 Aug 2017 10:32:27 +0000 (06:32 -0400)]
.gitignore: Ignore /composer.phar file

The file is needed if using composer via a phar file.

Change-Id: I910bc8929d0cf26d9d110eeb1051c4d41c25aa3c

5 years agoRestore non-mangled anchors in API help in all cases
Brad Jorsch [Wed, 2 Aug 2017 22:45:01 +0000 (18:45 -0400)]
Restore non-mangled anchors in API help in all cases

Prior to Id304010a, the API help included non-mangled anchors even when
$wgExperimentalHtmlIds was false. This was lost in Id304010a when the
new $wgFragmentMode is [ 'legacy' ], as is the default, despite the loss
being pointed out multiple times in code review.

Change-Id: Ibcb86deb4e3ea2131211f184f46960e5ad390212

5 years agoMerge "mediawiki.ui: Bring checkbox and radio on par with WikimediaUI design"
jenkins-bot [Wed, 16 Aug 2017 15:44:30 +0000 (15:44 +0000)]
Merge "mediawiki.ui: Bring checkbox and radio on par with WikimediaUI design"

5 years agoSupport AJAX watch in skins that use a different class structure
Kunal Mehta [Tue, 15 Aug 2017 20:34:55 +0000 (13:34 -0700)]
Support AJAX watch in skins that use a different class structure

Skipping links that are in #bodyContent or #content doesn't work for
skins like Timeless. Instead of trying to filter based on those classes,
have SkinTemplate set a data-mw=interface attribute on the <a> element,
and filter based on that. The Sanitizer prevents any data-mw attributes
being set by users, so it must have been created by MediaWiki, and
therefore safe to use.

If no link meets that criteria, then it will fallback to trying to find
a link using the old criteria of not being in #bodyContent or #content.

Bug: T173279
Change-Id: I1688a499dda40428dd514230b78ccded0d228ca3

5 years agomediawiki.ui: Bring checkbox and radio on par with WikimediaUI design
Volker E [Mon, 14 Aug 2017 22:30:23 +0000 (15:30 -0700)]
mediawiki.ui: Bring checkbox and radio on par with WikimediaUI design

Bringing checkbox and radio on par with WikimediaUI design templates,
also slightly enhancing accessibility by using colors of new palette.
Width & height is taken from current OOUI size, based on 14px Vector base
Adding several similar variables to variables.less, which will be replaced
by WikimediaUI Base vars in future.
- removing necessity for images for radio checked states
- replacing `margin` with `padding` between widget and label in order to
  have `cursor: pointer` on full element

Bug: T148265
Change-Id: I68848d48ea45c67124ac75be58748b4e9fb3085d

5 years agoFix spacing for @param and indent of function comments
Umherirrender [Fri, 11 Aug 2017 21:45:25 +0000 (23:45 +0200)]
Fix spacing for @param and indent of function comments

In phpcs.xml rename renamed sniffs and add the failing sniffs,
because now the whole sniff is no longer excluded.

Change-Id: If5b0bd16028761abc2c47ace9e97d37ad14bb36f

5 years agoMerge "RCFilters: preserve invert parameter in saved queries"
jenkins-bot [Tue, 15 Aug 2017 06:14:35 +0000 (06:14 +0000)]
Merge "RCFilters: preserve invert parameter in saved queries"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 15 Aug 2017 06:04:52 +0000 (08:04 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I95727cea51152a116d75a2843d837cedbff53566

5 years agoMerge "Move RawMessage out of Message.php to its own file"
jenkins-bot [Tue, 15 Aug 2017 04:48:46 +0000 (04:48 +0000)]
Merge "Move RawMessage out of Message.php to its own file"

5 years agoMerge "Make Special:NewPages show "originally created as" correctly"
jenkins-bot [Mon, 14 Aug 2017 17:40:09 +0000 (17:40 +0000)]
Merge "Make Special:NewPages show "originally created as" correctly"

5 years agoMove RawMessage out of Message.php to its own file
Florian Schmidt [Mon, 14 Aug 2017 16:31:39 +0000 (18:31 +0200)]
Move RawMessage out of Message.php to its own file

Change-Id: Idae9617dafa3c314085eb097f78f1c8d38672f31

5 years agoMerge "Perform a permission check on the title when changing the page language"
jenkins-bot [Mon, 14 Aug 2017 16:48:17 +0000 (16:48 +0000)]
Merge "Perform a permission check on the title when changing the page language"

5 years agoMerge "Special:Newpages feed now shows first revision instead of latest revision"
jenkins-bot [Mon, 14 Aug 2017 16:33:19 +0000 (16:33 +0000)]
Merge "Special:Newpages feed now shows first revision instead of latest revision"

5 years agoChange WikiImporter to now requires the second parameter to be an instance of the...
Matthew Bowker [Sun, 13 Aug 2017 22:54:26 +0000 (16:54 -0600)]
Change WikiImporter to now requires the second parameter to be an instance of the Config class.

Prior to this change, the second parameter to WikiImporter was optional.  If the parameter didn't exist, it would get filled in with a MediaWikiServices::getInstance()->getMainConfig().  It would also emit a hard deprecation warning. This behavior has existed since 1.25.

Bug: T61113
Change-Id: Ic15cc103c7d2b7fb499f1632c0001b8a3dbdf778

5 years agoMerge "Ignore errors in RedisConnectionPool destructor"
jenkins-bot [Mon, 14 Aug 2017 15:01:28 +0000 (15:01 +0000)]
Merge "Ignore errors in RedisConnectionPool destructor"

5 years agoIgnore errors in RedisConnectionPool destructor
Gergő Tisza [Sun, 13 Aug 2017 14:18:18 +0000 (14:18 +0000)]
Ignore errors in RedisConnectionPool destructor

The destructor can be called on shutdown so any operation which
relies on another object or resource can fail. E.g. running
anything involving Redis (such as >>new Message('').''<<)
from shell.php and then exiting will result in a RedisException
since the PHP engine closes the Redis connection before destroying
the connection pool. Such errors can be safely ignored.

Change-Id: I38474a9dda89c82edbcb878facb4a97740e9189a

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 14 Aug 2017 06:20:23 +0000 (08:20 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If08fcdfd7268397691d725d198d222f9fce9cfbb

5 years agoRemove deprecated MagicWord::replaceMultiple()
Max Semenik [Sat, 12 Aug 2017 02:46:54 +0000 (19:46 -0700)]
Remove deprecated MagicWord::replaceMultiple()

wfDeprecated since 1.25, not used anywhere.

Change-Id: I09fd362a3d795328ffc12572025702ef9b951378

5 years agoMerge "BaseTemplate: Handle `$this->data['language_urls'] === false` specially"
jenkins-bot [Sun, 13 Aug 2017 20:19:19 +0000 (20:19 +0000)]
Merge "BaseTemplate: Handle `$this->data['language_urls'] === false` specially"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 13 Aug 2017 20:09:09 +0000 (22:09 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I324f599c4c46011cf7348ca75fc1d08e1beafe3f

5 years agoMerge "jquery.tablesorter: Improve detection and handling of isoDate"
jenkins-bot [Sun, 13 Aug 2017 18:02:49 +0000 (18:02 +0000)]
Merge "jquery.tablesorter: Improve detection and handling of isoDate"

5 years agojquery.tablesorter: Improve detection and handling of isoDate
madd [Sun, 8 May 2016 16:31:58 +0000 (18:31 +0200)]
jquery.tablesorter: Improve detection and handling of isoDate

* Detect years 0...99 correct.
* Short forms possible: JJJJ, JJJJ-MM, JJJJMM, JJJJMMTT
  QUnit Test sorts now with parser 'isoDate' (because of 2009 former test sorts with parser 'text')
* Prefix and postfix allowed.
* Between date and time a 'T' or 'any white space' is allowed (Bug: T126886)

Bug: T126886
Change-Id: I664b4cc9d5fb472ea0bc0e36a3c209f04048e769

5 years agoRemove test code that depends on extension
Matthias Mullie [Tue, 11 Jul 2017 14:35:49 +0000 (16:35 +0200)]
Remove test code that depends on extension

And allow extensions to add their own media handlers.

I'm not too happy with the introduction of another global,
but didn't like the alternatives either:
* Add some hook to MockMediaHandlerFactory that would allow
  extensions to add their own stuff in.
* Use another hook (like ParserTestTables or ParserTestGlobals)
  and then override the service with a new instance - seemed
  too hacky
The good thing about this is that it lets us kill off a class.
I'm other to other suggestions in case I missed something.

Bug: T169258
Depends-On: I5875621c58597426ad5242bf3d07714555c439b5
Change-Id: I1c2e903fb235395a8de8e0f7bf65ce07739d2930

5 years agoUnwatch link for pages in Special:Watchlist
Geoffrey Mon [Sat, 11 Jun 2016 00:59:58 +0000 (20:59 -0400)]
Unwatch link for pages in Special:Watchlist

When the 'watchlistunwatchlinks' preference option is enabled, this
adds a '×' link to each entry of the watchlist that unwatches the page
of that entry. When clicked, it changes into a '+' which can be used to
re-watch the page (effectively undoing the earlier unwatch).
When a page is unwatched, its entries and the entries of its associated
talk page (or vice versa) become translucent and are struck through.

Without JS, '×'/'+' link to action=(un)watch for the relevant page.

In addition, ChangesList classes have been modified to allow a prefixer
that adds a prefix to each line (used in this case to put the unwatch
link) and to add HTML data attributes to reliably determine the target
page of each entry. Unit tests have been updated accordingly.

Bug: T2424
Change-Id: I450b2901413d7e75c11de2a446829fdbb22d31e1

5 years agoMerge "Warn users when installing on a 32-bit system"
jenkins-bot [Sat, 12 Aug 2017 21:08:05 +0000 (21:08 +0000)]
Merge "Warn users when installing on a 32-bit system"

5 years agoWarn users when installing on a 32-bit system
Chad Horohoe [Mon, 31 Jul 2017 22:28:47 +0000 (15:28 -0700)]
Warn users when installing on a 32-bit system

Don't fail to install, because we don't explicitly need to break
32-bit support. But in this day and age it's becoming increasingly
likely to break things on a 32-bit system. So let's at least let
a system admin know that YMMV.

Change-Id: Ifb3bfa049532d82f67fe4375944af1516400513c

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 12 Aug 2017 19:57:43 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic427ce81276365b5e4ce288bd1b330850592ac81

5 years agoMerge "Disallow job pushes from JobQueueGroup to bogus wikis"
jenkins-bot [Sat, 12 Aug 2017 18:48:27 +0000 (18:48 +0000)]
Merge "Disallow job pushes from JobQueueGroup to bogus wikis"

5 years agoMerge "Fix 'logName' parameter (5th) in many uses of mw.log.deprecate"
jenkins-bot [Sat, 12 Aug 2017 17:21:53 +0000 (17:21 +0000)]
Merge "Fix 'logName' parameter (5th) in many uses of mw.log.deprecate"

5 years agoMerge "mw.util: Add a deprecation message to escapeId()"
jenkins-bot [Sat, 12 Aug 2017 17:19:46 +0000 (17:19 +0000)]
Merge "mw.util: Add a deprecation message to escapeId()"

5 years agoDo not use broken bootstrap in phpcs.xml
Umherirrender [Fri, 11 Aug 2017 13:12:05 +0000 (15:12 +0200)]
Do not use broken bootstrap in phpcs.xml

The bootstrap in mediawiki-codesniffer is broken, because it was not
adjust when PHP CodeSniffer Version 3.0.0 was used. Remove the broken

Bug: T172933
Change-Id: I29e776662055077f6de3a9bc6d0869120b387ea7

5 years agoDisallow job pushes from JobQueueGroup to bogus wikis
Aaron Schulz [Thu, 10 Aug 2017 00:13:49 +0000 (17:13 -0700)]
Disallow job pushes from JobQueueGroup to bogus wikis

Bug: T171371
Change-Id: I03a5dbd18cf6b5bcacb3ec07cef9e0b051bc147c

5 years agoMerge "Add missing @param and @return documentation"
jenkins-bot [Fri, 11 Aug 2017 21:32:58 +0000 (21:32 +0000)]
Merge "Add missing @param and @return documentation"

5 years agoMerge "Add missing type to @param documentation"
jenkins-bot [Fri, 11 Aug 2017 21:31:51 +0000 (21:31 +0000)]
Merge "Add missing type to @param documentation"

5 years agoMerge "update mediawiki-codesniffer to 0.11.0 and fix issues"
jenkins-bot [Fri, 11 Aug 2017 20:43:52 +0000 (20:43 +0000)]
Merge "update mediawiki-codesniffer to 0.11.0 and fix issues"

5 years agoupdate mediawiki-codesniffer to 0.11.0 and fix issues
WMDE-Fisch [Fri, 11 Aug 2017 13:53:17 +0000 (15:53 +0200)]
update mediawiki-codesniffer to 0.11.0 and fix issues

- mostly auto fixes
- some too long lines fixed
- ignore amp space in one case  passing by reference

Change-Id: I6472f83bc3cbf4bd629d83050cc3319b19ec465c

5 years agoAdd missing @param and @return documentation
Umherirrender [Fri, 11 Aug 2017 18:04:11 +0000 (20:04 +0200)]
Add missing @param and @return documentation

Change-Id: I1d1098eec3933df6561cceef646576013ddc08c8

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 11 Aug 2017 20:03:27 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4e8ad1e97a08441dad773c8435309df93ab347d9

5 years agoAdd missing type to @param documentation
Umherirrender [Fri, 11 Aug 2017 15:46:31 +0000 (17:46 +0200)]
Add missing type to @param documentation

Change-Id: I6b2c9c7af9a281fe457099cc3a336a60a25e74aa

5 years agoMerge "Use correct variable name in @param documentation"
jenkins-bot [Fri, 11 Aug 2017 18:31:37 +0000 (18:31 +0000)]
Merge "Use correct variable name in @param documentation"

5 years agoMerge "Add missing & to @param documentation to match functon call"
jenkins-bot [Fri, 11 Aug 2017 18:29:05 +0000 (18:29 +0000)]
Merge "Add missing & to @param documentation to match functon call"

5 years agoMerge "Fixing styling of interwiki results header"
jenkins-bot [Fri, 11 Aug 2017 18:22:15 +0000 (18:22 +0000)]
Merge "Fixing styling of interwiki results header"

5 years agoUse correct variable name in @param documentation
Umherirrender [Fri, 11 Aug 2017 16:09:41 +0000 (18:09 +0200)]
Use correct variable name in @param documentation

For some varargs a variable name is added with suffix ,... as seen for
many other varargs

Some @param are swapped, because there are in the wrong order

Enable Sniff MediaWiki.Commenting.FunctionComment.ParamNameNoMatch

Change-Id: I60fec6025bce824d5c67563ab7b65ad6cd628ad8

5 years agoAdd missing & to @param documentation to match functon call
Umherirrender [Fri, 11 Aug 2017 00:23:16 +0000 (02:23 +0200)]
Add missing & to @param documentation to match functon call

Change-Id: I81e68310abcbc59964b22e0e74842d509f6b1fb9

5 years agoMerge "Make phpcs pass"
jenkins-bot [Fri, 11 Aug 2017 15:18:48 +0000 (15:18 +0000)]
Merge "Make phpcs pass"

5 years agoChange @inheritdoc to @inheritDoc
Umherirrender [Fri, 11 Aug 2017 14:49:52 +0000 (16:49 +0200)]
Change @inheritdoc to @inheritDoc

Only @inheritDoc works for the Sniff

Change-Id: I91fc02cda6701d790e4334fc2bc47f230955545c

5 years agoMake phpcs pass
Umherirrender [Fri, 11 Aug 2017 14:22:42 +0000 (16:22 +0200)]
Make phpcs pass

Reenable MediaWiki.WhiteSpace.SpaceBeforeClassBrace.NoSpaceBeforeBrace,
because the mentioned bug is fixed

Bug: T172933
Change-Id: I1593bdba2295ebed401b921f2beabed69dba7638

5 years agoMerge "SpecialDoubleRedirects: Fix undefined '$result->namespace' notice"
jenkins-bot [Thu, 10 Aug 2017 22:45:40 +0000 (22:45 +0000)]
Merge "SpecialDoubleRedirects: Fix undefined '$result->namespace' notice"

5 years agoMerge "Create new table to be used for querying IP ranges."
jenkins-bot [Thu, 10 Aug 2017 21:45:54 +0000 (21:45 +0000)]
Merge "Create new table to be used for querying IP ranges."

5 years agoCreate new table to be used for querying IP ranges.
MusikAnimal [Wed, 9 Aug 2017 21:34:09 +0000 (17:34 -0400)]
Create new table to be used for querying IP ranges.

When revisions by logged out users are created, they will get copied
to this table. We can then JOIN it with revision when querying for
ranges at Special:Contributions.

DBA approval for this table can be found at T156318

Bug: T163562

Change-Id: I6593eb13701128faa782691a6b25ec01869c827d

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 10 Aug 2017 20:26:18 +0000 (22:26 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib722424a58bbb3d15c56c70ba29732f2be2d6669

5 years agoSpecialDoubleRedirects: Fix undefined '$result->namespace' notice
Timo Tijhof [Thu, 10 Aug 2017 20:26:08 +0000 (16:26 -0400)]
SpecialDoubleRedirects: Fix undefined '$result->namespace' notice

Follows-up 7be1a8c0bc4d29d.

$result is used for both the original and the on-demand deep
query (in case of cache). However this re-query can fail if the
page no longer exists.

This used to be accounted for by creating the Title object before
(possibly) trying to re-query, and also checked for with "if !$result",
which is only intended to happen if the re-query failed (the initial
value of $result comes from the main (cacheable) query, and always

Could be moved by moving the $titleA assignment back up, but that
doesn't address the confusion problem that led to this.

Fix it by using a separate variable names.

Bug: T173045
Change-Id: I0e9ae89a3772b33b916b506033bd334ade5f03fa

5 years agoMerge "Add new static function LanguageCode::replaceDeprecatedCodes"
jenkins-bot [Thu, 10 Aug 2017 20:04:34 +0000 (20:04 +0000)]
Merge "Add new static function LanguageCode::replaceDeprecatedCodes"

5 years agoMerge "Make it possible for subclasses to provide a different form"
jenkins-bot [Thu, 10 Aug 2017 19:49:41 +0000 (19:49 +0000)]
Merge "Make it possible for subclasses to provide a different form"

5 years agoAdd new static function LanguageCode::replaceDeprecatedCodes
Fomafix [Tue, 27 Jun 2017 14:25:01 +0000 (16:25 +0200)]
Add new static function LanguageCode::replaceDeprecatedCodes

Refactor the deprecatedLanguageCodeMapping to a private variable.

Change-Id: I5f8e601e53de183e6268c9ef601eef8390b725cd

5 years agoMerge "Rename autonym for 'no' from 'norsk bokmål' to 'norsk'"
jenkins-bot [Thu, 10 Aug 2017 19:21:27 +0000 (19:21 +0000)]
Merge "Rename autonym for 'no' from 'norsk bokmål' to 'norsk'"

5 years agoMerge "Document Special:Diff and Special:PermanentLink"
jenkins-bot [Thu, 10 Aug 2017 18:22:31 +0000 (18:22 +0000)]
Merge "Document Special:Diff and Special:PermanentLink"

5 years agoMerge "mediawiki.toc.print.css: Restore ID selector #toc"
jenkins-bot [Thu, 10 Aug 2017 18:12:54 +0000 (18:12 +0000)]
Merge "mediawiki.toc.print.css: Restore ID selector #toc"