From: Derick Alangi <alangiderick@gmail.com>
Date: Tue, 14 May 2019 11:28:35 +0000 (+0100)
Subject: SearchResult: MW version number should be a string in wfDeprecated call
X-Git-Tag: 1.34.0-rc.0~1694
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=facddc488ae8714e1f41035599a8f54056d0ab2f

SearchResult: MW version number should be a string in wfDeprecated call

Seems this was a typo and I think 1.32 which is a double/float will be
implicitly converted to true (bool) because it will resolve 1.32 to 1 as
integer and then 1 which maps to true (bool).

To avoid this, use '1.32' instead of the integer form of the version.

Change-Id: I2420396e110284f582cd79820ffc6064e247b4b9
---

diff --git a/includes/search/SearchResult.php b/includes/search/SearchResult.php
index bd19a84e32..f85c58fe2d 100644
--- a/includes/search/SearchResult.php
+++ b/includes/search/SearchResult.php
@@ -285,7 +285,7 @@ class SearchResult {
 		if ( $extensionData instanceof Closure ) {
 			$this->extensionData = $extensionData;
 		} elseif ( is_array( $extensionData ) ) {
-			wfDeprecated( __METHOD__ . ' with array argument', 1.32 );
+			wfDeprecated( __METHOD__ . ' with array argument', '1.32' );
 			$this->extensionData = function () use ( $extensionData ) {
 				return $extensionData;
 			};