From: James D. Forrester <jforrester@wikimedia.org>
Date: Fri, 12 Jul 2019 23:20:57 +0000 (-0700)
Subject: Drop NS_IMAGE and NS_IMAGE_TALK, deprecated in 1.14
X-Git-Tag: 1.34.0-rc.0~998^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=f70d270877e489c3da4a127c467544e4fc915b08

Drop NS_IMAGE and NS_IMAGE_TALK, deprecated in 1.14

Change-Id: Id980c3d9bbadae219181b07f22aa58cbc2efbdc6
---

diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34
index 44f69c7ea8..ea46a7d3a8 100644
--- a/RELEASE-NOTES-1.34
+++ b/RELEASE-NOTES-1.34
@@ -222,6 +222,8 @@ because of Phabricator reports.
   specified, deprecated in 1.30, have been removed.
 * BufferingStatsdDataFactory::getBuffer(), deprecated in 1.30, has been removed.
 * The constant DB_SLAVE, deprecated in 1.28, has been removed. Use DB_REPLICA.
+* The constants NS_IMAGE and NS_IMAGE_TALK, deprecated in 1.14, have been
+  removed. Use NS_FILE and NS_FILE_TALK respectively.
 * Replacer, DoubleReplacer, HashtableReplacer and RegexlikeReplacer
   (deprecated in 1.32) have been removed. Closures should be used instead.
 * OutputPage::addWikiText(), ::addWikiTextWithTitle(), ::addWikiTextTitleTidy(),
diff --git a/includes/Defines.php b/includes/Defines.php
index 648e493b91..d818226974 100644
--- a/includes/Defines.php
+++ b/includes/Defines.php
@@ -73,22 +73,6 @@ define( 'NS_HELP', 12 );
 define( 'NS_HELP_TALK', 13 );
 define( 'NS_CATEGORY', 14 );
 define( 'NS_CATEGORY_TALK', 15 );
-
-/**
- * NS_IMAGE and NS_IMAGE_TALK are the pre-v1.14 names for NS_FILE and
- * NS_FILE_TALK respectively, and are kept for compatibility.
- *
- * When writing code that should be compatible with older MediaWiki
- * versions, either stick to the old names or define the new constants
- * yourself, if they're not defined already.
- *
- * @deprecated since 1.14
- */
-define( 'NS_IMAGE', NS_FILE );
-/**
- * @deprecated since 1.14
- */
-define( 'NS_IMAGE_TALK', NS_FILE_TALK );
 /**@}*/
 
 /**@{