From: Gergő Tisza <tgr.huwiki@gmail.com>
Date: Thu, 6 Jun 2019 14:21:21 +0000 (+0200)
Subject: Log headers sent errors more usefully in thumb.php
X-Git-Tag: 1.34.0-rc.0~1504^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=e25c45e2e3c8e6465fcd7edefd24156bd7b11a11;ds=sidebyside

Log headers sent errors more usefully in thumb.php

Bug: T225197
Change-Id: Ifcb02b3d5794061f27c005b32164ac014f926357
---

diff --git a/thumb.php b/thumb.php
index 43dd5d472f..cf9bd2cdfe 100644
--- a/thumb.php
+++ b/thumb.php
@@ -409,6 +409,8 @@ function wfProxyThumbnailRequest( $img, $thumbName ) {
 	// Send request to proxied service
 	$status = $req->execute();
 
+	MediaWiki\HeaderCallback::warnIfHeadersSent();
+
 	// Simply serve the response from the proxied service as-is
 	header( 'HTTP/1.1 ' . $req->getStatus() );
 
@@ -634,6 +636,8 @@ function wfThumbErrorText( $status, $msgText ) {
 function wfThumbError( $status, $msgHtml, $msgText = null, $context = [] ) {
 	global $wgShowHostnames;
 
+	MediaWiki\HeaderCallback::warnIfHeadersSent();
+
 	header( 'Cache-Control: no-cache' );
 	header( 'Content-Type: text/html; charset=utf-8' );
 	if ( $status == 400 || $status == 404 || $status == 429 ) {