From: RazeSoldier <razesoldier@outlook.com>
Date: Wed, 17 Jul 2019 17:52:18 +0000 (+0800)
Subject: MediaWikiUnitTestCase: Use DIRECTORY_SEPARATOR instead of `/`
X-Git-Tag: 1.34.0-rc.0~945^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=d94906eaa20ccb0d36277d1172dba8f512c6497f

MediaWikiUnitTestCase: Use DIRECTORY_SEPARATOR instead of `/`

`strpos( $reflection->getFilename(), '/unit/' )` will always
return FALSE under Windows

Change-Id: Ib13d32858e238b9a18094f829939f6bba08366ab
---

diff --git a/tests/phpunit/MediaWikiUnitTestCase.php b/tests/phpunit/MediaWikiUnitTestCase.php
index 43a333cb88..5f7746b3e6 100644
--- a/tests/phpunit/MediaWikiUnitTestCase.php
+++ b/tests/phpunit/MediaWikiUnitTestCase.php
@@ -36,7 +36,8 @@ abstract class MediaWikiUnitTestCase extends TestCase {
 	protected function setUp() {
 		parent::setUp();
 		$reflection = new ReflectionClass( $this );
-		if ( strpos( $reflection->getFilename(), '/unit/' ) === false ) {
+		$dirSeparator = DIRECTORY_SEPARATOR;
+		if ( strpos( $reflection->getFilename(), "${dirSeparator}unit${dirSeparator}" ) === false ) {
 			$this->fail( 'This unit test needs to be in "tests/phpunit/unit" !' );
 		}
 		$this->unitGlobals = $GLOBALS;