From: Matěj Suchánek <matejsuchanek97@gmail.com>
Date: Fri, 13 Sep 2019 09:51:52 +0000 (+0200)
Subject: Remove dead code from RCCacheEntryFactory
X-Git-Tag: 1.34.0-rc.0~216^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=bfd32fc842872061ee96fb1f0894d9e2f7d8e835

Remove dead code from RCCacheEntryFactory

Change-Id: I7832bac1e9c700e4a2a37b765d257ce8a7ace458
---

diff --git a/includes/changes/RCCacheEntryFactory.php b/includes/changes/RCCacheEntryFactory.php
index d448eae4a1..90246a0d6d 100644
--- a/includes/changes/RCCacheEntryFactory.php
+++ b/includes/changes/RCCacheEntryFactory.php
@@ -56,7 +56,6 @@ class RCCacheEntryFactory {
 	 */
 	public function newFromRecentChange( RecentChange $baseRC, $watched ) {
 		$user = $this->context->getUser();
-		$counter = $baseRC->counter;
 
 		$cacheEntry = RCCacheEntry::newFromParent( $baseRC );
 
@@ -73,8 +72,8 @@ class RCCacheEntryFactory {
 		// called too many times (50% of CPU time on RecentChanges!).
 		$showDiffLinks = $this->showDiffLinks( $cacheEntry, $user );
 
-		$cacheEntry->difflink = $this->buildDiffLink( $cacheEntry, $showDiffLinks, $counter );
-		$cacheEntry->curlink = $this->buildCurLink( $cacheEntry, $showDiffLinks, $counter );
+		$cacheEntry->difflink = $this->buildDiffLink( $cacheEntry, $showDiffLinks );
+		$cacheEntry->curlink = $this->buildCurLink( $cacheEntry, $showDiffLinks );
 		$cacheEntry->lastlink = $this->buildLastLink( $cacheEntry, $showDiffLinks );
 
 		// Make user links
@@ -182,11 +181,10 @@ class RCCacheEntryFactory {
 	/**
 	 * @param RecentChange $cacheEntry
 	 * @param bool $showDiffLinks
-	 * @param int $counter
 	 *
 	 * @return string
 	 */
-	private function buildCurLink( RecentChange $cacheEntry, $showDiffLinks, $counter ) {
+	private function buildCurLink( RecentChange $cacheEntry, $showDiffLinks ) {
 		$queryParams = $this->buildCurQueryParams( $cacheEntry );
 		$curMessage = $this->getMessage( 'cur' );
 		$logTypes = [ RC_LOG ];
@@ -217,11 +215,10 @@ class RCCacheEntryFactory {
 	/**
 	 * @param RecentChange $cacheEntry
 	 * @param bool $showDiffLinks
-	 * @param int $counter
 	 *
 	 * @return string
 	 */
-	private function buildDiffLink( RecentChange $cacheEntry, $showDiffLinks, $counter ) {
+	private function buildDiffLink( RecentChange $cacheEntry, $showDiffLinks ) {
 		$queryParams = $this->buildDiffQueryParams( $cacheEntry );
 		$diffMessage = $this->getMessage( 'diff' );
 		$logTypes = [ RC_NEW, RC_LOG ];