From: jenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Date: Sun, 30 Jun 2019 15:43:33 +0000 (+0000)
Subject: Merge "Avoid :checkbox Sizzle selector"
X-Git-Tag: 1.34.0-rc.0~1233
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=b98ed398ff9646f7423368f53f2a27d1fbb709a0;hp=344481f60d92ac9295129c5089c0fe467ff497b9

Merge "Avoid :checkbox Sizzle selector"
---

diff --git a/resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js b/resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js
index 7d69fb6be1..5d6eaef81d 100644
--- a/resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js
@@ -71,7 +71,7 @@ FormWrapperWidget.prototype.onFormSubmit = function ( e ) {
 	$( e.target ).find( 'input:not([type="hidden"],[type="submit"]), select' ).each( function () {
 		var value = '';
 
-		if ( !$( this ).is( ':checkbox' ) || $( this ).is( ':checked' ) ) {
+		if ( !$( this ).is( '[type="checkbox"]' ) || $( this ).is( ':checked' ) ) {
 			value = $( this ).val();
 		}
 
diff --git a/resources/src/mediawiki.special.mute.js b/resources/src/mediawiki.special.mute.js
index 3d494d02ea..b9dcc21ab5 100644
--- a/resources/src/mediawiki.special.mute.js
+++ b/resources/src/mediawiki.special.mute.js
@@ -2,7 +2,7 @@
 	'use strict';
 
 	$( function () {
-		var $inputs = $( '#mw-specialmute-form input:checkbox' ),
+		var $inputs = $( '#mw-specialmute-form input[type="checkbox"]' ),
 			saveButton, $saveButton = $( '#save' );
 
 		function isFormChanged() {