From: Tim Starling <tstarling@wikimedia.org>
Date: Wed, 19 Sep 2018 05:38:28 +0000 (+1000)
Subject: Use binary charset in default table options
X-Git-Tag: 1.34.0-rc.0~3999^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=9bea45eab77f731aaba56b69aa9432f41d199ef8

Use binary charset in default table options

$wgDBTableOptions is overridden in the installer-generated
LocalSettings.php, and is always set to binary now that the installer UI
option has been removed. However, the value from DefaultSettings.php is
used when the installer installs an extension, since in this case
DatabaseUpdater is called without reading the generated
LocalSettings.php.

Binary is almost certainly the right answer since many extensions can't
even be installed without this option, they hit a key length error.

Change-Id: I87df736a4d9e49c9535d55bd556e636500ca203f
---

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index ab67225ca5..6515083b80 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -1931,7 +1931,7 @@ $wgDBprefix = '';
 /**
  * MySQL table options to use during installation or update
  */
-$wgDBTableOptions = 'ENGINE=InnoDB';
+$wgDBTableOptions = 'ENGINE=InnoDB, DEFAULT CHARSET=binary';
 
 /**
  * SQL Mode - default is turning off all modes, including strict, if set.