From: Rohan <rohan1395@yahoo.com>
Date: Sun, 15 Jun 2014 17:47:49 +0000 (+0530)
Subject: UploadFromUrl: Display an error to the user on invalid wpUploadFileURL
X-Git-Tag: 1.31.0-rc.0~9895
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=924a40410b42c56e389d03d871df31364ee69159

UploadFromUrl: Display an error to the user on invalid wpUploadFileURL

Removes check for URL validity from UploadFromUrl::isValidRequest()
so that an error can be thrown later and displayed to the user.

Bug: T34361
Change-Id: Idf4cfcd6199ef6e875f760e46db98248ba53a327
---

diff --git a/includes/upload/UploadFromUrl.php b/includes/upload/UploadFromUrl.php
index f57874512c..f897a796b9 100644
--- a/includes/upload/UploadFromUrl.php
+++ b/includes/upload/UploadFromUrl.php
@@ -175,7 +175,6 @@ class UploadFromUrl extends UploadBase {
 		$url = $request->getVal( 'wpUploadFileURL' );
 
 		return !empty( $url )
-			&& Http::isValidURI( $url )
 			&& $wgUser->isAllowed( 'upload_by_url' );
 	}