From: Timo Tijhof <krinklemail@gmail.com>
Date: Wed, 28 Aug 2019 00:41:42 +0000 (+0100)
Subject: profiler: Centralise output responsibility from ProfilerOutputText to Profiler
X-Git-Tag: 1.34.0-rc.0~509^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=8a87ec277858c4e72e8f654627c5363ec979771b;hp=8a87ec277858c4e72e8f654627c5363ec979771b

profiler: Centralise output responsibility from ProfilerOutputText to Profiler

Make it Profiler.php's responsibility to enforce this, based on the
existing signal from ProfilerOutput::logsToOutput().

The ProfilerOutputText class should not have to double-check this
a second time.

Long-term, I'd like even this check in Profiler::logDataPageOutputOnly
to be removed, because really the external caller of that should
know whether it is safe to output stuff or not rather than stashing
its own state inside Profiler::$allowOutput and then implicitly
reading it back out again later on. But, that's for another time.

Also:
* Remove use of deprecated Profiler::setTemplated while at it.
* Make 'visible' parameter explicit, as for other parameters.

Change-Id: Iaa3fc4ea25a059b90235d769db60c04b8f152f05
---