From: Kunal Mehta <legoktm@member.fsf.org>
Date: Fri, 29 Dec 2017 23:44:13 +0000 (-0800)
Subject: Add @covers tags for more tests
X-Git-Tag: 1.31.0-rc.0~1026^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=823a96e2ceab3a552075bde676c03c2cb163ce8f

Add @covers tags for more tests

Change-Id: If2254b3a9e61e056091779a1ea14237aa7b42eb6
---

diff --git a/tests/phpunit/includes/FauxRequestTest.php b/tests/phpunit/includes/FauxRequestTest.php
index 9fe694da03..013ced31cc 100644
--- a/tests/phpunit/includes/FauxRequestTest.php
+++ b/tests/phpunit/includes/FauxRequestTest.php
@@ -39,13 +39,19 @@ class FauxRequestTest extends PHPUnit_Framework_TestCase {
 		$this->assertEquals( '', $req->getText( 'z' ) );
 	}
 
-	// Integration test for parent method.
+	/**
+	 * Integration test for parent method
+	 * @covers FauxRequest::getVal
+	 */
 	public function testGetVal() {
 		$req = new FauxRequest( [ 'crlf' => "A\r\nb" ] );
 		$this->assertSame( "A\r\nb", $req->getVal( 'crlf' ), 'CRLF' );
 	}
 
-	// Integration test for parent method.
+	/**
+	 * Integration test for parent method
+	 * @covers FauxRequest::getRawVal
+	 */
 	public function testGetRawVal() {
 		$req = new FauxRequest( [
 			'x' => 'Value',
diff --git a/tests/phpunit/includes/htmlform/HTMLRestrictionsFieldTest.php b/tests/phpunit/includes/htmlform/HTMLRestrictionsFieldTest.php
index 9ec4f97fd0..57e8654535 100644
--- a/tests/phpunit/includes/htmlform/HTMLRestrictionsFieldTest.php
+++ b/tests/phpunit/includes/htmlform/HTMLRestrictionsFieldTest.php
@@ -1,5 +1,8 @@
 <?php
 
+/**
+ * @covers HTMLRestrictionsField
+ */
 class HTMLRestrictionsFieldTest extends PHPUnit_Framework_TestCase {
 	public function testConstruct() {
 		$field = new HTMLRestrictionsField( [ 'fieldname' => 'restrictions' ] );
diff --git a/tests/phpunit/includes/libs/DeferredStringifierTest.php b/tests/phpunit/includes/libs/DeferredStringifierTest.php
index cba293926e..82f24f7404 100644
--- a/tests/phpunit/includes/libs/DeferredStringifierTest.php
+++ b/tests/phpunit/includes/libs/DeferredStringifierTest.php
@@ -1,9 +1,11 @@
 <?php
 
+/**
+ * @covers DeferredStringifier
+ */
 class DeferredStringifierTest extends PHPUnit_Framework_TestCase {
 
 	/**
-	 * @covers DeferredStringifier
 	 * @dataProvider provideToString
 	 */
 	public function testToString( $params, $expected ) {
diff --git a/tests/phpunit/includes/libs/DnsSrvDiscovererTest.php b/tests/phpunit/includes/libs/DnsSrvDiscovererTest.php
index cfc2d91b0d..52316f32b3 100644
--- a/tests/phpunit/includes/libs/DnsSrvDiscovererTest.php
+++ b/tests/phpunit/includes/libs/DnsSrvDiscovererTest.php
@@ -1,8 +1,10 @@
 <?php
 
+/**
+ * @covers DnsSrvDiscoverer
+ */
 class DnsSrvDiscovererTest extends PHPUnit_Framework_TestCase {
 	/**
-	 * @covers DnsSrvDiscoverer
 	 * @dataProvider provideRecords
 	 */
 	public function testPickServer( $params, $expected ) {
diff --git a/tests/phpunit/includes/libs/IPTest.php b/tests/phpunit/includes/libs/IPTest.php
index e47c4ba12a..9d3bd292b4 100644
--- a/tests/phpunit/includes/libs/IPTest.php
+++ b/tests/phpunit/includes/libs/IPTest.php
@@ -561,7 +561,7 @@ class IPTest extends PHPUnit_Framework_TestCase {
 	}
 
 	/**
-	 * Test for IP::splitHostAndPort().
+	 * @covers IP::splitHostAndPort()
 	 * @dataProvider provideSplitHostAndPort
 	 */
 	public function testSplitHostAndPort( $expected, $input, $description ) {
@@ -588,7 +588,7 @@ class IPTest extends PHPUnit_Framework_TestCase {
 	}
 
 	/**
-	 * Test for IP::combineHostAndPort()
+	 * @covers IP::combineHostAndPort()
 	 * @dataProvider provideCombineHostAndPort
 	 */
 	public function testCombineHostAndPort( $expected, $input, $description ) {
@@ -612,7 +612,7 @@ class IPTest extends PHPUnit_Framework_TestCase {
 	}
 
 	/**
-	 * Test for IP::sanitizeRange()
+	 * @covers IP::sanitizeRange()
 	 * @dataProvider provideIPCIDRs
 	 */
 	public function testSanitizeRange( $input, $expected, $description ) {
@@ -636,7 +636,7 @@ class IPTest extends PHPUnit_Framework_TestCase {
 	}
 
 	/**
-	 * Test for IP::prettifyIP()
+	 * @covers IP::prettifyIP()
 	 * @dataProvider provideIPsToPrettify
 	 */
 	public function testPrettifyIP( $ip, $prettified ) {
diff --git a/tests/phpunit/includes/libs/ProcessCacheLRUTest.php b/tests/phpunit/includes/libs/ProcessCacheLRUTest.php
index 9c189d1293..e9b2764e50 100644
--- a/tests/phpunit/includes/libs/ProcessCacheLRUTest.php
+++ b/tests/phpunit/includes/libs/ProcessCacheLRUTest.php
@@ -58,6 +58,7 @@ class ProcessCacheLRUTest extends PHPUnit_Framework_TestCase {
 
 	/**
 	 * Highlight diff between assertEquals and assertNotSame
+	 * @coversNothing
 	 */
 	public function testPhpUnitArrayEquality() {
 		$one = [ 'A' => 1, 'B' => 2 ];
diff --git a/tests/phpunit/includes/libs/SamplingStatsdClientTest.php b/tests/phpunit/includes/libs/SamplingStatsdClientTest.php
index c5bc03ea5d..3439df8b0e 100644
--- a/tests/phpunit/includes/libs/SamplingStatsdClientTest.php
+++ b/tests/phpunit/includes/libs/SamplingStatsdClientTest.php
@@ -3,6 +3,9 @@
 use Liuggio\StatsdClient\Entity\StatsdData;
 use Liuggio\StatsdClient\Sender\SenderInterface;
 
+/**
+ * @covers SamplingStatsdClient
+ */
 class SamplingStatsdClientTest extends PHPUnit_Framework_TestCase {
 	/**
 	 * @dataProvider samplingDataProvider
diff --git a/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php b/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php
index 742eb95dc4..d2188a1f73 100644
--- a/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php
+++ b/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php
@@ -1,5 +1,5 @@
 <?php
-/*
+/**
  * @group Media
  * @covers MimeAnalyzer
  */
diff --git a/tests/phpunit/includes/libs/rdbms/TransactionProfilerTest.php b/tests/phpunit/includes/libs/rdbms/TransactionProfilerTest.php
index b6ea4265ba..e6ccb34061 100644
--- a/tests/phpunit/includes/libs/rdbms/TransactionProfilerTest.php
+++ b/tests/phpunit/includes/libs/rdbms/TransactionProfilerTest.php
@@ -3,6 +3,9 @@
 use Wikimedia\Rdbms\TransactionProfiler;
 use Psr\Log\LoggerInterface;
 
+/**
+ * @covers \Wikimedia\Rdbms\TransactionProfiler
+ */
 class TransactionProfilerTest extends PHPUnit_Framework_TestCase {
 	public function testAffected() {
 		$logger = $this->getMockBuilder( LoggerInterface::class )->getMock();
diff --git a/tests/phpunit/includes/utils/AvroValidatorTest.php b/tests/phpunit/includes/utils/AvroValidatorTest.php
index 7559e22499..4fccd3e718 100644
--- a/tests/phpunit/includes/utils/AvroValidatorTest.php
+++ b/tests/phpunit/includes/utils/AvroValidatorTest.php
@@ -9,6 +9,9 @@
  * dataprovider.
  */
 
+/**
+ * @covers AvroValidator
+ */
 class AvroValidatorTest extends PHPUnit_Framework_TestCase {
 	public function setUp() {
 		if ( !class_exists( 'AvroSchema' ) ) {
diff --git a/tests/phpunit/includes/utils/MWCryptHashTest.php b/tests/phpunit/includes/utils/MWCryptHashTest.php
index 905d14ca09..7ea229d345 100644
--- a/tests/phpunit/includes/utils/MWCryptHashTest.php
+++ b/tests/phpunit/includes/utils/MWCryptHashTest.php
@@ -1,9 +1,10 @@
 <?php
+
 /**
- *
  * @group Hash
+ *
+ * @covers MWCryptHash
  */
-
 class MWCryptHashTest extends PHPUnit_Framework_TestCase {
 
 	public function testHashLength() {