From: Reedy <reedy@wikimedia.org>
Date: Sun, 14 Apr 2019 21:10:40 +0000 (+0100)
Subject: Rename PhpBugTests -> PhpXMLBugTester
X-Git-Tag: 1.34.0-rc.0~1981
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=79502d48e636a31c05ef5f52753a634767cbc4cb

Rename PhpBugTests -> PhpXMLBugTester

Only contains one class (probably should be removed when we bump to PHP 7 fully)

Change-Id: Iab2bb837e2ed5d5556bd49f4236030b43aba29f1
---

diff --git a/.phpcs.xml b/.phpcs.xml
index b4503a631d..aa79ce63d6 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -70,7 +70,6 @@
 			Whitelist existing violations, but enable the sniff to prevent
 			any new occurrences.
 		-->
-		<exclude-pattern>*/includes/installer/PhpBugTests\.php</exclude-pattern>
 		<exclude-pattern>*/includes/specials/SpecialMostinterwikis\.php</exclude-pattern>
 		<exclude-pattern>*/includes/diff/DairikiDiff\.php</exclude-pattern>
 		<exclude-pattern>*/includes/specials/SpecialAncientpages\.php</exclude-pattern>
diff --git a/autoload.php b/autoload.php
index fe5e7cfa33..2ec234ab51 100644
--- a/autoload.php
+++ b/autoload.php
@@ -1103,7 +1103,7 @@ $wgAutoloadLocalClasses = [
 	'PerRowAugmentor' => __DIR__ . '/includes/search/PerRowAugmentor.php',
 	'PermissionsError' => __DIR__ . '/includes/exception/PermissionsError.php',
 	'PhpHttpRequest' => __DIR__ . '/includes/http/PhpHttpRequest.php',
-	'PhpXmlBugTester' => __DIR__ . '/includes/installer/PhpBugTests.php',
+	'PhpXmlBugTester' => __DIR__ . '/includes/installer/PhpXmlBugTester.php',
 	'Pingback' => __DIR__ . '/includes/Pingback.php',
 	'PoolCounter' => __DIR__ . '/includes/poolcounter/PoolCounter.php',
 	'PoolCounterNull' => __DIR__ . '/includes/poolcounter/PoolCounterNull.php',
diff --git a/includes/installer/PhpBugTests.php b/includes/installer/PhpBugTests.php
deleted file mode 100644
index 4e1e365dbf..0000000000
--- a/includes/installer/PhpBugTests.php
+++ /dev/null
@@ -1,49 +0,0 @@
-<?php
-/**
- * Classes for self-contained tests for known bugs in PHP.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
- * @file
- */
-
-/**
- * @defgroup PHPBugTests PHP known bugs tests
- */
-/**
- * Test for PHP+libxml2 bug which breaks XML input subtly with certain versions.
- * Known fixed with PHP 5.2.9 + libxml2-2.7.3
- * @see https://bugs.php.net/bug.php?id=45996
- * @ingroup PHPBugTests
- */
-class PhpXmlBugTester {
-	private $parsedData = '';
-	public $ok = false;
-
-	public function __construct() {
-		$charData = '<b>c</b>';
-		$xml = '<a>' . htmlspecialchars( $charData ) . '</a>';
-
-		$parser = xml_parser_create();
-		xml_set_character_data_handler( $parser, [ $this, 'chardata' ] );
-		$parsedOk = xml_parse( $parser, $xml, true );
-		$this->ok = $parsedOk && ( $this->parsedData == $charData );
-	}
-
-	public function chardata( $parser, $data ) {
-		$this->parsedData .= $data;
-	}
-}
diff --git a/includes/installer/PhpXmlBugTester.php b/includes/installer/PhpXmlBugTester.php
new file mode 100644
index 0000000000..4e1e365dbf
--- /dev/null
+++ b/includes/installer/PhpXmlBugTester.php
@@ -0,0 +1,49 @@
+<?php
+/**
+ * Classes for self-contained tests for known bugs in PHP.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
+ */
+
+/**
+ * @defgroup PHPBugTests PHP known bugs tests
+ */
+/**
+ * Test for PHP+libxml2 bug which breaks XML input subtly with certain versions.
+ * Known fixed with PHP 5.2.9 + libxml2-2.7.3
+ * @see https://bugs.php.net/bug.php?id=45996
+ * @ingroup PHPBugTests
+ */
+class PhpXmlBugTester {
+	private $parsedData = '';
+	public $ok = false;
+
+	public function __construct() {
+		$charData = '<b>c</b>';
+		$xml = '<a>' . htmlspecialchars( $charData ) . '</a>';
+
+		$parser = xml_parser_create();
+		xml_set_character_data_handler( $parser, [ $this, 'chardata' ] );
+		$parsedOk = xml_parse( $parser, $xml, true );
+		$this->ok = $parsedOk && ( $this->parsedData == $charData );
+	}
+
+	public function chardata( $parser, $data ) {
+		$this->parsedData .= $data;
+	}
+}