From: Reedy <reedy@wikimedia.org>
Date: Tue, 29 May 2018 16:21:31 +0000 (+0100)
Subject: Add @deprecated tags to various class_alias calls
X-Git-Tag: 1.34.0-rc.0~5261
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=765370a6db20c95907abd9ed1b6d4a285638acb3

Add @deprecated tags to various class_alias calls

Bug: T195576
Change-Id: I10cd8415891bfe4a278eee06c9cfe905b3e036dc
---

diff --git a/RELEASE-NOTES-1.32 b/RELEASE-NOTES-1.32
index b016d0bf5c..3d193d4d2e 100644
--- a/RELEASE-NOTES-1.32
+++ b/RELEASE-NOTES-1.32
@@ -153,6 +153,7 @@ because of Phabricator reports.
 * IcuCollation::getICUVersion() is deprecated, as you can just use the PHP
   constant INTL_ICU_VERSION directly in all versions that MediaWiki supports.
 * Parser::fetchFile() is deprecated. Use ::fetchFileAndTitle() instead.
+* The ApiQueryContributions class has been renamed to ApiQueryUserContribs.
 
 === Other changes in 1.32 ===
 * Soft hyphens (U+00AD) are now automatically removed from titles; these
diff --git a/includes/api/ApiQueryUserContribs.php b/includes/api/ApiQueryUserContribs.php
index 4c6672b7aa..140ff6d8c2 100644
--- a/includes/api/ApiQueryUserContribs.php
+++ b/includes/api/ApiQueryUserContribs.php
@@ -832,4 +832,8 @@ class ApiQueryUserContribs extends ApiQueryBase {
 	}
 }
 
+/**
+ * @since 1.9
+ * @deprecated since 1.32
+ */
 class_alias( ApiQueryUserContribs::class, 'ApiQueryContributions' );
diff --git a/includes/libs/rdbms/database/DBConnRef.php b/includes/libs/rdbms/database/DBConnRef.php
index 7fed3e1cab..dedf6eab98 100644
--- a/includes/libs/rdbms/database/DBConnRef.php
+++ b/includes/libs/rdbms/database/DBConnRef.php
@@ -639,4 +639,8 @@ class DBConnRef implements IDatabase {
 	}
 }
 
+/**
+ * @since 1.22
+ * @deprecated since 1.29
+ */
 class_alias( DBConnRef::class, 'DBConnRef' );
diff --git a/includes/libs/rdbms/database/Database.php b/includes/libs/rdbms/database/Database.php
index aeda5b9ce0..1a68a93302 100644
--- a/includes/libs/rdbms/database/Database.php
+++ b/includes/libs/rdbms/database/Database.php
@@ -4639,4 +4639,7 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware
 }
 
 class_alias( Database::class, 'DatabaseBase' ); // b/c for old name
+/**
+ * @deprecated since 1.29
+ */
 class_alias( Database::class, 'Database' ); // b/c global alias
diff --git a/includes/libs/rdbms/database/DatabaseMssql.php b/includes/libs/rdbms/database/DatabaseMssql.php
index 4c187f2357..768e0c60c4 100644
--- a/includes/libs/rdbms/database/DatabaseMssql.php
+++ b/includes/libs/rdbms/database/DatabaseMssql.php
@@ -1418,4 +1418,7 @@ class DatabaseMssql extends Database {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DatabaseMssql::class, 'DatabaseMssql' );
diff --git a/includes/libs/rdbms/database/DatabaseMysqlBase.php b/includes/libs/rdbms/database/DatabaseMysqlBase.php
index 047213908e..953f63d2ff 100644
--- a/includes/libs/rdbms/database/DatabaseMysqlBase.php
+++ b/includes/libs/rdbms/database/DatabaseMysqlBase.php
@@ -1580,4 +1580,7 @@ abstract class DatabaseMysqlBase extends Database {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DatabaseMysqlBase::class, 'DatabaseMysqlBase' );
diff --git a/includes/libs/rdbms/database/DatabaseMysqli.php b/includes/libs/rdbms/database/DatabaseMysqli.php
index 0a5450cc5e..31cdd7c810 100644
--- a/includes/libs/rdbms/database/DatabaseMysqli.php
+++ b/includes/libs/rdbms/database/DatabaseMysqli.php
@@ -341,4 +341,7 @@ class DatabaseMysqli extends DatabaseMysqlBase {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DatabaseMysqli::class, 'DatabaseMysqli' );
diff --git a/includes/libs/rdbms/database/DatabasePostgres.php b/includes/libs/rdbms/database/DatabasePostgres.php
index 9610839c15..807d9cc240 100644
--- a/includes/libs/rdbms/database/DatabasePostgres.php
+++ b/includes/libs/rdbms/database/DatabasePostgres.php
@@ -1444,4 +1444,7 @@ SQL;
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DatabasePostgres::class, 'DatabasePostgres' );
diff --git a/includes/libs/rdbms/database/DatabaseSqlite.php b/includes/libs/rdbms/database/DatabaseSqlite.php
index a6a153a387..5f37c1d176 100644
--- a/includes/libs/rdbms/database/DatabaseSqlite.php
+++ b/includes/libs/rdbms/database/DatabaseSqlite.php
@@ -1106,4 +1106,7 @@ class DatabaseSqlite extends Database {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DatabaseSqlite::class, 'DatabaseSqlite' );
diff --git a/includes/libs/rdbms/database/IDatabase.php b/includes/libs/rdbms/database/IDatabase.php
index ca3fd52cf4..21451292bb 100644
--- a/includes/libs/rdbms/database/IDatabase.php
+++ b/includes/libs/rdbms/database/IDatabase.php
@@ -2117,4 +2117,7 @@ interface IDatabase {
 	public function setIndexAliases( array $aliases );
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( IDatabase::class, 'IDatabase' );
diff --git a/includes/libs/rdbms/database/resultwrapper/FakeResultWrapper.php b/includes/libs/rdbms/database/resultwrapper/FakeResultWrapper.php
index 12e59b598f..aeb5d8de60 100644
--- a/includes/libs/rdbms/database/resultwrapper/FakeResultWrapper.php
+++ b/includes/libs/rdbms/database/resultwrapper/FakeResultWrapper.php
@@ -62,4 +62,7 @@ class FakeResultWrapper extends ResultWrapper {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( FakeResultWrapper::class, 'FakeResultWrapper' );
diff --git a/includes/libs/rdbms/database/resultwrapper/ResultWrapper.php b/includes/libs/rdbms/database/resultwrapper/ResultWrapper.php
index df354af8ec..1355e2263e 100644
--- a/includes/libs/rdbms/database/resultwrapper/ResultWrapper.php
+++ b/includes/libs/rdbms/database/resultwrapper/ResultWrapper.php
@@ -119,4 +119,7 @@ class ResultWrapper implements IResultWrapper {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( ResultWrapper::class, 'ResultWrapper' );
diff --git a/includes/libs/rdbms/encasing/Blob.php b/includes/libs/rdbms/encasing/Blob.php
index 7bc3eacfe8..6a28e358b7 100644
--- a/includes/libs/rdbms/encasing/Blob.php
+++ b/includes/libs/rdbms/encasing/Blob.php
@@ -18,4 +18,7 @@ class Blob implements IBlob {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( Blob::class, 'Blob' );
diff --git a/includes/libs/rdbms/exception/DBAccessError.php b/includes/libs/rdbms/exception/DBAccessError.php
index 97e03b26fe..aa545cd727 100644
--- a/includes/libs/rdbms/exception/DBAccessError.php
+++ b/includes/libs/rdbms/exception/DBAccessError.php
@@ -31,4 +31,7 @@ class DBAccessError extends DBUnexpectedError {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DBAccessError::class, 'DBAccessError' );
diff --git a/includes/libs/rdbms/exception/DBConnectionError.php b/includes/libs/rdbms/exception/DBConnectionError.php
index 91d98dc145..4c5bc9a079 100644
--- a/includes/libs/rdbms/exception/DBConnectionError.php
+++ b/includes/libs/rdbms/exception/DBConnectionError.php
@@ -38,4 +38,7 @@ class DBConnectionError extends DBExpectedError {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DBConnectionError::class, 'DBConnectionError' );
diff --git a/includes/libs/rdbms/exception/DBError.php b/includes/libs/rdbms/exception/DBError.php
index aad219dd29..1a5f4a3b55 100644
--- a/includes/libs/rdbms/exception/DBError.php
+++ b/includes/libs/rdbms/exception/DBError.php
@@ -43,4 +43,7 @@ class DBError extends RuntimeException {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DBError::class, 'DBError' );
diff --git a/includes/libs/rdbms/exception/DBExpectedError.php b/includes/libs/rdbms/exception/DBExpectedError.php
index 7e46420daa..73bc1f1829 100644
--- a/includes/libs/rdbms/exception/DBExpectedError.php
+++ b/includes/libs/rdbms/exception/DBExpectedError.php
@@ -55,4 +55,7 @@ class DBExpectedError extends DBError implements MessageSpecifier {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DBExpectedError::class, 'DBExpectedError' );
diff --git a/includes/libs/rdbms/exception/DBQueryError.php b/includes/libs/rdbms/exception/DBQueryError.php
index e6870a7e2e..0be08cdb07 100644
--- a/includes/libs/rdbms/exception/DBQueryError.php
+++ b/includes/libs/rdbms/exception/DBQueryError.php
@@ -67,4 +67,7 @@ class DBQueryError extends DBExpectedError {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DBQueryError::class, 'DBQueryError' );
diff --git a/includes/libs/rdbms/exception/DBReadOnlyError.php b/includes/libs/rdbms/exception/DBReadOnlyError.php
index 439334391c..cdde1a7468 100644
--- a/includes/libs/rdbms/exception/DBReadOnlyError.php
+++ b/includes/libs/rdbms/exception/DBReadOnlyError.php
@@ -27,4 +27,7 @@ namespace Wikimedia\Rdbms;
 class DBReadOnlyError extends DBExpectedError {
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DBReadOnlyError::class, 'DBReadOnlyError' );
diff --git a/includes/libs/rdbms/exception/DBReplicationWaitError.php b/includes/libs/rdbms/exception/DBReplicationWaitError.php
index 457431e93b..c5dd8ae19c 100644
--- a/includes/libs/rdbms/exception/DBReplicationWaitError.php
+++ b/includes/libs/rdbms/exception/DBReplicationWaitError.php
@@ -28,4 +28,7 @@ namespace Wikimedia\Rdbms;
 class DBReplicationWaitError extends DBExpectedError {
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DBReplicationWaitError::class, 'DBReplicationWaitError' );
diff --git a/includes/libs/rdbms/exception/DBTransactionError.php b/includes/libs/rdbms/exception/DBTransactionError.php
index 62a078cdba..34b4c91948 100644
--- a/includes/libs/rdbms/exception/DBTransactionError.php
+++ b/includes/libs/rdbms/exception/DBTransactionError.php
@@ -27,4 +27,7 @@ namespace Wikimedia\Rdbms;
 class DBTransactionError extends DBExpectedError {
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DBTransactionError::class, 'DBTransactionError' );
diff --git a/includes/libs/rdbms/exception/DBTransactionSizeError.php b/includes/libs/rdbms/exception/DBTransactionSizeError.php
index d2622e11a7..b3f464b8c9 100644
--- a/includes/libs/rdbms/exception/DBTransactionSizeError.php
+++ b/includes/libs/rdbms/exception/DBTransactionSizeError.php
@@ -30,4 +30,7 @@ class DBTransactionSizeError extends DBTransactionError {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DBTransactionSizeError::class, 'DBTransactionSizeError' );
diff --git a/includes/libs/rdbms/exception/DBUnexpectedError.php b/includes/libs/rdbms/exception/DBUnexpectedError.php
index 9c67eb5ffa..2c506ca1aa 100644
--- a/includes/libs/rdbms/exception/DBUnexpectedError.php
+++ b/includes/libs/rdbms/exception/DBUnexpectedError.php
@@ -27,4 +27,7 @@ namespace Wikimedia\Rdbms;
 class DBUnexpectedError extends DBError {
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( DBUnexpectedError::class, 'DBUnexpectedError' );
diff --git a/includes/libs/rdbms/field/Field.php b/includes/libs/rdbms/field/Field.php
index 7918f36067..48d5546eb4 100644
--- a/includes/libs/rdbms/field/Field.php
+++ b/includes/libs/rdbms/field/Field.php
@@ -32,4 +32,7 @@ interface Field {
 	function isNullable();
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( Field::class, 'Field' );
diff --git a/includes/libs/rdbms/lbfactory/LBFactory.php b/includes/libs/rdbms/lbfactory/LBFactory.php
index 7f5990d32b..e8ec25083e 100644
--- a/includes/libs/rdbms/lbfactory/LBFactory.php
+++ b/includes/libs/rdbms/lbfactory/LBFactory.php
@@ -713,4 +713,7 @@ abstract class LBFactory implements ILBFactory {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( LBFactory::class, 'LBFactory' );
diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
index 360be4256e..eabcbbdb4f 100644
--- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
@@ -1952,4 +1952,7 @@ class LoadBalancer implements ILoadBalancer {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( LoadBalancer::class, 'LoadBalancer' );
diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php b/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php
index be80cc5eab..d29258f4bb 100644
--- a/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php
@@ -77,4 +77,7 @@ class LoadBalancerSingle extends LoadBalancer {
 	}
 }
 
+/**
+ * @deprecated since 1.29
+ */
 class_alias( LoadBalancerSingle::class, 'LoadBalancerSingle' );