From: Volker E Date: Fri, 13 Jan 2017 00:35:31 +0000 (-0800) Subject: Remove deprecated `.mw-ui-constructive` class for text and anchors X-Git-Tag: 1.31.0-rc.0~4296^2 X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=75eea101420fd48bb99bbf7dfb42a0694da13f01 Remove deprecated `.mw-ui-constructive` class for text and anchors Removing deprecated, no longer in use `.mw-ui-constructive` modifier CSS class for mediawiki.UI text and anchors. Bug: T155203 Change-Id: I9bcd90ebbebbaece13e0cf9f36afd5964d49dc3b --- diff --git a/resources/src/mediawiki.ui/components/anchors.less b/resources/src/mediawiki.ui/components/anchors.less index 4c4e129834..ff38d0df20 100644 --- a/resources/src/mediawiki.ui/components/anchors.less +++ b/resources/src/mediawiki.ui/components/anchors.less @@ -48,22 +48,16 @@ Styleguide 6.2. &.mw-ui-destructive { .mixin-mw-ui-anchor-styles( @colorDestructive ); } - - //`.mw-ui-constructive` is deprecated; consolidated with `progressive`, see T110555 - &.mw-ui-constructive { - .mixin-mw-ui-anchor-styles( @colorConstructive ); - } } /* Quiet anchors -Use quiet anchors when they are less important and alongside other progressive/destructive/progressive +Use quiet anchors when they are less important and alongside other progressive/destructive anchors. Use of quiet anchors is not recommended on mobile/tablet due to lack of hover state. Markup: Progressive -Constructive Destructive Styleguide 6.2.1. diff --git a/resources/src/mediawiki.ui/components/text.less b/resources/src/mediawiki.ui/components/text.less index 555174559f..30593bfe68 100644 --- a/resources/src/mediawiki.ui/components/text.less +++ b/resources/src/mediawiki.ui/components/text.less @@ -16,7 +16,6 @@ Text Context classes may be used on elements with only plain-text content with the mw-ui-text base. When the context classes are used on interactive and block-level elements, the appropriate alternative base type classes should also be used. For example, mw-ui-anchor with A, or mw-ui-button with buttons. -'Constructive' is deprecated and merged with 'Progressive'. Markup: Progressive @@ -28,11 +27,10 @@ Styleguide 6.1. .mw-ui-text { // The selector order is like this on purpose; IE 6 ignores the second selector, // so we don't want to accidentally apply this color on all mw-ui-CONTEXT classes - .mw-ui-progressive&, - .mw-ui-constructive& { + &.mw-ui-progressive { color: @colorProgressive; } - .mw-ui-destructive& { + &.mw-ui-destructive { color: @colorDestructive; } } \ No newline at end of file