From: Aaron Schulz <aschulz@wikimedia.org>
Date: Wed, 4 Nov 2015 00:44:52 +0000 (-0800)
Subject: Add updateRevisionOn() sanity check for existing pages too
X-Git-Tag: 1.31.0-rc.0~9111
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=6da45bcaefda29dc942e0805ff17e2e552797c8e

Add updateRevisionOn() sanity check for existing pages too

Change-Id: I4f2fc07b0365183efb431a828d40c557b691b18c
---

diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index ba68e62185..2d5cb786d7 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -1832,7 +1832,10 @@ class WikiPage implements Page, IDBAccessObject {
 				$revisionId = $revision->insertOn( $dbw );
 
 				// Update page_latest and friends to reflect the new revision
-				$this->updateRevisionOn( $dbw, $revision, null, $oldIsRedirect );
+				if ( !$this->updateRevisionOn( $dbw, $revision, null, $oldIsRedirect ) ) {
+					$dbw->rollback( __METHOD__ );
+					throw new MWException( "Failed to update page row to use new revision." );
+				}
 
 				Hooks::run( 'NewRevisionFromEditComplete',
 					array( $this, $revision, $baseRevId, $user ) );