From: Kunal Mehta <legoktm@member.fsf.org>
Date: Thu, 20 Jul 2017 01:56:19 +0000 (-0700)
Subject: Title: Don't create mSubpages member variable
X-Git-Tag: 1.31.0-rc.0~2604^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=61d9828a88940e223461eb4d628b32295201ffbb

Title: Don't create mSubpages member variable

This variable is set and then immediately returned. It's never read
from, so it doesn't make sense as a member variable.

Change-Id: I507895c32b754b8606fb162db321294d31ab6d4e
---

diff --git a/includes/Title.php b/includes/Title.php
index 083a725d98..0728065c30 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -3172,7 +3172,7 @@ class Title implements LinkTarget {
 		if ( $limit > -1 ) {
 			$options['LIMIT'] = $limit;
 		}
-		$this->mSubpages = TitleArray::newFromResult(
+		return TitleArray::newFromResult(
 			$dbr->select( 'page',
 				[ 'page_id', 'page_namespace', 'page_title', 'page_is_redirect' ],
 				$conds,
@@ -3180,7 +3180,6 @@ class Title implements LinkTarget {
 				$options
 			)
 		);
-		return $this->mSubpages;
 	}
 
 	/**