From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 22 Feb 2018 07:42:52 +0000 (-0800)
Subject: rdbms: add type hint to reuseConnection()
X-Git-Tag: 1.31.0-rc.0~541^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=618fef63d2814ae84feee78eadd0fd80a6a8ae90

rdbms: add type hint to reuseConnection()

This avoids IDEA warnings.

Change-Id: Ic772d47785319f111c267461e4e42e9183d2815b
---

diff --git a/includes/libs/rdbms/loadbalancer/ILoadBalancer.php b/includes/libs/rdbms/loadbalancer/ILoadBalancer.php
index 088c3f2c67..7bbb530730 100644
--- a/includes/libs/rdbms/loadbalancer/ILoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/ILoadBalancer.php
@@ -199,7 +199,7 @@ interface ILoadBalancer {
 	 * @param IDatabase $conn
 	 * @throws InvalidArgumentException
 	 */
-	public function reuseConnection( $conn );
+	public function reuseConnection( IDatabase $conn );
 
 	/**
 	 * Get a database connection handle reference
diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
index ccdb48e9af..c87a919602 100644
--- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
@@ -736,7 +736,7 @@ class LoadBalancer implements ILoadBalancer {
 		return $conn;
 	}
 
-	public function reuseConnection( $conn ) {
+	public function reuseConnection( IDatabase $conn ) {
 		$serverIndex = $conn->getLBInfo( 'serverIndex' );
 		$refCount = $conn->getLBInfo( 'foreignPoolRefCount' );
 		if ( $serverIndex === null || $refCount === null ) {