From: Bartosz DziewoƄski Date: Thu, 26 Nov 2015 18:36:18 +0000 (+0100) Subject: mediawiki.ForeignStructuredUpload: Behave correctly when '=' appears in a description X-Git-Tag: 1.31.0-rc.0~8857^2 X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=56af60ab91e0b74af9e416b11fa487e15097f5bc mediawiki.ForeignStructuredUpload: Behave correctly when '=' appears in a description We can't escape it (and we can't deal with '|'), because users might expect these to accept wikitext. Bug: T119691 Change-Id: I10df9ebab408f531812b653b36ed35570311935e --- diff --git a/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js b/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js index c336676245..5e7903970a 100644 --- a/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js +++ b/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js @@ -136,11 +136,12 @@ * @return {string} */ ForeignStructuredUpload.prototype.getDescriptions = function () { - var i, desc, templateCalls = []; + var i, desc, hasEquals, templateCalls = []; for ( i = 0; i < this.descriptions.length; i++ ) { desc = this.descriptions[ i ]; - templateCalls.push( '{{' + desc.language + '|' + desc.text + '}}' ); + hasEquals = desc.text.indexOf( '=' ) !== -1; + templateCalls.push( '{{' + desc.language + ( hasEquals ? '|1=' : '|' ) + desc.text + '}}' ); } return templateCalls.join( '\n' );