From: Pablo Grass Date: Wed, 26 Sep 2018 10:36:45 +0000 (+0200) Subject: wdio-mediawiki: relative internal lookups X-Git-Tag: 1.34.0-rc.0~3979^2 X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=382582f7b9823f3e9b42736dba5577373f50ce36 wdio-mediawiki: relative internal lookups "Internal lookups need to be internal, using ./. This currently works because it executes as part of mediawiki-core, but may fail when used from the published package, because there will not be another "wdio-mediawiki" inside this directory." krinkle Follow-up to a fixme in Ifc49bc5c06eef71da8aff1b1837c32debc2c45dd Change-Id: I86f321a42eaf4cf706b4e899e4cd460654840284 --- diff --git a/tests/selenium/wdio-mediawiki/BlankPage.js b/tests/selenium/wdio-mediawiki/BlankPage.js index ed99bd4fdf..bc759e4931 100644 --- a/tests/selenium/wdio-mediawiki/BlankPage.js +++ b/tests/selenium/wdio-mediawiki/BlankPage.js @@ -1,4 +1,4 @@ -const Page = require( 'wdio-mediawiki/Page' ); +const Page = require( './Page' ); class BlankPage extends Page { get heading() { return browser.element( '#firstHeading' ); } diff --git a/tests/selenium/wdio-mediawiki/LoginPage.js b/tests/selenium/wdio-mediawiki/LoginPage.js index d07934b6fe..8838530586 100644 --- a/tests/selenium/wdio-mediawiki/LoginPage.js +++ b/tests/selenium/wdio-mediawiki/LoginPage.js @@ -1,4 +1,4 @@ -const Page = require( 'wdio-mediawiki/Page' ); +const Page = require( './Page' ); class LoginPage extends Page { get username() { return browser.element( '#wpName1' ); } diff --git a/tests/selenium/wdio-mediawiki/RunJobs.js b/tests/selenium/wdio-mediawiki/RunJobs.js index 9d02d4dc2e..50ac601c5e 100644 --- a/tests/selenium/wdio-mediawiki/RunJobs.js +++ b/tests/selenium/wdio-mediawiki/RunJobs.js @@ -1,5 +1,5 @@ const MWBot = require( 'mwbot' ), - Page = require( 'wdio-mediawiki/Page' ), + Page = require( './Page' ), FRONTPAGE_REQUESTS_MAX_RUNS = 10; // (arbitrary) safe-guard against endless execution /** diff --git a/tests/selenium/wdio-mediawiki/specs/BlankPage.js b/tests/selenium/wdio-mediawiki/specs/BlankPage.js index f9cadcd265..297747966c 100644 --- a/tests/selenium/wdio-mediawiki/specs/BlankPage.js +++ b/tests/selenium/wdio-mediawiki/specs/BlankPage.js @@ -1,5 +1,5 @@ const assert = require( 'assert' ), - BlankPage = require( 'wdio-mediawiki/BlankPage' ); + BlankPage = require( './../BlankPage' ); describe( 'BlankPage', function () { it( 'should have its title @daily', function () {