From: Aaron Schulz <aschulz@wikimedia.org>
Date: Fri, 9 Feb 2018 19:28:59 +0000 (-0800)
Subject: Avoid pointless DB_MASTER connections in User::clearSharedCache()
X-Git-Tag: 1.31.0-rc.0~650^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=36dfd18409e414f4df2aef016753a8cb637b6bac

Avoid pointless DB_MASTER connections in User::clearSharedCache()

Change-Id: Ifc4f489cea4460185cb2d8317f174cabd67f5862
---

diff --git a/includes/user/User.php b/includes/user/User.php
index 97035c2dab..eeade49db6 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -2509,12 +2509,17 @@ class User implements IDBAccessObject, UserIdentity {
 		if ( $mode === 'refresh' ) {
 			$cache->delete( $key, 1 );
 		} else {
-			wfGetDB( DB_MASTER )->onTransactionPreCommitOrIdle(
-				function () use ( $cache, $key ) {
-					$cache->delete( $key );
-				},
-				__METHOD__
-			);
+			$lb = MediaWikiServices::getInstance()->getDBLoadBalancer();
+			if ( $lb->hasOrMadeRecentMasterChanges() ) {
+				$lb->getConnection( DB_MASTER )->onTransactionPreCommitOrIdle(
+					function () use ( $cache, $key ) {
+						$cache->delete( $key );
+					},
+					__METHOD__
+				);
+			} else {
+				$cache->delete( $key );
+			}
 		}
 	}