From: Aaron Schulz <aschulz@wikimedia.org>
Date: Tue, 6 Dec 2016 06:03:21 +0000 (-0500)
Subject: objectcache: Remove broken apcu_set() calls
X-Git-Tag: 1.31.0-rc.0~4665
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=343f94f1fe5e86aac43c1c1617990624c846d1e1

objectcache: Remove broken apcu_set() calls

The method call was misnamed (should be apcu_store) and not needed anyway,
since the other BagOStuff classes fail if no key is present.

Change-Id: I726965e665c2d0c5843d8dd33504810d130b9e98
---

diff --git a/includes/libs/objectcache/APCUBagOStuff.php b/includes/libs/objectcache/APCUBagOStuff.php
index 02b3c928ed..6e6a3adebb 100644
--- a/includes/libs/objectcache/APCUBagOStuff.php
+++ b/includes/libs/objectcache/APCUBagOStuff.php
@@ -72,7 +72,7 @@ class APCUBagOStuff extends APCBagOStuff {
 		if ( apcu_exists( $key . self::KEY_SUFFIX ) ) {
 			return apcu_inc( $key . self::KEY_SUFFIX, $value );
 		} else {
-			return apcu_set( $key . self::KEY_SUFFIX, $value );
+			return false;
 		}
 	}
 
@@ -85,7 +85,7 @@ class APCUBagOStuff extends APCBagOStuff {
 		if ( apcu_exists( $key . self::KEY_SUFFIX ) ) {
 			return apcu_dec( $key . self::KEY_SUFFIX, $value );
 		} else {
-			return apcu_set( $key . self::KEY_SUFFIX, -$value );
+			return false;
 		}
 	}
 }