From: Federico Leva <federicoleva@tiscali.it>
Date: Fri, 6 Sep 2013 11:16:01 +0000 (+0200)
Subject: Clarify "unknown gender" option is a non-answer and resort
X-Git-Tag: 1.31.0-rc.0~18778^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=291db2aeb0f67ca0d6cc0a24b17e1be09b1d0fcf

Clarify "unknown gender" option is a non-answer and resort

It is easier in other languages, but in English some worry
about "I prefer not to detail" not being an answer to the
question used as label of the option; parentheses should
be enough to clarify it is about not answering the question
because you don't care.

Also put such (default) "zero answer" first and move feminine
before male as suggested by Jared to avoid any appearance of
bias in the user interface, though the fallback works that way
in the code anyway for merely grammatical reasons.

Bug: 53311
Bug: 53834
Change-Id: Iea77e903c91063a648fff5e4be41c0be51ac172a
---

diff --git a/includes/Preferences.php b/includes/Preferences.php
index 29d6e07afc..bf3e037f0e 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -335,9 +335,11 @@ class Preferences {
 			'type' => 'radio',
 			'section' => 'personal/i18n',
 			'options' => array(
-				$context->msg( 'gender-male' )->text() => 'male',
+				$context->msg( 'parentheses',
+					$context->msg( 'gender-unknown' )->text()
+				)->text() => 'unknown',
 				$context->msg( 'gender-female' )->text() => 'female',
-				$context->msg( 'gender-unknown' )->text() => 'unknown',
+				$context->msg( 'gender-male' )->text() => 'male',
 			),
 			'label-message' => 'yourgender',
 			'help-message' => 'prefs-help-gender',