From: Adam Wight <awight@wikimedia.org>
Date: Wed, 4 Jul 2018 22:45:09 +0000 (+0200)
Subject: Remove outdated transition code
X-Git-Tag: 1.34.0-rc.0~4872^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=264b4039b30fef75edf519a9d66c048ff7a0238b

Remove outdated transition code

This was a soft transition left over from when "edittime" was the last
form parameter. It has been replaced with an explicit "ultimate" param.

Change-Id: I28767fdf8fab512830fe6e24cacabb598d7cca90
---

diff --git a/includes/EditPage.php b/includes/EditPage.php
index 9a8a4a6a09..de89ab44b6 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -948,12 +948,7 @@ class EditPage {
 			} else {
 				// If we receive the last parameter of the request, we can fairly
 				// claim the POST request has not been truncated.
-
-				// TODO: softened the check for cutover.  Once we determine
-				// that it is safe, we should complete the transition by
-				// removing the "edittime" clause.
-				$this->incompleteForm = ( !$request->getVal( 'wpUltimateParam' )
-					&& is_null( $this->edittime ) );
+				$this->incompleteForm = !$request->getVal( 'wpUltimateParam' );
 			}
 			if ( $this->incompleteForm ) {
 				# If the form is incomplete, force to preview.