From: Timo Tijhof <krinklemail@gmail.com>
Date: Wed, 27 Dec 2017 20:44:38 +0000 (+0100)
Subject: maintenance: Add unit test for Benchmarker class
X-Git-Tag: 1.31.0-rc.0~1072^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=25ce819e1c4fa347a4c4fb10a09a0bcf42377ac4

maintenance: Add unit test for Benchmarker class

Change-Id: I3f835fc07741fd42b8adb5b019f72589429cc14f
---

diff --git a/maintenance/benchmarks/Benchmarker.php b/maintenance/benchmarks/Benchmarker.php
index 832da4db79..ffb8cb353f 100644
--- a/maintenance/benchmarks/Benchmarker.php
+++ b/maintenance/benchmarks/Benchmarker.php
@@ -26,7 +26,9 @@
  * @ingroup Benchmark
  */
 
+// @codeCoverageIgnoreStart
 require_once __DIR__ . '/../Maintenance.php';
+// @codeCoverageIgnoreEnd
 
 /**
  * Base class for benchmark scripts.
diff --git a/tests/phpunit/maintenance/BenchmarkerTest.php b/tests/phpunit/maintenance/BenchmarkerTest.php
new file mode 100644
index 0000000000..69f98bdd00
--- /dev/null
+++ b/tests/phpunit/maintenance/BenchmarkerTest.php
@@ -0,0 +1,135 @@
+<?php
+
+use Wikimedia\TestingAccessWrapper;
+
+/**
+ * @covers Benchmarker
+ */
+class BenchmarkerTest extends PHPUnit_Framework_TestCase {
+	public function testBenchSimple() {
+		$bench = $this->getMockBuilder( Benchmarker::class )
+			->setMethods( [ 'execute', 'output' ] )
+			->getMock();
+		$benchProxy = TestingAccessWrapper::newFromObject( $bench );
+		$benchProxy->defaultCount = 3;
+
+		$count = 0;
+		$bench->bench( [
+			'test' => function () use ( &$count ) {
+					$count++;
+			}
+		] );
+
+		$this->assertSame( 3, $count );
+	}
+
+	public function testBenchSetup() {
+		$bench = $this->getMockBuilder( Benchmarker::class )
+			->setMethods( [ 'execute', 'output' ] )
+			->getMock();
+		$benchProxy = TestingAccessWrapper::newFromObject( $bench );
+		$benchProxy->defaultCount = 2;
+
+		$buffer = [];
+		$bench->bench( [
+			'test' => [
+				'setup' => function () use ( &$buffer ) {
+						$buffer[] = 'setup';
+				},
+				'function' => function () use ( &$buffer ) {
+						$buffer[] = 'run';
+				}
+			]
+		] );
+
+		$this->assertSame( [ 'setup', 'run', 'run' ], $buffer );
+	}
+
+	public function testBenchVerbose() {
+		$bench = $this->getMockBuilder( Benchmarker::class )
+			->setMethods( [ 'execute', 'output', 'hasOption', 'verboseRun' ] )
+			->getMock();
+		$benchProxy = TestingAccessWrapper::newFromObject( $bench );
+		$benchProxy->defaultCount = 1;
+
+		$bench->expects( $this->exactly( 2 ) )->method( 'hasOption' )
+			->will( $this->returnValueMap( [
+					[ 'verbose', true ],
+					[ 'count', false ],
+				] ) );
+
+		$bench->expects( $this->once() )->method( 'verboseRun' )
+			->with( 0 )
+			->willReturn( null );
+
+		$bench->bench( [
+			'test' => function () {
+			}
+		] );
+	}
+
+	public function noop() {
+	}
+
+	public function testBenchName_method() {
+		$bench = $this->getMockBuilder( Benchmarker::class )
+			->setMethods( [ 'execute', 'output', 'addResult' ] )
+			->getMock();
+		$benchProxy = TestingAccessWrapper::newFromObject( $bench );
+		$benchProxy->defaultCount = 1;
+
+		$bench->expects( $this->once() )->method( 'addResult' )
+			->with( $this->callback( function ( $res ) {
+				return isset( $res['name'] ) && $res['name'] === __CLASS__ . '::noop()';
+			} ) );
+
+		$bench->bench( [
+			[ 'function' => [ $this, 'noop' ] ]
+		] );
+	}
+
+	public function testBenchName_string() {
+		$bench = $this->getMockBuilder( Benchmarker::class )
+			->setMethods( [ 'execute', 'output', 'addResult' ] )
+			->getMock();
+		$benchProxy = TestingAccessWrapper::newFromObject( $bench );
+		$benchProxy->defaultCount = 1;
+
+		$bench->expects( $this->once() )->method( 'addResult' )
+			->with( $this->callback( function ( $res ) {
+				return 'strtolower(A)';
+			} ) );
+
+		$bench->bench( [ [
+			'function' => 'strtolower',
+			'args' => [ 'A' ],
+		] ] );
+	}
+
+	/**
+	 * @covers Benchmarker::verboseRun
+	 */
+	public function testVerboseRun() {
+		$bench = $this->getMockBuilder( Benchmarker::class )
+			->setMethods( [ 'execute', 'output', 'hasOption', 'startBench', 'addResult' ] )
+			->getMock();
+		$benchProxy = TestingAccessWrapper::newFromObject( $bench );
+		$benchProxy->defaultCount = 1;
+
+		$bench->expects( $this->exactly( 2 ) )->method( 'hasOption' )
+			->will( $this->returnValueMap( [
+					[ 'verbose', true ],
+					[ 'count', false ],
+				] ) );
+
+		$bench->expects( $this->once() )->method( 'output' )
+			->with( $this->callback( function ( $out ) {
+				return preg_match( '/memory.+ peak/', $out ) === 1;
+			} ) );
+
+		$bench->bench( [
+			'test' => function () {
+			}
+		] );
+	}
+}