From: James D. Forrester <jforrester@wikimedia.org>
Date: Fri, 7 Jul 2017 23:01:17 +0000 (-0700)
Subject: SpecialRecentchanges: Globals for config are bad, m'kay
X-Git-Tag: 1.31.0-rc.0~2762^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=14fc5db36d0c15a6a62d24ee68c3b1ff31061a82

SpecialRecentchanges: Globals for config are bad, m'kay

Change-Id: I9ca7aead42ffee1e891525fc80f3438157f4fb2f
---

diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php
index bec87c592a..05bcc4de6b 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -138,10 +138,6 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
 	 * @param string $subpage
 	 */
 	public function execute( $subpage ) {
-		global $wgStructuredChangeFiltersEnableSaving,
-			$wgStructuredChangeFiltersEnableExperimentalViews,
-			$wgStructuredChangeFiltersEnableLiveUpdate;
-
 		// Backwards-compatibility: redirect to new feed URLs
 		$feedFormat = $this->getRequest()->getVal( 'feed' );
 		if ( !$this->including() && $feedFormat ) {
@@ -184,15 +180,15 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
 			$out->addJsConfigVars( 'wgStructuredChangeFilters', $jsData['groups'] );
 			$out->addJsConfigVars(
 				'wgStructuredChangeFiltersEnableSaving',
-				$wgStructuredChangeFiltersEnableSaving
+				$this->getConfig()->get( 'StructuredChangeFiltersEnableSaving' )
 			);
 			$out->addJsConfigVars(
 				'wgStructuredChangeFiltersEnableExperimentalViews',
-				$wgStructuredChangeFiltersEnableExperimentalViews
+				$this->getConfig()->get( 'StructuredChangeFiltersEnableExperimentalViews' )
 			);
 			$out->addJsConfigVars(
 				'wgStructuredChangeFiltersEnableLiveUpdate',
-				$wgStructuredChangeFiltersEnableLiveUpdate
+				$this->getConfig()->get( 'StructuredChangeFiltersEnableLiveUpdate' )
 			);
 			$out->addJsConfigVars(
 				'wgRCFiltersChangeTags',