From: jeroendedauw <jeroendedauw@gmail.com>
Date: Tue, 8 Sep 2015 00:36:29 +0000 (+0200)
Subject: Remove return of void method results
X-Git-Tag: 1.31.0-rc.0~10058^2
X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=10d117368f2d8af499253e27cc6aa7616fd14de1

Remove return of void method results

Change-Id: I095ba37ceb150fcb7bee9df80201437c78426938
---

diff --git a/includes/StubObject.php b/includes/StubObject.php
index 2dfcdc2f49..49155d6d99 100644
--- a/includes/StubObject.php
+++ b/includes/StubObject.php
@@ -194,7 +194,7 @@ class StubUserLang extends StubObject {
 	public function findVariantLink( &$link, &$nt, $ignoreOtherCond = false ) {
 		global $wgLang;
 		$this->_unstub( 'findVariantLink', 3 );
-		return $wgLang->findVariantLink( $link, $nt, $ignoreOtherCond );
+		$wgLang->findVariantLink( $link, $nt, $ignoreOtherCond );
 	}
 
 	/**
diff --git a/includes/api/ApiResult.php b/includes/api/ApiResult.php
index 608e9e1213..142a780221 100644
--- a/includes/api/ApiResult.php
+++ b/includes/api/ApiResult.php
@@ -1277,7 +1277,7 @@ class ApiResult implements ApiSerializable {
 	 */
 	public static function setElement( &$arr, $name, $value, $flags = 0 ) {
 		wfDeprecated( __METHOD__, '1.25' );
-		return self::setValue( $arr, $name, $value, $flags );
+		self::setValue( $arr, $name, $value, $flags );
 	}
 
 	/**
diff --git a/includes/clientpool/RedisConnectionPool.php b/includes/clientpool/RedisConnectionPool.php
index 117bd2d851..ec0573ef75 100644
--- a/includes/clientpool/RedisConnectionPool.php
+++ b/includes/clientpool/RedisConnectionPool.php
@@ -331,7 +331,7 @@ class RedisConnectionPool implements LoggerAwareInterface {
 	 * @deprecated since 1.23
 	 */
 	public function handleException( $server, RedisConnRef $cref, RedisException $e ) {
-		return $this->handleError( $cref, $e );
+		$this->handleError( $cref, $e );
 	}
 
 	/**
diff --git a/includes/utils/iterators/IteratorDecorator.php b/includes/utils/iterators/IteratorDecorator.php
index 288a311320..c1b50207f9 100644
--- a/includes/utils/iterators/IteratorDecorator.php
+++ b/includes/utils/iterators/IteratorDecorator.php
@@ -37,11 +37,11 @@ abstract class IteratorDecorator implements Iterator {
 	}
 
 	public function next() {
-		return $this->iterator->next();
+		$this->iterator->next();
 	}
 
 	public function rewind() {
-		return $this->iterator->rewind();
+		$this->iterator->rewind();
 	}
 
 	public function valid() {