Don't target log_user_text for registered users

Apparently when log_user_text was added no one bothered to populate it
for existing rows. Sigh, #Technical-Debt.

Bug: T188826
Change-Id: Ice1e6454e439a4abdf9594f6e964478dd484bc20

diff --git a/includes/api/ApiQueryLogEvents.php b/includes/api/ApiQueryLogEvents.php
index 68902a3..84e12d7 100644 (file)
--- a/includes/api/ApiQueryLogEvents.php
+++ b/includes/api/ApiQueryLogEvents.php
@@ -172,10 +172,8 @@ class ApiQueryLogEvents extends ApiQueryBase {
                if ( !is_null( $user ) ) {
                        // Note the joins in $q are the same as those from ->getJoin() above
                        // so we only need to add 'conds' here.
-                       // Don't query by user ID here, it might be able to use the
-                       // log_user_text_time or log_user_text_type_time index.
                        $q = $actorMigration->getWhere(
-                               $db, 'log_user', User::newFromName( $params['user'], false ), false
+                               $db, 'log_user', User::newFromName( $params['user'], false )
                        );
                        $this->addWhere( $q['conds'] );
                }

diff --git a/includes/logging/LogPager.php b/includes/logging/LogPager.php
index d1acacf..24fdfb0 100644 (file)
--- a/includes/logging/LogPager.php
+++ b/includes/logging/LogPager.php
@@ -178,10 +178,8 @@ class LogPager extends ReverseChronologicalPager {
                $name = $usertitle->getText();
 
                // Assume no joins required for log_user
-               // Don't query by user ID here, it might be able to use the
-               // log_user_text_time or log_user_text_type_time index.
                $this->mConds[] = ActorMigration::newMigration()->getWhere(
-                       wfGetDB( DB_REPLICA ), 'log_user', User::newFromName( $name, false ), false
+                       wfGetDB( DB_REPLICA ), 'log_user', User::newFromName( $name, false )
                )['conds'];
 
                $this->enforcePerformerRestrictions();