Yet another attempt to fix the populateIpChanges script
authorMusikAnimal <musikanimal@gmail.com>
Tue, 19 Sep 2017 23:51:34 +0000 (19:51 -0400)
committerMusikAnimal <musikanimal@gmail.com>
Tue, 19 Sep 2017 23:58:33 +0000 (19:58 -0400)
It would seem we'd need to update $blockStart if there are no results
for a given block, and more importantly, continue and not break!

Bug: T175962
Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b954e064

maintenance/populateIpChanges.php

index 17f49ee..f7bcc12 100644 (file)
@@ -88,7 +88,8 @@ TEXT
                        $numRows = $rows->numRows();
 
                        if ( !$rows || $numRows === 0 ) {
-                               break;
+                               $blockStart = $blockEnd + 1;
+                               continue;
                        }
 
                        $this->output( "...checking $numRows revisions for IP edits that need copying, " .