Make assertFileContains not create files by default
authorStanislav Malyshev <smalyshev@gmail.com>
Wed, 5 Sep 2018 22:00:25 +0000 (15:00 -0700)
committerSmalyshev <smalyshev@wikimedia.org>
Wed, 5 Sep 2018 22:21:12 +0000 (22:21 +0000)
This makes us miss test bugs like one in
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/458305

Change-Id: I2a96ed180be216aa615d8506999aa75f04c267bf
Depends-On: Ic85db75c2dba6c1c1fa6fd74dbea64f213609c0d

tests/phpunit/MediaWikiTestCase.php

index 6972165..29e9805 100644 (file)
@@ -2278,7 +2278,7 @@ abstract class MediaWikiTestCase extends PHPUnit\Framework\TestCase {
        protected function assertFileContains(
                $fileName,
                $actualData,
-               $createIfMissing = true,
+               $createIfMissing = false,
                $msg = ''
        ) {
                if ( $createIfMissing ) {