maintenance: Fix broken userOptions maintenance script
authorThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Tue, 10 Sep 2019 08:46:46 +0000 (10:46 +0200)
committerThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Tue, 10 Sep 2019 08:46:46 +0000 (10:46 +0200)
Broken via I973cc60 just a few weeks ago.

Change-Id: I9e60b84acf6c2bf751e2e6cb8e97f0a7cba2764d

maintenance/userOptions.php

index 98f1c24..2f8941f 100644 (file)
@@ -110,11 +110,10 @@ The new option is NOT validated.' );
                                        $ret[$option][$userValue] = ( $ret[$option][$userValue] ?? 0 ) + 1;
                                }
                        } else {
-
                                foreach ( $defaultOptions as $name => $defaultValue ) {
                                        $userValue = $user->getOption( $name );
                                        if ( $userValue != $defaultValue ) {
-                                               $ret[$option][$userValue] = ( $ret[$option][$userValue] ?? 0 ) + 1;
+                                               $ret[$name][$userValue] = ( $ret[$name][$userValue] ?? 0 ) + 1;
                                        }
                                }
                        }