Message: Don't include Title objects in the serialization (part 2)
authorBrad Jorsch <bjorsch@wikimedia.org>
Wed, 28 Nov 2018 15:41:17 +0000 (10:41 -0500)
committerAnomie <bjorsch@wikimedia.org>
Fri, 14 Dec 2018 14:20:41 +0000 (14:20 +0000)
Stringify the title instead. This will help avoid running into the
PHP/HHVM serialization incompatibility described in T210528.

This is part 2: Once all servers have part 1 (and rollback is unlikely)
we can stop storing the Title objects.

Bug: T210528
Change-Id: If3acfeb42788bd675c3022cc1b49dccc9ac1ecbe

includes/Message.php

index 15d9786..4049e11 100644 (file)
@@ -289,7 +289,6 @@ class Message implements MessageSpecifier, Serializable {
                        'parameters' => $this->parameters,
                        'format' => $this->format,
                        'useDatabase' => $this->useDatabase,
-                       'title' => $this->title,
                        'titlestr' => $this->title ? $this->title->getFullText() : null,
                ] );
        }