Fix off by 1 error when displaying the number of a line with an error
authorReedy <reedy@wikimedia.org>
Sun, 24 Mar 2019 20:47:24 +0000 (20:47 +0000)
committerReedy <reedy@wikimedia.org>
Sun, 24 Mar 2019 20:57:31 +0000 (20:57 +0000)
Change-Id: I876ba04f6903127a9d5adedfe0a5e2598a90068c

tests/phpunit/documentation/ReleaseNotesTest.php

index 05742d7..d8d0fdc 100644 (file)
@@ -49,7 +49,8 @@ class ReleaseNotesTest extends MediaWikiTestCase {
                        "$type file '$fileName' is inaccessible."
                );
 
                        "$type file '$fileName' is inaccessible."
                );
 
-               foreach ( $file as $num => $line ) {
+               foreach ( $file as $i => $line ) {
+                       $num = $i + 1;
                        $this->assertLessThanOrEqual(
                                // FILE_IGNORE_NEW_LINES drops the \n at the EOL, so max length is 80 not 81.
                                80,
                        $this->assertLessThanOrEqual(
                                // FILE_IGNORE_NEW_LINES drops the \n at the EOL, so max length is 80 not 81.
                                80,