export: Mark DumpFilter::mark() as being protected
authorThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Fri, 11 Jan 2019 18:25:26 +0000 (19:25 +0100)
committerUmherirrender <umherirrender_de.wp@web.de>
Fri, 11 Jan 2019 18:39:40 +0000 (18:39 +0000)
I used
https://codesearch.wmflabs.org/search/?q=-%3Epass%5C(
to make sure there really is no other call to this. This function really
is meant to be protected.

I also used
https://codesearch.wmflabs.org/search/?q=function%20pass%5C(&files=php
to make sure I got all subclasses.

Required for I7da632c43681438aa886bdb709379f10cd9cc658.

Change-Id: I9aaf95c66a6efa22131de627ce015587a109858b

includes/export/DumpFilter.php
includes/export/DumpNamespaceFilter.php
includes/export/DumpNotalkFilter.php

index 088c7b1..75e149c 100644 (file)
@@ -128,7 +128,7 @@ class DumpFilter {
         * @param object $page
         * @return bool
         */
-       function pass( $page ) {
+       protected function pass( $page ) {
                return true;
        }
 }
index 12b9b55..0b8afa2 100644 (file)
@@ -84,7 +84,7 @@ class DumpNamespaceFilter extends DumpFilter {
         * @param object $page
         * @return bool
         */
-       function pass( $page ) {
+       protected function pass( $page ) {
                $match = isset( $this->namespaces[$page->page_namespace] );
                return $this->invert xor $match;
        }
index d99b1b1..c201c76 100644 (file)
@@ -31,7 +31,7 @@ class DumpNotalkFilter extends DumpFilter {
         * @param object $page
         * @return bool
         */
-       function pass( $page ) {
+       protected function pass( $page ) {
                return !MWNamespace::isTalk( $page->page_namespace );
        }
 }