Add test for newNullRevision with bad page ID
authordaniel <daniel.kinzler@wikimedia.de>
Thu, 11 Jan 2018 12:56:17 +0000 (13:56 +0100)
committerdaniel <daniel.kinzler@wikimedia.de>
Thu, 11 Jan 2018 13:11:19 +0000 (14:11 +0100)
Bug: T184687
Change-Id: I893d71999f034f84bf067dedacb821a74374ea7c

tests/phpunit/includes/RevisionDbTestBase.php

index 6139524..427a95e 100644 (file)
@@ -619,6 +619,16 @@ abstract class RevisionDbTestBase extends MediaWikiTestCase {
                $this->assertEquals( __METHOD__, $rev->getContent()->getNativeData() );
        }
 
+       /**
+        * @covers Revision::newNullRevision
+        */
+       public function testNewNullRevision_badPage() {
+               $dbw = wfGetDB( DB_MASTER );
+               $rev = Revision::newNullRevision( $dbw, -1, 'a null revision', false );
+
+               $this->assertNull( $rev );
+       }
+
        /**
         * @covers Revision::insertOn
         */