UserrightsPage: Avoid passing null target
authorAlex Monk <krenair@gmail.com>
Fri, 26 Jun 2015 18:03:15 +0000 (19:03 +0100)
committerUmherirrender <umherirrender_de.wp@web.de>
Sat, 27 Jun 2015 18:28:58 +0000 (18:28 +0000)
Bug: T103945
Change-Id: I80598ce6d12a73a7a3c399fbacc2a253999177b2

includes/specials/SpecialUserrights.php

index ab53951..0158fdb 100644 (file)
@@ -106,7 +106,7 @@ class UserrightsPage extends SpecialPage {
                        }
                }
 
-               if ( User::getCanonicalName( $this->mTarget ) === $user->getName() ) {
+               if ( $this->mTarget !== null && User::getCanonicalName( $this->mTarget ) === $user->getName() ) {
                        $this->isself = true;
                }
 
@@ -145,6 +145,7 @@ class UserrightsPage extends SpecialPage {
                if (
                        $request->wasPosted() &&
                        $request->getCheck( 'saveusergroups' ) &&
+                       $this->mTarget !== null &&
                        $user->matchEditToken( $request->getVal( 'wpEditToken' ), $this->mTarget )
                ) {
                        // save settings