Deprecate access to TitleValue properties

This switches from private to protected access of TitleValue
properties, and marks them as deprecated instead as per the
deprecation policy.

Partial revert of I3d8315ade6aa70bda43d90b0b32b730d8c9cbd2e

Change-Id: Ie290b6a84635ebb5865e82ae24fe4b27224e601a

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index a76ce0b..8caab05 100644 (file)
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -96,6 +96,8 @@ changes to languages because of Phabricator reports.
 * Due to significant refactoring, method ContribsPager::getUserCond() that had
   no access restriction has been removed.
 * Revision::setUserIdAndName() was deprecated.
+* Access to TitleValue class properties was deprecated, the relevant getters
+  should be used instead.
 
 == Compatibility ==
 MediaWiki 1.31 requires PHP 5.5.9 or later. There is experimental support for

diff --git a/includes/title/TitleValue.php b/includes/title/TitleValue.php
index e2ee967..77c1953 100644 (file)
--- a/includes/title/TitleValue.php
+++ b/includes/title/TitleValue.php
@@ -36,24 +36,28 @@ use Wikimedia\Assert\Assert;
 class TitleValue implements LinkTarget {
 
        /**
+        * @deprecated in 1.31. This class is immutable. Use the getter for access.
         * @var int
         */
-       private $namespace;
+       protected $namespace;
 
        /**
+        * @deprecated in 1.31. This class is immutable. Use the getter for access.
         * @var string
         */
-       private $dbkey;
+       protected $dbkey;
 
        /**
+        * @deprecated in 1.31. This class is immutable. Use the getter for access.
         * @var string
         */
-       private $fragment;
+       protected $fragment;
 
        /**
+        * @deprecated in 1.31. This class is immutable. Use the getter for access.
         * @var string
         */
-       private $interwiki;
+       protected $interwiki;
 
        /**
         * Constructs a TitleValue.