Return to LESS multiple value escape mechanism to prevent invalid output
authorVolker E <volker.e@wikimedia.org>
Thu, 17 Jan 2019 07:14:51 +0000 (23:14 -0800)
committerBartosz Dziewoński <matma.rex@gmail.com>
Mon, 21 Jan 2019 23:54:01 +0000 (00:54 +0100)
LESS doesn't accept JS evaluation in PHP via `'@{arguments}'.replace`,
therefore we need to go back to manual escaping multiple comma separated
values.

Change-Id: I4c46afc012d804350ccee2cd5b1eed4e6ea61d8a

resources/src/mediawiki.widgets.datetime/CalendarWidget.less
resources/src/mediawiki.widgets.datetime/mediawiki.widgets.datetime.definitions.less

index 5e4df47..dff313d 100644 (file)
                        .oo-ui-buttonElement-button {
                                width: 100%;
                                border: 1px solid rgba( 255, 255, 255, 0 );
-                               .oo-ui-transition(
-                                       background-color @transition-base,
-                                       color @transition-base,
-                                       border-color @transition-base
-                               );
+                               .oo-ui-transition( ~'background-color @{transition-base}, color @{transition-base}, border-color @{transition-base}' );
                        }
 
                        &.mw-widgets-datetime-calendarWidget-extra .oo-ui-buttonElement-button {
index a0d6f4a..1dfc73b 100644 (file)
@@ -25,8 +25,7 @@
        }
 }
 
-.oo-ui-transition( @value1, @value2: X, ... ) {
-       @value: ~`'@{arguments}'.replace(/[\[\]]|\,\sX/g, '')`; // stylelint-disable-line function-comma-space-after, function-parentheses-space-inside, function-whitespace-after, value-keyword-case
+.oo-ui-transition( @value ) {
        -webkit-transition: @value;
        -moz-transition: @value;
        transition: @value;