Merge "RCFilters: Prevent live update fetch if model is in conflict"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 3 Aug 2017 11:01:12 +0000 (11:01 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 3 Aug 2017 11:01:13 +0000 (11:01 +0000)
1  2 
resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js

                                        allowArbitrary: true,
                                        validate: $.isNumeric,
                                        range: {
 -                                              min: 1,
 +                                              min: 0, // The server normalizes negative numbers to 0 results
                                                max: 1000
                                        },
                                        sortFunc: function ( a, b ) { return Number( a.name ) - Number( b.name ); },
                                        // we should remove all sticky behavior methods completely
                                        // See T172156
                                        // isSticky: true,
 -                                      filters: displayConfig.arrayLimit.map( function ( num ) {
 +                                      filters: displayConfig.limitArray.map( function ( num ) {
                                                return controller._createFilterDataFromNumber( num, num );
                                        } )
                                },
                                        validate: $.isNumeric,
                                        range: {
                                                min: 0,
 -                                              max: displayConfig.maxLimit
 +                                              max: displayConfig.maxDays
                                        },
                                        sortFunc: function ( a, b ) { return Number( a.name ) - Number( b.name ); },
                                        numToLabelFunc: function ( i ) {
                                                // Hours (1, 2, 6, 12)
                                                0.04166, 0.0833, 0.25, 0.5
                                        // Days
 -                                      ].concat( displayConfig.arrayDays )
 +                                      ].concat( displayConfig.daysArray )
                                                .map( function ( num ) {
                                                        return controller._createFilterDataFromNumber(
                                                                num,
                        new mw.Uri().query.liveupdate;
  
                return !document.hidden &&
+                       !this.filtersModel.hasConflict() &&
                        !this.changesListModel.getNewChangesExist() &&
                        !this.updatingChangesList &&
                        liveUpdateFeatureFlag;