Fix pingback on non-MySQL
authorTim Starling <tstarling@wikimedia.org>
Wed, 1 Aug 2018 01:30:49 +0000 (11:30 +1000)
committerTim Starling <tstarling@wikimedia.org>
Wed, 1 Aug 2018 01:33:19 +0000 (11:33 +1000)
MySQL has its own implementation of upsert(), but the others rely on
$uniqueIndexes being a field list, not a field/value associative array.
The previous code generated an SQL error when checking for existing
values.

Bug: T200864
Change-Id: Ifb56f7f350fbb84144bc6f5a1dd76939816338a6

includes/Pingback.php

index ee608c2..8d7c3b6 100644 (file)
@@ -99,7 +99,7 @@ class Pingback {
                return $dbw->upsert(
                        'updatelog',
                        [ 'ul_key' => $this->key, 'ul_value' => $timestamp ],
-                       [ 'ul_key' => $this->key ],
+                       [ 'ul_key' ],
                        [ 'ul_value' => $timestamp ],
                        __METHOD__
                );