SpecialPage::execute doesn't return anything
authorThiemo Mättig <thiemo.maettig@wikimedia.de>
Mon, 15 Dec 2014 16:45:30 +0000 (17:45 +0100)
committerHoo man <hoo@online.de>
Thu, 25 Dec 2014 01:47:19 +0000 (01:47 +0000)
Change-Id: I6f413a633b71739592aae8c8b2db61ad4abc2a79

includes/specials/SpecialChangeEmail.php

index e09c8ac..06ede61 100644 (file)
@@ -39,7 +39,7 @@ class SpecialChangeEmail extends FormSpecialPage {
        /**
         * @return bool
         */
-       function isListed() {
+       public function isListed() {
                global $wgAuth;
 
                return $wgAuth->allowPropChange( 'emailaddress' );
@@ -54,7 +54,7 @@ class SpecialChangeEmail extends FormSpecialPage {
                $out->disallowUserJs();
                $out->addModules( 'mediawiki.special.changeemail' );
 
-               return parent::execute( $par );
+               parent::execute( $par );
        }
 
        protected function checkExecutePermissions( User $user ) {
@@ -149,7 +149,7 @@ class SpecialChangeEmail extends FormSpecialPage {
         * @param string $newaddr
         * @return Status
         */
-       protected function attemptChange( User $user, $pass, $newaddr ) {
+       private function attemptChange( User $user, $pass, $newaddr ) {
                global $wgAuth;
 
                if ( $newaddr != '' && !Sanitizer::validateEmail( $newaddr ) ) {