RangeChronologicalPager: Don't clear $offset when $this->rangeConds is set

It has the effect of breaking pagination entirely when a date range
is set. Special:Contributions doesn't break this way because it has
its own code clearing start/end when offset is set, but Special:Newfiles
does break.

Change-Id: Ie9b26a4b54ebc608035c942b5bdc6ee26b82bc1e

diff --git a/includes/pager/RangeChronologicalPager.php b/includes/pager/RangeChronologicalPager.php
index 901d576..d3cb566 100644 (file)
--- a/includes/pager/RangeChronologicalPager.php
+++ b/includes/pager/RangeChronologicalPager.php
@@ -99,13 +99,6 @@ abstract class RangeChronologicalPager extends ReverseChronologicalPager {
         * @return array
         */
        protected function buildQueryInfo( $offset, $limit, $descending ) {
-               if ( count( $this->rangeConds ) > 0 ) {
-                       // If range conditions are set, $offset is not used.
-                       // However, if range conditions aren't set, (such as when using paging links)
-                       // use the provided offset to get the proper query.
-                       $offset = '';
-               }
-
                list( $tables, $fields, $conds, $fname, $options, $join_conds ) = parent::buildQueryInfo(
                        $offset,
                        $limit,