changes: Usage of 'noudp' & 'pleasedontudp' no longer exist

Since no usage exist and this was deprecated in 1.31, should it
be removed?

Now I think with the use of Phan and having $send type hinted to
a bool, if a string is used, phan will catch that? :)

Usage
=====

https://codesearch.wmflabs.org/search/?q=(%27noudp%27%7C%27pleasedontudp%27)&i=nope&files=&repos=

Change-Id: Id0482e69e2e2b1cdf0a9ece230e04323bf51324f

diff --git a/includes/changes/RecentChange.php b/includes/changes/RecentChange.php
index eed159d..95c9fa6 100644 (file)
--- a/includes/changes/RecentChange.php
+++ b/includes/changes/RecentChange.php
@@ -369,13 +369,6 @@ class RecentChange implements Taggable {
        public function save( $send = self::SEND_FEED ) {
                global $wgPutIPinRC, $wgUseEnotif, $wgShowUpdatedMarker;
 
-               if ( is_string( $send ) ) {
-                       // Callers used to pass undocumented strings like 'noudp'
-                       // or 'pleasedontudp' instead of self::SEND_NONE (true).
-                       // @deprecated since 1.31 Use SEND_NONE instead.
-                       $send = self::SEND_NONE;
-               }
-
                $dbw = wfGetDB( DB_MASTER );
                if ( !is_array( $this->mExtra ) ) {
                        $this->mExtra = [];

diff --git a/maintenance/dictionary/mediawiki.dic b/maintenance/dictionary/mediawiki.dic
index aa9cb2e..71a15bc 100644 (file)
--- a/maintenance/dictionary/mediawiki.dic
+++ b/maintenance/dictionary/mediawiki.dic
@@ -2843,7 +2843,6 @@ notvisiblerev
 notwatched
 notwikitext
 notype
-noudp
 noupdates
 nouploadmodule
 nouser