User::addGroup could cause duplicate groups

Use array_unique to avoid this case.

Bug: 46844
Change-Id: I14eb6e5a5333d887d71d545e42570493437dd320

diff --git a/includes/User.php b/includes/User.php
index cb5ad7a..dd6407d 100644 (file)
--- a/includes/User.php
+++ b/includes/User.php
@@ -2668,6 +2668,9 @@ class User {
                }
                $this->loadGroups();
                $this->mGroups[] = $group;
+               // In case loadGroups was not called before, we now have the right twice.
+               // Get rid of the duplicate.
+               $this->mGroups = array_unique( $this->mGroups );
                $this->mRights = User::getGroupPermissions( $this->getEffectiveGroups( true ) );
 
                $this->invalidateCache();